Skip to content

feat(react-tag-picker): adds appearance and size props#30742

Merged
bsunderhus merged 1 commit intomicrosoft:masterfrom
bsunderhus:react-tag-picker/feat--adds-appearance-and-size-props
Mar 19, 2024
Merged

feat(react-tag-picker): adds appearance and size props#30742
bsunderhus merged 1 commit intomicrosoft:masterfrom
bsunderhus:react-tag-picker/feat--adds-appearance-and-size-props

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Mar 8, 2024 •
edited
Loading

Previous Behavior

New Behavior

  1. adds appearance prop to TagPicker
  2. adds size prop to TagPicker

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Mar 8, 2024
@github-actions github-actions bot added this to the March Project Cycle Q1 2024 milestone Mar 8, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 8, 2024 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against dfcdaa39a0059d6f4c2e976a7c6a7c3ad22d67a8

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 8, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--adds-appearance-and-size-props branch 2 times, most recently from d2bd121 to 4b13987 Compare March 8, 2024 13:25
@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--adds-appearance-and-size-props branch 2 times, most recently from 4cffdbd to ebc9c78 Compare March 18, 2024 08:44
@bsunderhus bsunderhus mentioned this pull request Mar 18, 2024
Closed
46 tasks
@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--adds-appearance-and-size-props branch from ebc9c78 to d404414 Compare March 18, 2024 13:32
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 642 646 5000
Button mount 304 307 5000
Field mount 1148 1144 5000
FluentProvider mount 728 718 5000
FluentProviderWithTheme mount 80 79 10
FluentProviderWithTheme virtual-rerender 59 60 10
FluentProviderWithTheme virtual-rerender-with-unmount 84 79 10
MakeStyles mount 921 867 50000
Persona mount 1826 1711 5000
SpinButton mount 1389 1405 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2024 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--adds-appearance-and-size-props branch 2 times, most recently from 04c9151 to bca0b5b Compare March 19, 2024 08:59
@bsunderhus bsunderhus marked this pull request as ready for review March 19, 2024 10:11
@bsunderhus bsunderhus requested a review from a team as a code owner March 19, 2024 10:11
@bsunderhus bsunderhus force-pushed the react-tag-picker/feat--adds-appearance-and-size-props branch from bca0b5b to e1b6564 Compare March 19, 2024 13:20
@bsunderhus bsunderhus merged commit aa9a77c into microsoft:master Mar 19, 2024
@bsunderhus bsunderhus deleted the react-tag-picker/feat--adds-appearance-and-size-props branch March 19, 2024 14:15
robertpenner pushed a commit to robertpenner/fluentui that referenced this pull request Apr 11, 2024
@bsunderhus @robertpenner
feat(react-tag-picker): adds appearance and size props (microsoft#30742)
078c191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bsunderhus bsunderhus

Labels

Component: TagPicker Fluent UI react-components (v9)

Projects

None yet

Milestone

March Project Cycle Q1 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@bsunderhus @fabricteam @ling1726