feat(eslint-plugin): register @nx plugin internally in order to be able to consume our custom @nx/workspace-* lint rules by Hotell · Pull Request #30337 · microsoft/fluentui

Hotell · 2024-01-17T10:52:15Z

Previous Behavior

New Behavior

adding a temporary workaround to register workspace lint rules without bigger eslint configuration overhaul that will be don eventually. See referenced epic for more details

Related Issue(s)

Follows: feat(eslint-rules): bootstrap workspace eslint rules project #30335
Implements partially [Feature]: add internal workspace eslint-rules #30332

…le to consume our custom @nx/workspace-* lint rules

fabricteam · 2024-01-17T11:04:47Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	628	604	5000
Button	mount	297	316	5000
Field	mount	1147	1126	5000
FluentProvider	mount	704	700	5000
FluentProviderWithTheme	mount	79	86	10
FluentProviderWithTheme	virtual-rerender	68	66	10
FluentProviderWithTheme	virtual-rerender-with-unmount	72	70	10
MakeStyles	mount	858	861	50000
Persona	mount	1728	1724	5000
SpinButton	mount	1388	1401	5000

codesandbox-ci · 2024-01-17T11:06:06Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bdb7f7c:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2024-01-17T11:06:16Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2024-01-17T11:07:44Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
ButtonMinimalPerf.default	77	81	0.95:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	90	80	1.13:1
AttachmentMinimalPerf.default	85	78	1.09:1
ButtonOverridesMissPerf.default	695	637	1.09:1
DropdownManyItemsPerf.default	407	375	1.09:1
AvatarMinimalPerf.default	111	103	1.08:1
AlertMinimalPerf.default	160	150	1.07:1
GridMinimalPerf.default	186	176	1.06:1
StatusMinimalPerf.default	411	386	1.06:1
ProviderMinimalPerf.default	204	195	1.05:1
ChatMinimalPerf.default	440	423	1.04:1
HeaderMinimalPerf.default	215	206	1.04:1
LabelMinimalPerf.default	218	210	1.04:1
ListNestedPerf.default	326	312	1.04:1
ProviderMergeThemesPerf.default	663	637	1.04:1
RadioGroupMinimalPerf.default	262	253	1.04:1
SegmentMinimalPerf.default	195	188	1.04:1
SplitButtonMinimalPerf.default	2292	2206	1.04:1
TextMinimalPerf.default	198	191	1.04:1
TooltipMinimalPerf.default	1307	1256	1.04:1
AccordionMinimalPerf.default	79	77	1.03:1
CardMinimalPerf.default	314	304	1.03:1
CarouselMinimalPerf.default	257	249	1.03:1
MenuButtonMinimalPerf.default	952	923	1.03:1
TableMinimalPerf.default	242	234	1.03:1
CheckboxMinimalPerf.default	1136	1110	1.02:1
DividerMinimalPerf.default	209	204	1.02:1
DropdownMinimalPerf.default	1414	1393	1.02:1
EmbedMinimalPerf.default	1855	1812	1.02:1
LoaderMinimalPerf.default	194	191	1.02:1
VideoMinimalPerf.default	451	441	1.02:1
AnimationMinimalPerf.default	294	290	1.01:1
ChatDuplicateMessagesPerf.default	151	150	1.01:1
PopupMinimalPerf.default	343	341	1.01:1
PortalMinimalPerf.default	81	80	1.01:1
ReactionMinimalPerf.default	212	210	1.01:1
SliderMinimalPerf.default	741	736	1.01:1
ToolbarMinimalPerf.default	534	528	1.01:1
ListCommonPerf.default	383	384	1:1
MenuMinimalPerf.default	499	498	1:1
CustomToolbarPrototype.default	1470	1475	1:1
DatepickerMinimalPerf.default	3569	3591	0.99:1
FormMinimalPerf.default	224	227	0.99:1
LayoutMinimalPerf.default	193	194	0.99:1
AttachmentSlotsPerf.default	630	642	0.98:1
ButtonSlotsPerf.default	294	300	0.98:1
DialogMinimalPerf.default	432	441	0.98:1
HeaderSlotsPerf.default	442	453	0.98:1
ImageMinimalPerf.default	217	222	0.98:1
InputMinimalPerf.default	521	534	0.98:1
SkeletonMinimalPerf.default	191	194	0.98:1
TableManyItemsPerf.default	1099	1127	0.98:1
TreeMinimalPerf.default	458	468	0.98:1
BoxMinimalPerf.default	192	197	0.97:1
FlexMinimalPerf.default	162	167	0.97:1
RefMinimalPerf.default	104	107	0.97:1
ItemLayoutMinimalPerf.default	681	710	0.96:1
ListMinimalPerf.default	303	316	0.96:1
ListWith60ListItems.default	365	379	0.96:1
RosterPerf.default	1559	1624	0.96:1
ChatWithPopoverPerf.default	182	193	0.94:1
TextAreaMinimalPerf.default	272	295	0.92:1
IconMinimalPerf.default	363	399	0.91:1

fabricteam · 2024-01-17T11:10:27Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-01-17T11:12:29Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`priority-overflow` createOverflowManager	`4.447 kB` `1.853 kB`
`react-accordion` Accordion (including children components)	`93.962 kB` `28.706 kB`
`react-alert` Alert	`83.737 kB` `23.474 kB`
`react-avatar` Avatar	`50.175 kB` `15.944 kB`
`react-avatar` AvatarGroup	`19.704 kB` `7.796 kB`
`react-avatar` AvatarGroupItem	`64.831 kB` `20.274 kB`
`react-badge` Badge	`26.905 kB` `8.729 kB`
`react-badge` CounterBadge	`27.806 kB` `9.024 kB`
`react-badge` PresenceBadge	`25.311 kB` `9.306 kB`
`react-button` Button	`39.513 kB` `11.169 kB`
`react-button` CompoundButton	`46.874 kB` `12.661 kB`
`react-button` MenuButton	`44.292 kB` `12.542 kB`
`react-button` SplitButton	`52.306 kB` `14.134 kB`
`react-button` ToggleButton	`56.559 kB` `13.068 kB`
`react-calendar-compat` Calendar Compat	`142.236 kB` `37.172 kB`
`react-card` Card - All	`94.653 kB` `27.242 kB`
`react-card` Card	`89.477 kB` `25.731 kB`
`react-card` CardFooter	`13.064 kB` `5.385 kB`
`react-card` CardHeader	`15.307 kB` `6.143 kB`
`react-card` CardPreview	`14.015 kB` `5.752 kB`
`react-checkbox` Checkbox	`34.746 kB` `11.902 kB`
`react-combobox` Combobox (including child components)	`97.318 kB` `31.442 kB`
`react-combobox` Dropdown (including child components)	`98.511 kB` `31.431 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`69.901 kB` `20.261 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`210.494 kB` `60.055 kB`
`react-components` react-components: FluentProvider & webLightTheme	`42.388 kB` `14.103 kB`
`react-datepicker-compat` DatePicker Compat	`214.065 kB` `60.087 kB`
`react-dialog` Dialog (including children components)	`95.522 kB` `28.482 kB`
`react-divider` Divider	`20.82 kB` `7.763 kB`
`react-field` Field	`22.427 kB` `8.573 kB`
`react-image` Image	`15.736 kB` `6.228 kB`
`react-infobutton` InfoButton	`132.952 kB` `41.844 kB`
`react-infobutton` InfoLabel	`136.64 kB` `42.986 kB`
`react-input` Input	`26.887 kB` `9.118 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.783 kB` `1.648 kB`
`react-jsx-runtime` JSX Runtime	`4.377 kB` `1.881 kB`
`react-label` Label	`14.149 kB` `5.759 kB`
`react-link` Link	`17.082 kB` `6.911 kB`
`react-menu` Menu (including children components)	`142.794 kB` `43.72 kB`
`react-menu` Menu (including selectable components)	`145.48 kB` `44.227 kB`
`react-message-bar` MessageBar (all components)	`25.181 kB` `9.039 kB`
`react-overflow` hooks only	`12.837 kB` `4.818 kB`
`react-persona` Persona	`57.066 kB` `17.821 kB`
`react-popover` Popover	`121.146 kB` `38.235 kB`
`react-portal` Portal	`12.788 kB` `4.67 kB`
`react-portal-compat` PortalCompatProvider	`7.099 kB` `2.385 kB`
`react-positioning` usePositioning	`26.162 kB` `9.465 kB`
`react-progress` ProgressBar	`17.428 kB` `6.898 kB`
`react-provider` FluentProvider	`22.928 kB` `8.472 kB`
`react-radio` Radio	`32.042 kB` `10.046 kB`
`react-radio` RadioGroup	`15.345 kB` `6.263 kB`
`react-select` Select	`28.609 kB` `10.205 kB`
`react-slider` Slider	`39.15 kB` `12.769 kB`
`react-spinbutton` SpinButton	`36.774 kB` `11.788 kB`
`react-spinner` Spinner	`23.402 kB` `8.467 kB`
`react-switch` Switch	`34.23 kB` `10.995 kB`
`react-table` DataGrid	`157.363 kB` `43.948 kB`
`react-table` Table (Primitives only)	`44.493 kB` `13.921 kB`
`react-table` Table as DataGrid	`130.321 kB` `35.173 kB`
`react-table` Table (Selection only)	`75.365 kB` `20.367 kB`
`react-table` Table (Sort only)	`74.031 kB` `19.976 kB`
`react-tags` InteractionTag	`15.259 kB` `6.058 kB`
`react-tags` Tag	`29.982 kB` `9.439 kB`
`react-tags` TagGroup	`74.404 kB` `22.31 kB`
`react-text` Text - Default	`16.705 kB` `6.569 kB`
`react-text` Text - Wrappers	`19.878 kB` `6.896 kB`
`react-textarea` Textarea	`30.947 kB` `10.476 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.616 kB` `7.317 kB`
`react-theme` Teams: Light theme	`19.287 kB` `5.498 kB`
`react-timepicker-compat` TimePicker	`99.152 kB` `32.873 kB`
`react-toast` Toast (including Toaster)	`93.274 kB` `28.044 kB`
`react-tooltip` Tooltip	`53.515 kB` `18.907 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against b56e712bb5eb830c2b9e3150a399cd7bb4be972a}

size-auditor · 2024-01-17T11:14:21Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b56e712bb5eb830c2b9e3150a399cd7bb4be972a (build)

fabricteam · 2024-01-17T11:16:17Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2024-01-17T11:17:40Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	611	617	5000
Breadcrumb	mount	1657	1696	1000
Checkbox	mount	1652	1681	5000
CheckboxBase	mount	1443	1469	5000
ChoiceGroup	mount	2888	2942	5000
ComboBox	mount	645	636	1000
CommandBar	mount	6131	6073	1000
ContextualMenu	mount	11132	11690	1000
DefaultButton	mount	757	745	5000
DetailsRow	mount	2167	2165	5000
DetailsRowFast	mount	2134	2219	5000
DetailsRowNoStyles	mount	1990	2031	5000
Dialog	mount	2639	2576	1000
DocumentCardTitle	mount	220	239	1000
Dropdown	mount	1926	1928	5000
FocusTrapZone	mount	1133	1105	5000
FocusZone	mount	1053	1070	5000
GroupedList	mount	40556	40662	2
GroupedList	virtual-rerender	17668	19875	2
GroupedList	virtual-rerender-with-unmount	49658	50388	2
GroupedListV2	mount	219	228	2
GroupedListV2	virtual-rerender	210	211	2
GroupedListV2	virtual-rerender-with-unmount	228	228	2
IconButton	mount	1073	1050	5000
Label	mount	322	332	5000
Layer	mount	2690	2670	5000
Link	mount	379	377	5000
MenuButton	mount	920	942	5000
MessageBar	mount	21142	21045	5000
Nav	mount	1889	1895	1000
OverflowSet	mount	787	787	5000
Panel	mount	1744	1740	1000
Persona	mount	758	730	1000
Pivot	mount	856	859	1000
PrimaryButton	mount	818	783	5000
Rating	mount	4536	4466	5000
SearchBox	mount	910	895	5000
Shimmer	mount	1863	1831	5000
Slider	mount	1281	1305	5000
SpinButton	mount	2800	2809	5000
Spinner	mount	384	378	5000
SplitButton	mount	1776	1786	5000
Stack	mount	404	407	5000
StackWithIntrinsicChildren	mount	855	832	5000
StackWithTextChildren	mount	2498	2574	5000
SwatchColorPicker	mount	6102	6082	5000
TagPicker	mount	1435	1439	5000
Text	mount	365	359	5000
TextField	mount	905	932	5000
ThemeProvider	mount	811	810	5000
ThemeProvider	virtual-rerender	580	592	5000
ThemeProvider	virtual-rerender-with-unmount	1248	1237	5000
Toggle	mount	593	602	5000
buttonNative	mount	190	184	5000

packages/eslint-plugin/src/internal.js

feat(eslint-plugin): register @nx plugin internally in order to be ab…

bdb7f7c

…le to consume our custom @nx/workspace-* lint rules

Hotell changed the title ~~feat(eslint-plugin): register @nx plugin internally in order to be ab…~~ feat(eslint-plugin): register @nx plugin internally in order to be able to consume our custom @nx/workspace-* lint rules Jan 17, 2024

github-actions bot added this to the January Project Cycle Q1 2024 milestone Jan 17, 2024

Hotell mentioned this pull request Jan 17, 2024

[Feature]: add internal workspace eslint-rules #30332

Closed

4 tasks

Hotell added Package: eslint-plugin Area: Linting labels Jan 17, 2024

Hotell commented Jan 17, 2024

View reviewed changes

packages/eslint-plugin/src/internal.js Show resolved Hide resolved

Hotell marked this pull request as ready for review January 17, 2024 11:34

Hotell requested a review from a team as a code owner January 17, 2024 11:34

tudorpopams self-requested a review January 17, 2024 13:10

tudorpopams approved these changes Jan 17, 2024

View reviewed changes

Hotell merged commit 28dc770 into microsoft:master Jan 18, 2024

Hotell deleted the nx/workspace-eslint/3 branch January 18, 2024 16:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): register @nx plugin internally in order to be able to consume our custom @nx/workspace-* lint rules#30337

feat(eslint-plugin): register @nx plugin internally in order to be able to consume our custom @nx/workspace-* lint rules#30337
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:nx/workspace-eslint/3

Hotell commented Jan 17, 2024 •

edited

Loading

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

codesandbox-ci bot commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

size-auditor bot commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Hotell commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Jan 17, 2024

Perf Analysis (@fluentui/react-components)

Uh oh!

codesandbox-ci bot commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jan 17, 2024

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

Uh oh!

fabricteam commented Jan 17, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jan 17, 2024

📊 Bundle size report

Uh oh!

size-auditor bot commented Jan 17, 2024

Asset size changes

Uh oh!

fabricteam commented Jan 17, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jan 17, 2024

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hotell commented Jan 17, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)