feat(eslint-rules): bootstrap workspace eslint rules project by Hotell · Pull Request #30335 · microsoft/fluentui

Hotell · 2024-01-17T10:51:34Z

New Behavior

see pr title

Related Issue(s)

implements partially [Feature]: add internal workspace eslint-rules #30332

fabricteam · 2024-01-17T11:03:55Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	630	619	5000
Button	mount	310	296	5000
Field	mount	1144	1182	5000
FluentProvider	mount	694	714	5000
FluentProviderWithTheme	mount	81	85	10
FluentProviderWithTheme	virtual-rerender	66	68	10
FluentProviderWithTheme	virtual-rerender-with-unmount	79	85	10
MakeStyles	mount	870	844	50000
Persona	mount	1786	1723	5000
SpinButton	mount	1358	1393	5000

fabricteam · 2024-01-17T11:05:15Z

🕵 fluentuiv8 No visual regressions between this PR and main

codesandbox-ci · 2024-01-17T11:05:26Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 298b205:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2024-01-17T11:06:23Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
LoaderMinimalPerf.default	201	165	1.22:1
AvatarMinimalPerf.default	116	105	1.1:1
ButtonMinimalPerf.default	88	81	1.09:1
TreeWith60ListItems.default	93	85	1.09:1
DividerMinimalPerf.default	209	196	1.07:1
FlexMinimalPerf.default	161	150	1.07:1
PortalMinimalPerf.default	88	83	1.06:1
IconMinimalPerf.default	395	374	1.06:1
TextAreaMinimalPerf.default	296	278	1.06:1
AccordionMinimalPerf.default	82	78	1.05:1
DialogMinimalPerf.default	449	427	1.05:1
ReactionMinimalPerf.default	218	207	1.05:1
ToolbarMinimalPerf.default	538	510	1.05:1
FormMinimalPerf.default	225	217	1.04:1
ButtonOverridesMissPerf.default	635	616	1.03:1
EmbedMinimalPerf.default	1891	1828	1.03:1
PopupMinimalPerf.default	350	341	1.03:1
RadioGroupMinimalPerf.default	269	260	1.03:1
StatusMinimalPerf.default	385	375	1.03:1
AlertMinimalPerf.default	153	150	1.02:1
HeaderMinimalPerf.default	205	201	1.02:1
ImageMinimalPerf.default	233	229	1.02:1
ListCommonPerf.default	392	384	1.02:1
MenuButtonMinimalPerf.default	952	931	1.02:1
RosterPerf.default	1617	1582	1.02:1
TextMinimalPerf.default	190	187	1.02:1
TooltipMinimalPerf.default	1276	1254	1.02:1
AttachmentMinimalPerf.default	84	83	1.01:1
ChatMinimalPerf.default	432	429	1.01:1
LabelMinimalPerf.default	227	225	1.01:1
ListNestedPerf.default	318	315	1.01:1
SliderMinimalPerf.default	726	721	1.01:1
TableManyItemsPerf.default	1099	1087	1.01:1
VideoMinimalPerf.default	418	413	1.01:1
AnimationMinimalPerf.default	300	301	1:1
BoxMinimalPerf.default	186	186	1:1
CheckboxMinimalPerf.default	1118	1121	1:1
DatepickerMinimalPerf.default	3624	3617	1:1
DropdownManyItemsPerf.default	394	393	1:1
ListWith60ListItems.default	363	364	1:1
MenuMinimalPerf.default	504	502	1:1
ProviderMergeThemesPerf.default	652	651	1:1
ProviderMinimalPerf.default	201	200	1:1
TableMinimalPerf.default	233	233	1:1
CustomToolbarPrototype.default	1443	1441	1:1
TreeMinimalPerf.default	474	472	1:1
CarouselMinimalPerf.default	251	253	0.99:1
HeaderSlotsPerf.default	456	460	0.99:1
InputMinimalPerf.default	526	532	0.99:1
ItemLayoutMinimalPerf.default	693	700	0.99:1
LayoutMinimalPerf.default	191	192	0.99:1
SkeletonMinimalPerf.default	193	195	0.99:1
AttachmentSlotsPerf.default	620	632	0.98:1
ChatWithPopoverPerf.default	197	202	0.98:1
DropdownMinimalPerf.default	1415	1437	0.98:1
SplitButtonMinimalPerf.default	2225	2272	0.98:1
CardMinimalPerf.default	299	308	0.97:1
ChatDuplicateMessagesPerf.default	141	146	0.97:1
GridMinimalPerf.default	188	195	0.96:1
ButtonSlotsPerf.default	318	333	0.95:1
ListMinimalPerf.default	305	320	0.95:1
RefMinimalPerf.default	109	115	0.95:1
SegmentMinimalPerf.default	193	205	0.94:1

fabricteam · 2024-01-17T11:09:51Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-01-17T11:11:25Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`priority-overflow` createOverflowManager	`4.447 kB` `1.853 kB`
`react-accordion` Accordion (including children components)	`93.962 kB` `28.706 kB`
`react-alert` Alert	`83.737 kB` `23.474 kB`
`react-avatar` Avatar	`50.175 kB` `15.944 kB`
`react-avatar` AvatarGroup	`19.704 kB` `7.796 kB`
`react-avatar` AvatarGroupItem	`64.831 kB` `20.274 kB`
`react-badge` Badge	`26.905 kB` `8.729 kB`
`react-badge` CounterBadge	`27.806 kB` `9.024 kB`
`react-badge` PresenceBadge	`25.311 kB` `9.306 kB`
`react-button` Button	`39.513 kB` `11.169 kB`
`react-button` CompoundButton	`46.874 kB` `12.661 kB`
`react-button` MenuButton	`44.292 kB` `12.542 kB`
`react-button` SplitButton	`52.306 kB` `14.134 kB`
`react-button` ToggleButton	`56.559 kB` `13.068 kB`
`react-calendar-compat` Calendar Compat	`142.236 kB` `37.172 kB`
`react-card` Card - All	`94.653 kB` `27.242 kB`
`react-card` Card	`89.477 kB` `25.731 kB`
`react-card` CardFooter	`13.064 kB` `5.385 kB`
`react-card` CardHeader	`15.307 kB` `6.143 kB`
`react-card` CardPreview	`14.015 kB` `5.752 kB`
`react-checkbox` Checkbox	`34.746 kB` `11.902 kB`
`react-combobox` Combobox (including child components)	`97.318 kB` `31.442 kB`
`react-combobox` Dropdown (including child components)	`98.511 kB` `31.431 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`69.901 kB` `20.261 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`210.494 kB` `60.055 kB`
`react-components` react-components: FluentProvider & webLightTheme	`42.388 kB` `14.103 kB`
`react-datepicker-compat` DatePicker Compat	`214.065 kB` `60.087 kB`
`react-dialog` Dialog (including children components)	`95.522 kB` `28.482 kB`
`react-divider` Divider	`20.82 kB` `7.763 kB`
`react-field` Field	`22.427 kB` `8.573 kB`
`react-image` Image	`15.736 kB` `6.228 kB`
`react-infobutton` InfoButton	`132.952 kB` `41.844 kB`
`react-infobutton` InfoLabel	`136.64 kB` `42.986 kB`
`react-input` Input	`26.887 kB` `9.118 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.783 kB` `1.648 kB`
`react-jsx-runtime` JSX Runtime	`4.377 kB` `1.881 kB`
`react-label` Label	`14.149 kB` `5.759 kB`
`react-link` Link	`17.082 kB` `6.911 kB`
`react-menu` Menu (including children components)	`142.794 kB` `43.72 kB`
`react-menu` Menu (including selectable components)	`145.48 kB` `44.227 kB`
`react-message-bar` MessageBar (all components)	`25.181 kB` `9.039 kB`
`react-overflow` hooks only	`12.837 kB` `4.818 kB`
`react-persona` Persona	`57.066 kB` `17.821 kB`
`react-popover` Popover	`121.146 kB` `38.235 kB`
`react-portal` Portal	`12.788 kB` `4.67 kB`
`react-portal-compat` PortalCompatProvider	`7.099 kB` `2.385 kB`
`react-positioning` usePositioning	`26.162 kB` `9.465 kB`
`react-progress` ProgressBar	`17.428 kB` `6.898 kB`
`react-provider` FluentProvider	`22.928 kB` `8.472 kB`
`react-radio` Radio	`32.042 kB` `10.046 kB`
`react-radio` RadioGroup	`15.345 kB` `6.263 kB`
`react-select` Select	`28.609 kB` `10.205 kB`
`react-slider` Slider	`39.15 kB` `12.769 kB`
`react-spinbutton` SpinButton	`36.774 kB` `11.788 kB`
`react-spinner` Spinner	`23.402 kB` `8.467 kB`
`react-switch` Switch	`34.23 kB` `10.995 kB`
`react-table` DataGrid	`157.363 kB` `43.948 kB`
`react-table` Table (Primitives only)	`44.493 kB` `13.921 kB`
`react-table` Table as DataGrid	`130.321 kB` `35.173 kB`
`react-table` Table (Selection only)	`75.365 kB` `20.367 kB`
`react-table` Table (Sort only)	`74.031 kB` `19.976 kB`
`react-tags` InteractionTag	`15.259 kB` `6.058 kB`
`react-tags` Tag	`29.982 kB` `9.439 kB`
`react-tags` TagGroup	`74.404 kB` `22.31 kB`
`react-text` Text - Default	`16.705 kB` `6.569 kB`
`react-text` Text - Wrappers	`19.878 kB` `6.896 kB`
`react-textarea` Textarea	`30.947 kB` `10.476 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.616 kB` `7.317 kB`
`react-theme` Teams: Light theme	`19.287 kB` `5.498 kB`
`react-timepicker-compat` TimePicker	`99.152 kB` `32.873 kB`
`react-toast` Toast (including Toaster)	`93.274 kB` `28.044 kB`
`react-tooltip` Tooltip	`53.515 kB` `18.907 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against b56e712bb5eb830c2b9e3150a399cd7bb4be972a}

size-auditor · 2024-01-17T11:13:06Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b56e712bb5eb830c2b9e3150a399cd7bb4be972a (build)

fabricteam · 2024-01-17T11:15:30Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2024-01-17T11:17:55Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	633	629	5000
Breadcrumb	mount	1668	1666	1000
Checkbox	mount	1674	1683	5000
CheckboxBase	mount	1471	1475	5000
ChoiceGroup	mount	2937	2891	5000
ComboBox	mount	659	644	1000
CommandBar	mount	6214	6213	1000
ContextualMenu	mount	12536	12462	1000
DefaultButton	mount	770	758	5000
DetailsRow	mount	2156	2140	5000
DetailsRowFast	mount	2177	2184	5000
DetailsRowNoStyles	mount	1984	1977	5000
Dialog	mount	2765	2636	1000
DocumentCardTitle	mount	218	229	1000
Dropdown	mount	1949	2046	5000
FocusTrapZone	mount	1150	1140	5000
FocusZone	mount	1063	1068	5000
GroupedList	mount	41692	41918	2
GroupedList	virtual-rerender	20153	20025	2
GroupedList	virtual-rerender-with-unmount	50406	50730	2
GroupedListV2	mount	215	226	2
GroupedListV2	virtual-rerender	206	208	2
GroupedListV2	virtual-rerender-with-unmount	231	218	2
IconButton	mount	1042	1097	5000
Label	mount	334	330	5000
Layer	mount	2715	2676	5000
Link	mount	384	382	5000
MenuButton	mount	925	932	5000
MessageBar	mount	21311	21298	5000
Nav	mount	1927	1956	1000
OverflowSet	mount	787	777	5000
Panel	mount	1809	1778	1000
Persona	mount	734	742	1000
Pivot	mount	871	872	1000
PrimaryButton	mount	842	857	5000
Rating	mount	4565	4501	5000
SearchBox	mount	892	899	5000
Shimmer	mount	1872	1884	5000
Slider	mount	1330	1325	5000
SpinButton	mount	2812	2892	5000
Spinner	mount	385	376	5000
SplitButton	mount	1812	1826	5000
Stack	mount	406	404	5000
StackWithIntrinsicChildren	mount	853	863	5000
StackWithTextChildren	mount	2581	2586	5000
SwatchColorPicker	mount	6197	6069	5000
TagPicker	mount	1443	1439	5000
Text	mount	363	371	5000
TextField	mount	944	935	5000
ThemeProvider	mount	825	821	5000
ThemeProvider	virtual-rerender	581	588	5000
ThemeProvider	virtual-rerender-with-unmount	1255	1267	5000
Toggle	mount	620	615	5000
buttonNative	mount	194	199	5000

feat(eslint-rules): bootstrap workspace eslint rules project

298b205

github-actions bot added this to the January Project Cycle Q1 2024 milestone Jan 17, 2024

Hotell mentioned this pull request Jan 17, 2024

[Feature]: add internal workspace eslint-rules #30332

Closed

4 tasks

Hotell added the NX: workspace eslint-rules label Jan 17, 2024

Hotell mentioned this pull request Jan 17, 2024

feat(eslint-plugin): register @nx plugin internally in order to be able to consume our custom @nx/workspace-* lint rules #30337

Merged

Hotell marked this pull request as ready for review January 17, 2024 11:26

Hotell requested a review from a team as a code owner January 17, 2024 11:26

tudorpopams self-requested a review January 17, 2024 13:10

tudorpopams approved these changes Jan 18, 2024

View reviewed changes

Hotell merged commit 8a858e2 into microsoft:master Jan 18, 2024

Hotell deleted the nx/workspace-eslint/1 branch January 18, 2024 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-rules): bootstrap workspace eslint rules project#30335

feat(eslint-rules): bootstrap workspace eslint rules project#30335
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:nx/workspace-eslint/1

Hotell commented Jan 17, 2024 •

edited

Loading

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

codesandbox-ci bot commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

size-auditor bot commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Hotell commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Jan 17, 2024

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Jan 17, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

codesandbox-ci bot commented Jan 17, 2024

Uh oh!

fabricteam commented Jan 17, 2024

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Jan 17, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jan 17, 2024

📊 Bundle size report

Uh oh!

size-auditor bot commented Jan 17, 2024

Asset size changes

Uh oh!

fabricteam commented Jan 17, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jan 17, 2024

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hotell commented Jan 17, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)