Skip to content

Adding Planner, ToDoItem and updated Project filetype icons. Updating FabricCDN url to latest datecode.#30079

Merged
tomi-msft merged 9 commits intomicrosoft:masterfrom
bigbadcapers:caperez/plannerIcons
Jan 9, 2024
Merged

Adding Planner, ToDoItem and updated Project filetype icons. Updating FabricCDN url to latest datecode.#30079
tomi-msft merged 9 commits intomicrosoft:masterfrom
bigbadcapers:caperez/plannerIcons

Conversation

@bigbadcapers
Copy link
Contributor

@bigbadcapers bigbadcapers commented Dec 14, 2023

  • Adding planner, todoitem and updated Project filetype icons. Updating FabricCDN url to latest datecode.
  • Code is up-to-date with the master branch
  • Tested in Storybook
  • You've run yarn change locally
  • Ran yarn lage to update published CDN URL string

@bigbadcapers bigbadcapers requested review from a team, Jahnp and dzearing as code owners December 14, 2023 23:00
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 14, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77c353e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 14, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 99e1128925fa5863a99e311884cc2c710c2606bd

@size-auditor
Copy link

size-auditor bot commented Dec 14, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 99e1128925fa5863a99e311884cc2c710c2606bd (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 14, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 631 617 5000
Breadcrumb mount 1648 1620 1000
Checkbox mount 1675 1679 5000
CheckboxBase mount 1458 1468 5000
ChoiceGroup mount 2947 2955 5000
ComboBox mount 648 645 1000
CommandBar mount 6216 6096 1000
ContextualMenu mount 11483 11481 1000
DefaultButton mount 744 749 5000
DetailsRow mount 2185 2137 5000
DetailsRowFast mount 2193 2171 5000
DetailsRowNoStyles mount 2026 2050 5000
Dialog mount 2618 2753 1000
DocumentCardTitle mount 221 243 1000
Dropdown mount 1960 1947 5000
FocusTrapZone mount 1113 1109 5000
FocusZone mount 1047 1070 5000
GroupedList mount 42016 41859 2
GroupedList virtual-rerender 20085 19965 2
GroupedList virtual-rerender-with-unmount 50221 50208 2
GroupedListV2 mount 222 221 2
GroupedListV2 virtual-rerender 207 203 2
GroupedListV2 virtual-rerender-with-unmount 223 217 2
IconButton mount 1078 1097 5000
Label mount 328 322 5000
Layer mount 2701 2732 5000
Link mount 392 393 5000
MenuButton mount 910 957 5000
MessageBar mount 21125 21135 5000
Nav mount 1960 1925 1000
OverflowSet mount 779 770 5000
Panel mount 1763 1754 1000
Persona mount 728 723 1000
Pivot mount 879 880 1000
PrimaryButton mount 864 848 5000
Rating mount 4563 4668 5000
SearchBox mount 920 916 5000
Shimmer mount 1881 1833 5000
Slider mount 1327 1298 5000
SpinButton mount 2844 2863 5000
Spinner mount 377 377 5000
SplitButton mount 1811 1790 5000
Stack mount 398 399 5000
StackWithIntrinsicChildren mount 850 866 5000
StackWithTextChildren mount 2538 2582 5000
SwatchColorPicker mount 6046 6118 5000
TagPicker mount 1421 1429 5000
Text mount 361 369 5000
TextField mount 905 913 5000
ThemeProvider mount 826 809 5000
ThemeProvider virtual-rerender 579 578 5000
ThemeProvider virtual-rerender-with-unmount 1241 1282 5000
Toggle mount 598 609 5000
buttonNative mount 189 184 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 19, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@bigbadcapers
Copy link
Contributor Author

bigbadcapers commented Jan 9, 2024

Thank you for taking a look at this PR, @tomi-msft ! Could I get your help with merging? It appears protected from letting me do so directly.

@tomi-msft tomi-msft merged commit 8b95a2f into microsoft:master Jan 9, 2024
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jan 10, 2024
@marcosmoura
Merge branch 'master' into fix/react-card/keyboard-focus-regression
5617a43 
* master: (166 commits)
  Remove v0 dependency from v0 compat package (microsoft#30276)
  applying package updates
  Disallow `window` and `document` access for `@fluentui/react` and related packages. (microsoft#30063)
  Update Rating api and stories (microsoft#30092)
  TeachingPopover: Minor style changes (microsoft#30270)
  feat(scripts-gulp): replace lerna with nx (microsoft#30266)
  ci: remove canary and nightly functionality from northstar (microsoft#30264)
  List: Re-initialize on mount in React 18. (microsoft#29881)
  feat(scripts-monorepo): replace lerna/utils with pure nx apis (microsoft#30178)
  chore: remove react-timepicker-compat-preview (microsoft#30263)
  applying package updates
  feat(TimePicker-compat): stable release  (microsoft#30217)
  feat: Implement onPositioningEnd callback (microsoft#30177)
  applying package updates
  v8 registerIcons compat (microsoft#30003)
  Adding Planner, ToDoItem and updated Project filetype icons. Updating FabricCDN url to latest datecode. (microsoft#30079)
  Scaffolds more Nav components (microsoft#30227)
  chore: migrate to nx 17.2 (microsoft#30187)
  applying package updates
  feat: Update position when target or container dimensions change (microsoft#30179)
  ...
@bigbadcapers bigbadcapers deleted the caperez/plannerIcons branch October 28, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzearing dzearing Awaiting requested review from dzearing

@Jahnp Jahnp Awaiting requested review from Jahnp Jahnp is a code owner

1 more reviewer

@tomi-msft tomi-msft tomi-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bigbadcapers @fabricteam @tomi-msft