Improve shadow DOM focus rects#29750
Merged
spmonahan merged 8 commits intomicrosoft:shadow-domfrom Nov 16, 2023
Merged
Conversation
Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 946ea04:
|
khmakoto
approved these changes
Nov 15, 2023
khmakoto
approved these changes
Nov 15, 2023
spmonahan
added a commit
that referenced
this pull request
Nov 16, 2023
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Dec 5, 2023
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Dec 15, 2023
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
that referenced
this pull request
Jan 4, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Jan 4, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Jan 5, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Feb 16, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Feb 16, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Feb 22, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Feb 23, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Feb 26, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Feb 26, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Feb 28, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Mar 1, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
that referenced
this pull request
Mar 8, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Mar 8, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
that referenced
this pull request
Mar 23, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
that referenced
this pull request
Mar 26, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
that referenced
this pull request
Mar 28, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
to spmonahan/fluentui
that referenced
this pull request
Mar 29, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
that referenced
this pull request
Apr 4, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
that referenced
this pull request
Apr 15, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
spmonahan
added a commit
that referenced
this pull request
Apr 18, 2024
* fix: improve focus rects support in shadow DOM Moves the FocusRectsProvider to be outside of the shadow DOM, removing a <div> inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the `:host()` selector on the shadow root. * update snapshots * link: supports focus rects in shadow dom * checkbox: supports focus rects in shadow dom * update styles to support focus rects in shadow dom * update snapshots * update snapshots * Updating snapshots. --------- Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
FocusRectsProviderto be outside of the shadow DOM, removing a<div>inside the shadow root. Now the FocusRects class name is applied to the shadow root host element and the focus visibility styles are applied by using the:host()selector on the shadow root.NOTE: this does not address all focus visibility as some components define these styles outside of the changes here. Those components will be updated in a follow up PR.