Skip to content

chore: migrate to nx 16.10#29617

Merged
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:hotell/nx/migrate-to-16-8
Oct 26, 2023
Merged

chore: migrate to nx 16.10#29617
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:hotell/nx/migrate-to-16-8

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 23, 2023 •
edited
Loading

Previous Behavior

New Behavior

Related Issue(s)

@Hotell Hotell changed the title Hotell/nx/migrate to 16 8 chore: migrate to nx 16.10 Oct 23, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 23, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
330 B
global-context
createContextSelector		 537 B
342 B
priority-overflow
createOverflowManager		 4.341 kB
1.81 kB
react-accordion
Accordion (including children components)		 92.983 kB
28.418 kB
react-alert
Alert		 84.293 kB
23.456 kB
react-avatar
Avatar		 50.534 kB
15.923 kB
react-avatar
AvatarGroup		 20.064 kB
7.894 kB
react-avatar
AvatarGroupItem		 65.19 kB
20.259 kB
react-badge
Badge		 27.264 kB
8.808 kB
react-badge
CounterBadge		 28.165 kB
9.101 kB
react-badge
PresenceBadge		 25.67 kB
9.313 kB
react-button
Button		 40.074 kB
11.292 kB
react-button
CompoundButton		 47.43 kB
12.787 kB
react-button
MenuButton		 44.848 kB
12.668 kB
react-button
SplitButton		 52.862 kB
14.254 kB
react-button
ToggleButton		 57.122 kB
13.194 kB
react-calendar-compat
Calendar Compat		 141.324 kB
36.821 kB
react-card
Card - All		 92.955 kB
26.977 kB
react-card
Card		 87.781 kB
25.462 kB
react-card
CardFooter		 13.423 kB
5.481 kB
react-card
CardHeader		 15.666 kB
6.235 kB
react-card
CardPreview		 14.374 kB
5.854 kB
react-checkbox
Checkbox		 37.505 kB
12.327 kB
react-combobox
Combobox (including child components)		 91.781 kB
29.935 kB
react-combobox
Dropdown (including child components)		 90.223 kB
29.601 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 70.002 kB
20.161 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 207.417 kB
59.289 kB
react-components
react-components: FluentProvider & webLightTheme		 42.286 kB
14 kB
react-datepicker-compat
DatePicker Compat		 212.494 kB
59.326 kB
react-dialog
Dialog (including children components)		 94.473 kB
28.28 kB
react-divider
Divider		 21.179 kB
7.839 kB
react-field
Field		 22.788 kB
8.639 kB
react-image
Image		 16.096 kB
6.317 kB
react-infobutton
InfoButton		 130.729 kB
41.194 kB
react-infobutton
InfoLabel		 134.413 kB
42.351 kB
react-input
Input		 27.247 kB
9.194 kB
react-jsx-runtime
Classic Pragma		 1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime		 4.14 kB
1.741 kB
react-jsx-runtime
JSX Runtime		 4.734 kB
1.983 kB
react-label
Label		 14.508 kB
5.857 kB
react-link
Link		 17.4 kB
6.977 kB
react-menu
Menu (including children components)		 140.176 kB
43.004 kB
react-menu
Menu (including selectable components)		 142.862 kB
43.51 kB
react-message-bar
MessageBar (all components)		 25.54 kB
9.102 kB
react-overflow
hooks only		 12.598 kB
4.754 kB
react-persona
Persona		 57.425 kB
17.798 kB
react-popover
Popover		 119.46 kB
37.714 kB
react-portal
Portal		 12.4 kB
4.541 kB
react-portal-compat
PortalCompatProvider		 6.651 kB
2.252 kB
react-positioning
usePositioning		 25.305 kB
9.162 kB
react-progress
ProgressBar		 17.788 kB
6.986 kB
react-provider
FluentProvider		 22.831 kB
8.429 kB
react-radio
Radio		 31.266 kB
10.267 kB
react-radio
RadioGroup		 15.704 kB
6.35 kB
react-select
Select		 28.968 kB
10.269 kB
react-slider
Slider		 38.349 kB
12.595 kB
react-spinbutton
SpinButton		 37.133 kB
11.856 kB
react-spinner
Spinner		 23.762 kB
8.556 kB
react-switch
Switch		 33.731 kB
10.899 kB
react-table
DataGrid		 157.084 kB
43.906 kB
react-table
Table (Primitives only)		 43.941 kB
13.76 kB
react-table
Table as DataGrid		 130.165 kB
35.174 kB
react-table
Table (Selection only)		 75.777 kB
20.477 kB
react-table
Table (Sort only)		 74.384 kB
20.075 kB
react-tags
InteractionTag		 15.618 kB
6.152 kB
react-tags
Tag		 30.341 kB
9.505 kB
react-tags
TagGroup		 73.816 kB
22.097 kB
react-text
Text - Default		 17.065 kB
6.645 kB
react-text
Text - Wrappers		 20.237 kB
6.965 kB
react-textarea
Textarea		 31.306 kB
10.549 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 34.611 kB
7.295 kB
react-theme
Teams: Light theme		 19.282 kB
5.486 kB
react-toast
Toast (including Toaster)		 92.545 kB
27.805 kB
react-tooltip
Tooltip		 52.466 kB
18.466 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 58cae1419017976d18aeeb2391df8289947f5da6

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 23, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 617 651 5000
Button mount 317 316 5000
Field mount 1093 1161 5000
FluentProvider mount 694 720 5000
FluentProviderWithTheme mount 79 81 10
FluentProviderWithTheme virtual-rerender 71 64 10
FluentProviderWithTheme virtual-rerender-with-unmount 86 73 10
MakeStyles mount 855 863 50000
Persona mount 1732 1721 5000
SpinButton mount 1396 1350 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 23, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 734d546:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 23, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 23, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 88 80 1.1:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 93 80 1.16:1
SliderMinimalPerf.default 783 712 1.1:1
ChatDuplicateMessagesPerf.default 160 148 1.08:1
RadioGroupMinimalPerf.default 266 249 1.07:1
TextMinimalPerf.default 201 187 1.07:1
AttachmentMinimalPerf.default 82 77 1.06:1
LayoutMinimalPerf.default 206 194 1.06:1
SegmentMinimalPerf.default 194 183 1.06:1
BoxMinimalPerf.default 191 184 1.04:1
EmbedMinimalPerf.default 1892 1825 1.04:1
MenuButtonMinimalPerf.default 981 945 1.04:1
ProviderMergeThemesPerf.default 655 630 1.04:1
RefMinimalPerf.default 114 110 1.04:1
ChatWithPopoverPerf.default 198 193 1.03:1
DividerMinimalPerf.default 201 195 1.03:1
ButtonOverridesMissPerf.default 685 671 1.02:1
ButtonSlotsPerf.default 326 320 1.02:1
DialogMinimalPerf.default 453 443 1.02:1
HeaderMinimalPerf.default 207 202 1.02:1
InputMinimalPerf.default 557 547 1.02:1
LoaderMinimalPerf.default 186 182 1.02:1
SplitButtonMinimalPerf.default 2286 2235 1.02:1
IconMinimalPerf.default 384 376 1.02:1
TreeMinimalPerf.default 468 461 1.02:1
CarouselMinimalPerf.default 265 263 1.01:1
DatepickerMinimalPerf.default 3503 3473 1.01:1
ListCommonPerf.default 392 388 1.01:1
CustomToolbarPrototype.default 1460 1441 1.01:1
AttachmentSlotsPerf.default 643 641 1:1
CardMinimalPerf.default 308 309 1:1
CheckboxMinimalPerf.default 1124 1127 1:1
DropdownManyItemsPerf.default 391 390 1:1
ItemLayoutMinimalPerf.default 697 694 1:1
ListMinimalPerf.default 305 304 1:1
MenuMinimalPerf.default 492 494 1:1
PopupMinimalPerf.default 348 347 1:1
ReactionMinimalPerf.default 205 206 1:1
AlertMinimalPerf.default 156 157 0.99:1
AvatarMinimalPerf.default 103 104 0.99:1
ChatMinimalPerf.default 425 429 0.99:1
DropdownMinimalPerf.default 1402 1413 0.99:1
FormMinimalPerf.default 212 215 0.99:1
LabelMinimalPerf.default 221 223 0.99:1
RosterPerf.default 1541 1549 0.99:1
PortalMinimalPerf.default 81 82 0.99:1
ProviderMinimalPerf.default 197 199 0.99:1
SkeletonMinimalPerf.default 200 203 0.99:1
StatusMinimalPerf.default 391 396 0.99:1
TableManyItemsPerf.default 1099 1106 0.99:1
TooltipMinimalPerf.default 1257 1267 0.99:1
VideoMinimalPerf.default 435 438 0.99:1
AnimationMinimalPerf.default 285 291 0.98:1
ImageMinimalPerf.default 216 221 0.98:1
TableMinimalPerf.default 224 229 0.98:1
TextAreaMinimalPerf.default 282 287 0.98:1
ToolbarMinimalPerf.default 518 530 0.98:1
FlexMinimalPerf.default 152 157 0.97:1
ListNestedPerf.default 306 314 0.97:1
ListWith60ListItems.default 372 382 0.97:1
HeaderSlotsPerf.default 458 477 0.96:1
GridMinimalPerf.default 182 198 0.92:1
AccordionMinimalPerf.default 78 86 0.91:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 23, 2023 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 23, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 620 604 5000
Breadcrumb mount 1646 1695 1000
Checkbox mount 1680 1687 5000
CheckboxBase mount 1468 1435 5000
ChoiceGroup mount 2948 2962 5000
ComboBox mount 654 650 1000
CommandBar mount 6173 6195 1000
ContextualMenu mount 12482 12598 1000
DefaultButton mount 759 747 5000
DetailsRow mount 2197 2221 5000
DetailsRowFast mount 2178 2178 5000
DetailsRowNoStyles mount 2019 2031 5000
Dialog mount 2809 2667 1000
DocumentCardTitle mount 230 226 1000
Dropdown mount 1968 1987 5000
FocusTrapZone mount 1130 1126 5000
FocusZone mount 1049 1051 5000
GroupedList mount 41374 41799 2
GroupedList virtual-rerender 17591 20135 2
GroupedList virtual-rerender-with-unmount 50694 50599 2
GroupedListV2 mount 229 221 2
GroupedListV2 virtual-rerender 217 209 2
GroupedListV2 virtual-rerender-with-unmount 231 225 2
IconButton mount 1103 1094 5000
Label mount 331 331 5000
Layer mount 2698 2697 5000
Link mount 398 395 5000
MenuButton mount 922 916 5000
MessageBar mount 21240 21202 5000
Nav mount 1938 1989 1000
OverflowSet mount 784 750 5000
Panel mount 1819 1751 1000
Persona mount 733 722 1000
Pivot mount 864 880 1000
PrimaryButton mount 847 840 5000
Rating mount 4559 4563 5000
SearchBox mount 907 908 5000
Shimmer mount 1897 1848 5000
Slider mount 1297 1292 5000
SpinButton mount 2919 2848 5000
Spinner mount 372 380 5000
SplitButton mount 1850 1887 5000
Stack mount 412 405 5000
StackWithIntrinsicChildren mount 860 851 5000
StackWithTextChildren mount 2620 2566 5000
SwatchColorPicker mount 6165 6114 5000
TagPicker mount 1427 1447 5000
Text mount 372 365 5000
TextField mount 949 945 5000
ThemeProvider mount 834 837 5000
ThemeProvider virtual-rerender 579 575 5000
ThemeProvider virtual-rerender-with-unmount 1266 1268 5000
Toggle mount 611 591 5000
buttonNative mount 188 188 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 23, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Oct 23, 2023 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-northstar-Datepicker 193.835 kB 193.844 kB ExceedsBaseline     9 bytes
office-ui-fabric-react fluentui-react-northstar-Toolbar 180.926 kB 180.935 kB ExceedsBaseline     9 bytes
office-ui-fabric-react fluentui-react-northstar-MenuButton 168.444 kB 168.453 kB ExceedsBaseline     9 bytes
office-ui-fabric-react fluentui-react-northstar-Popup 138.535 kB 138.544 kB ExceedsBaseline     9 bytes
office-ui-fabric-react fluentui-react-northstar-SplitButton 184.764 kB 184.773 kB ExceedsBaseline     9 bytes
office-ui-fabric-react fluentui-react-northstar-Debug 10.621 kB 10.627 kB ExceedsBaseline     6 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 58cae1419017976d18aeeb2391df8289947f5da6 (build)

@Hotell Hotell force-pushed the hotell/nx/migrate-to-16-8 branch from dccd3e9 to 37253d5 Compare October 24, 2023 11:51
@Hotell Hotell force-pushed the hotell/nx/migrate-to-16-8 branch from 37253d5 to 734d546 Compare October 24, 2023 12:15
Hotell
Hotell commented Oct 24, 2023
View reviewed changes
Hotell
Hotell commented Oct 24, 2023
View reviewed changes
Hotell
Hotell commented Oct 24, 2023
View reviewed changes
@Hotell Hotell mentioned this pull request Oct 24, 2023
Closed
@Hotell Hotell marked this pull request as ready for review October 24, 2023 13:19
@Hotell Hotell requested review from a team as code owners October 24, 2023 13:19
@tudorpopams tudorpopams self-requested a review October 25, 2023 12:18
@Hotell Hotell merged commit 0191238 into microsoft:master Oct 26, 2023
@Hotell Hotell deleted the hotell/nx/migrate-to-16-8 branch October 26, 2023 11:02
@Hotell Hotell mentioned this pull request Oct 26, 2023
Merged
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 26, 2023
@marcosmoura
Merge branch 'master' into fix/react-drawer/rename-main-components
4cd4d33 
* master:
  chore: migrate to nx 16.10 (microsoft#29617)
  fix(react-drawer): accessibility tweaks (microsoft#29627)
  Fixing few legend colors not visible in dark mode (microsoft#29652)
  applying package updates
  Fixing dark mode bug for xAxis for Vertical Stacked bar chart (microsoft#29427)
  chore: Refactor RadioGroup stories to use Field, and remove individual storybook page for Radio (microsoft#29268)
  docs: fix description of SelectInitialValue story (microsoft#26493)
  chore: fix specs location (microsoft#29642)
  feat(scripts-task): implement initial verify-packaging task (microsoft#29595)
  feat(tools): replace npmignore with package.json#files for robust control over what we ship to npm (microsoft#29616)
  fix(workspace-plugin): fix storybook and vr-test issues wihtin prepare-initial-release generator (microsoft#29577)
  feat(react-breadcrumb): removed non-interactive item  (microsoft#29623)
  fix(react-motion): prevent from breaking the rule of hooks (microsoft#29628)
  fix(react-toast): invoke useCustomStyleHook_unstable() (microsoft#29632)
  feat: Deprecate Alert component (microsoft#29615)
  chore(react-infobutton, react-components): Deprecate InfoButton and InfoLabel from react-infobutton (microsoft#29605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsunderhus bsunderhus bsunderhus approved these changes

@tudorpopams tudorpopams Awaiting requested review from tudorpopams

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Build System CI

Projects

None yet

Milestone

October Project Cycle Q4 2023

Development

Successfully merging this pull request may close these issues.

workspace: implement ci check to catch typescript AST template strings issue

4 participants

@Hotell @fabricteam @bsunderhus @ling1726