fix(DatePicker): readOnlyTextField styles should win over default TextField's#28891
Merged
sopranopillow merged 8 commits intomicrosoft:masterfrom Aug 17, 2023
Merged
Conversation
…eld classname to avoid getting its values overriden.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 29a81b8:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 669c13cc90c399d2e0e727be721f868c6c6e2932 |
Asset size changes
Baseline commit: 669c13cc90c399d2e0e727be721f868c6c6e2932 (build) |
spmonahan
reviewed
Aug 16, 2023
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 628 | 620 | 5000 | |
| Breadcrumb | mount | 1686 | 1686 | 1000 | |
| Checkbox | mount | 1646 | 1702 | 5000 | |
| CheckboxBase | mount | 1466 | 1506 | 5000 | |
| ChoiceGroup | mount | 2896 | 2875 | 5000 | |
| ComboBox | mount | 668 | 639 | 1000 | |
| CommandBar | mount | 6214 | 6290 | 1000 | |
| ContextualMenu | mount | 13504 | 14818 | 1000 | |
| DefaultButton | mount | 738 | 738 | 5000 | |
| DetailsRow | mount | 2137 | 2168 | 5000 | |
| DetailsRowFast | mount | 2167 | 2171 | 5000 | |
| DetailsRowNoStyles | mount | 1996 | 1998 | 5000 | |
| Dialog | mount | 2624 | 2648 | 1000 | |
| DocumentCardTitle | mount | 234 | 235 | 1000 | |
| Dropdown | mount | 1956 | 1982 | 5000 | |
| FocusTrapZone | mount | 1134 | 1143 | 5000 | |
| FocusZone | mount | 1038 | 1064 | 5000 | |
| GroupedList | mount | 41353 | 41525 | 2 | |
| GroupedList | virtual-rerender | 19730 | 19673 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50168 | 50125 | 2 | |
| GroupedListV2 | mount | 232 | 216 | 2 | |
| GroupedListV2 | virtual-rerender | 225 | 216 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 230 | 228 | 2 | |
| IconButton | mount | 1089 | 1094 | 5000 | |
| Label | mount | 343 | 344 | 5000 | |
| Layer | mount | 2697 | 2695 | 5000 | |
| Link | mount | 375 | 389 | 5000 | |
| MenuButton | mount | 932 | 897 | 5000 | |
| MessageBar | mount | 21397 | 21386 | 5000 | |
| Nav | mount | 1934 | 1912 | 1000 | |
| OverflowSet | mount | 783 | 752 | 5000 | |
| Panel | mount | 2055 | 1780 | 1000 | |
| Persona | mount | 708 | 734 | 1000 | |
| Pivot | mount | 861 | 876 | 1000 | |
| PrimaryButton | mount | 849 | 831 | 5000 | |
| Rating | mount | 4595 | 4651 | 5000 | |
| SearchBox | mount | 907 | 897 | 5000 | |
| Shimmer | mount | 1828 | 1926 | 5000 | |
| Slider | mount | 1300 | 1317 | 5000 | |
| SpinButton | mount | 2829 | 2829 | 5000 | |
| Spinner | mount | 382 | 388 | 5000 | |
| SplitButton | mount | 1817 | 1788 | 5000 | |
| Stack | mount | 410 | 405 | 5000 | |
| StackWithIntrinsicChildren | mount | 849 | 867 | 5000 | |
| StackWithTextChildren | mount | 2597 | 2563 | 5000 | |
| SwatchColorPicker | mount | 6130 | 6104 | 5000 | |
| TagPicker | mount | 1422 | 1412 | 5000 | |
| Text | mount | 369 | 378 | 5000 | |
| TextField | mount | 915 | 912 | 5000 | |
| ThemeProvider | mount | 845 | 839 | 5000 | |
| ThemeProvider | virtual-rerender | 577 | 592 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1272 | 1250 | 5000 | |
| Toggle | mount | 594 | 611 | 5000 | |
| buttonNative | mount | 199 | 199 | 5000 |
khmakoto
approved these changes
Aug 17, 2023
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
fabricteam
reviewed
Aug 17, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 21, 2023
* master: fix(react-drawer): rename values of position prop from left/right to start/end (microsoft#28905) Breadcrumb design team fixes (microsoft#28883) applying package updates chore(react-search-preview): migrate to new slots API (microsoft#28862) docs: Updating version of CDN used and replacing usage of via.placeholder.com with SVG from CDN (microsoft#28895) fix(DatePicker, react-datepicker-compat): Make year picker react to go to today button (microsoft#28907) fix(DatePicker): readOnlyTextField styles should win over default TextField's (microsoft#28891) chore: fix lint warnings for @fluentui/react (microsoft#28888) Lint: fix fluent v9 warnings (microsoft#28889) doc: add drag & drop example (microsoft#28821)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The TextField's classname has the same specificity as the user provided readOnlyTextField classname. This causes the values of readOnlyTextField classname to be overriden.
New Behavior
Merge the default TextField styles and the provided styles so the provided styles win over the default ones.
Related Issue(s)