feat: Hoist intent to imperative API#28224
Merged
ling1726 merged 7 commits intomicrosoft:masterfrom Jun 15, 2023
Merged
Conversation
Adds colors to the ToastTitle icon based on intent, unavailable tokens are labelled with FIXME
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e4f2471:
|
Collaborator
📊 Bundle size report🤖 This report was generated against eb359d9b090fb150ba6a2f948f34de8456ec4a53 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: eb359d9b090fb150ba6a2f948f34de8456ec4a53 (build) |
packages/react-components/react-toast/src/components/ToastContainer/useToastContainer.ts
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Jun 15, 2023
layershifter
approved these changes
Jun 15, 2023
ling1726
added a commit
to ling1726/fluentui
that referenced
this pull request
Jun 15, 2023
Fix of bug from microsoft#28224 The intent prop is not actually required because of `?` in the type. While this is true for creation, it should always be present when passed to context (even if it's undefined).
ling1726
added a commit
that referenced
this pull request
Jun 15, 2023
* fix: Toast intent should always be present in the context Fix of bug from #28224 The intent prop is not actually required because of `?` in the type. While this is true for creation, it should always be present when passed to context (even if it's undefined). * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoists the
intentprop used by the ToastTitle to the imperative API, so that default aria-live politeness can be set based on intent.Also adds colors to the ToastTitle icon based on intent, unavailable tokens are labelled with FIXME
Addresses #26638