Skip to content

fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages#27741

Merged
Hotell merged 4 commits intomicrosoft:masterfrom
Hotell:hotell/build/fix-npm-releases-after-node16
May 2, 2023
Merged

fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages#27741
Hotell merged 4 commits intomicrosoft:masterfrom
Hotell:hotell/build/fix-npm-releases-after-node16

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented May 2, 2023 •
edited
Loading

Previous Behavior

Migration to node16 (which bumped npm to v8) npm publish doesn't work as before.

🚨 only lib-commonjs/* is being published to npm.

I was looking within changelogs of npm and didnt find anything meaningful in terms of breaking changes, although this is definitely a reggression (potentially a bugfix in node14/older npm)

New Behavior

NOTE:

  • npmignore changes were updated by running migrate-converged-pkg generator
  • this solution is not ideal as the dist definitions are clashing.if there is a dist/hello.txt present it will still be published with this configuration although we explicitly say !dist/*.d.ts .
    We should migrate to using files within package.json in near future
  • updated migrate-converged-pkg generator
  • explicitly ignored patterns present in root gitignore which npm now properly parses in order to publish lib,lib-comonjs,lib-amd,dist to npm when executing npm publish

Related Issue(s)

@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 2, 2023
@Hotell Hotell changed the title Hotell/build/fix npm releases after node16 fix: update npmignore files to fix npm8/node16 regression how npm publish works May 2, 2023
@Hotell Hotell force-pushed the hotell/build/fix-npm-releases-after-node16 branch from b421f25 to f76ee90 Compare May 2, 2023 13:07
layershifter
layershifter reviewed May 2, 2023
View reviewed changes
layershifter
layershifter approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@layershifter layershifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hotell please check packages/react-components/theme-designer/.npmignore, some changes looks strange there. Also please update change files to trigges releases

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
priority-overflow
createOverflowManager		 3.194 kB
1.314 kB
react-accordion
Accordion (including children components)		 86.012 kB
26.086 kB
react-alert
Alert		 93.779 kB
22.493 kB
react-avatar
Avatar		 57.544 kB
14.966 kB
react-avatar
AvatarGroup		 15.632 kB
6.258 kB
react-avatar
AvatarGroupItem		 73.758 kB
19.478 kB
react-badge
Badge		 23.512 kB
7.197 kB
react-badge
CounterBadge		 24.416 kB
7.506 kB
react-badge
PresenceBadge		 31.904 kB
8.296 kB
react-button
Button		 37.179 kB
9.534 kB
react-button
CompoundButton		 44.328 kB
11.016 kB
react-button
MenuButton		 41.866 kB
10.861 kB
react-button
SplitButton		 50.254 kB
12.441 kB
react-button
ToggleButton		 55.397 kB
11.435 kB
react-card
Card - All		 86.061 kB
24.345 kB
react-card
Card		 80.997 kB
22.895 kB
react-card
CardFooter		 9.158 kB
3.844 kB
react-card
CardHeader		 11.048 kB
4.538 kB
react-card
CardPreview		 9.963 kB
4.192 kB
react-checkbox
Checkbox		 34.216 kB
10.784 kB
react-combobox
Combobox (including child components)		 87.199 kB
28.095 kB
react-combobox
Dropdown (including child components)		 85.583 kB
27.692 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 65.31 kB
17.931 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 204.34 kB
57.141 kB
react-components
react-components: FluentProvider & webLightTheme		 36.086 kB
11.9 kB
react-datepicker-compat
DatePicker Compat		 220.251 kB
58.471 kB
react-dialog
Dialog (including children components)		 90.867 kB
27.047 kB
react-divider
Divider		 17.399 kB
6.298 kB
react-field
Field		 18.864 kB
7.004 kB
react-image
Image		 11.479 kB
4.573 kB
react-infobutton
InfoButton		 127.925 kB
39.003 kB
react-infobutton
InfoLabel		 131.208 kB
39.996 kB
react-input
Input		 23.972 kB
7.676 kB
react-label
Label		 10.104 kB
4.185 kB
react-link
Link		 12.357 kB
5.091 kB
react-menu
Menu (including children components)		 128.202 kB
39.18 kB
react-menu
Menu (including selectable components)		 131.186 kB
39.696 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 64.465 kB
16.892 kB
react-popover
Popover		 114.917 kB
35.388 kB
react-portal
Portal		 11.649 kB
4.262 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.186 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 13.856 kB
5.434 kB
react-provider
FluentProvider		 18.033 kB
6.666 kB
react-radio
Radio		 27.282 kB
8.661 kB
react-radio
RadioGroup		 11.312 kB
4.71 kB
react-select
Select		 25.357 kB
8.798 kB
react-slider
Slider		 34.112 kB
11.018 kB
react-spinbutton
SpinButton		 33.882 kB
10.325 kB
react-spinner
Spinner		 20.882 kB
6.798 kB
react-switch
Switch		 29.806 kB
9.274 kB
react-table
DataGrid		 147.659 kB
40.567 kB
react-table
Table (Primitives only)		 44.348 kB
12.347 kB
react-table
Table as DataGrid		 130.218 kB
33.128 kB
react-table
Table (Selection only)		 78.132 kB
19.127 kB
react-table
Table (Sort only)		 77.462 kB
18.939 kB
react-text
Text - Default		 12.492 kB
4.92 kB
react-text
Text - Wrappers		 15.624 kB
5.232 kB
react-textarea
Textarea		 27.399 kB
9.041 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.33 kB
6.764 kB
react-theme
Teams: Light theme		 17.895 kB
5.162 kB
react-tooltip
Tooltip		 46.656 kB
16.369 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against b9b2edcd4e2d11c323c9e23b1223f1e63546f1cf

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 22 15 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 705 727 5000
Button mount 367 383 5000
Field mount 1285 1290 5000
FluentProvider mount 910 912 5000
FluentProviderWithTheme mount 118 117 10
FluentProviderWithTheme virtual-rerender 95 93 10
FluentProviderWithTheme virtual-rerender-with-unmount 108 111 10
InfoButton mount 22 15 5000 Possible regression
MakeStyles mount 1119 1148 50000
Persona mount 2044 1991 5000
SpinButton mount 1601 1590 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 311 282 1.1:1
IconMinimalPerf.default 500 472 1.06:1
LoaderMinimalPerf.default 233 221 1.05:1
AttachmentMinimalPerf.default 103 99 1.04:1
ButtonMinimalPerf.default 112 108 1.04:1
ChatWithPopoverPerf.default 248 238 1.04:1
FormMinimalPerf.default 296 285 1.04:1
ListMinimalPerf.default 416 401 1.04:1
RefMinimalPerf.default 144 138 1.04:1
AlertMinimalPerf.default 195 190 1.03:1
AttachmentSlotsPerf.default 805 778 1.03:1
ButtonOverridesMissPerf.default 784 762 1.03:1
ButtonSlotsPerf.default 388 376 1.03:1
CarouselMinimalPerf.default 323 314 1.03:1
LabelMinimalPerf.default 301 293 1.03:1
ListNestedPerf.default 416 405 1.03:1
PortalMinimalPerf.default 123 119 1.03:1
InputMinimalPerf.default 663 648 1.02:1
MenuMinimalPerf.default 652 637 1.02:1
ProviderMinimalPerf.default 255 250 1.02:1
RadioGroupMinimalPerf.default 357 349 1.02:1
SliderMinimalPerf.default 848 833 1.02:1
TextAreaMinimalPerf.default 358 350 1.02:1
CustomToolbarPrototype.default 1837 1804 1.02:1
AccordionMinimalPerf.default 106 105 1.01:1
AvatarMinimalPerf.default 143 142 1.01:1
CardMinimalPerf.default 395 390 1.01:1
CheckboxMinimalPerf.default 1345 1337 1.01:1
DatepickerMinimalPerf.default 4316 4286 1.01:1
ProviderMergeThemesPerf.default 846 837 1.01:1
ReactionMinimalPerf.default 292 289 1.01:1
SegmentMinimalPerf.default 271 269 1.01:1
SplitButtonMinimalPerf.default 2740 2726 1.01:1
TextMinimalPerf.default 273 269 1.01:1
ToolbarMinimalPerf.default 694 686 1.01:1
AnimationMinimalPerf.default 388 387 1:1
DialogMinimalPerf.default 614 612 1:1
DividerMinimalPerf.default 280 280 1:1
DropdownManyItemsPerf.default 480 481 1:1
EmbedMinimalPerf.default 2054 2057 1:1
FlexMinimalPerf.default 219 218 1:1
GridMinimalPerf.default 258 259 1:1
HeaderSlotsPerf.default 624 625 1:1
RosterPerf.default 1663 1656 1:1
PopupMinimalPerf.default 477 475 1:1
StatusMinimalPerf.default 542 541 1:1
TreeMinimalPerf.default 613 612 1:1
BoxMinimalPerf.default 263 265 0.99:1
ListWith60ListItems.default 458 462 0.99:1
MenuButtonMinimalPerf.default 1178 1185 0.99:1
SkeletonMinimalPerf.default 270 272 0.99:1
TableManyItemsPerf.default 1403 1414 0.99:1
TableMinimalPerf.default 318 322 0.99:1
TooltipMinimalPerf.default 1582 1590 0.99:1
DropdownMinimalPerf.default 1747 1774 0.98:1
ItemLayoutMinimalPerf.default 882 902 0.98:1
ChatMinimalPerf.default 553 570 0.97:1
HeaderMinimalPerf.default 273 282 0.97:1
LayoutMinimalPerf.default 270 277 0.97:1
ListCommonPerf.default 492 508 0.97:1
VideoMinimalPerf.default 531 546 0.97:1
ChatDuplicateMessagesPerf.default 185 195 0.95:1
TreeWith60ListItems.default 105 112 0.94:1

@Hotell Hotell marked this pull request as ready for review May 2, 2023 13:25
@Hotell Hotell changed the title fix: update npmignore files to fix npm8/node16 regression how npm publish works fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages May 2, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42159b9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented May 2, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b9b2edcd4e2d11c323c9e23b1223f1e63546f1cf (build)

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 810 813 5000
Breadcrumb mount 2322 2355 1000
Checkbox mount 2134 2178 5000
CheckboxBase mount 1906 1878 5000
ChoiceGroup mount 3756 3730 5000
ComboBox mount 902 921 1000
CommandBar mount 8386 8359 1000
ContextualMenu mount 21714 21923 1000
DefaultButton mount 1010 1028 5000
DetailsRow mount 2928 2940 5000
DetailsRowFast mount 2877 2936 5000
DetailsRowNoStyles mount 2657 2675 5000
Dialog mount 3479 3503 1000
DocumentCardTitle mount 324 341 1000
Dropdown mount 2563 2577 5000
FocusTrapZone mount 1487 1514 5000
FocusZone mount 1429 1486 5000
GroupedList mount 50819 59263 2
GroupedList virtual-rerender 24621 24615 2
GroupedList virtual-rerender-with-unmount 75787 75493 2
GroupedListV2 mount 325 316 2
GroupedListV2 virtual-rerender 296 296 2
GroupedListV2 virtual-rerender-with-unmount 331 332 2
IconButton mount 1446 1415 5000
Label mount 467 457 5000
Layer mount 3624 3640 5000
Link mount 530 526 5000
MenuButton mount 1253 1242 5000
MessageBar mount 28682 28671 5000
Nav mount 2546 2538 1000
OverflowSet mount 1027 1026 5000
Panel mount 2314 2338 1000
Persona mount 967 964 1000
Pivot mount 1229 1169 1000
PrimaryButton mount 1094 1113 5000
Rating mount 5861 5801 5000
SearchBox mount 1153 1158 5000
Shimmer mount 2359 2362 5000
Slider mount 1736 1712 5000
SpinButton mount 3749 3881 5000
Spinner mount 518 533 5000
SplitButton mount 2407 2444 5000
Stack mount 543 545 5000
StackWithIntrinsicChildren mount 1149 1143 5000
StackWithTextChildren mount 3226 3206 5000
SwatchColorPicker mount 8249 8096 5000
TagPicker mount 1994 1992 5000
Text mount 512 498 5000
TextField mount 1202 1192 5000
ThemeProvider mount 1128 1157 5000
ThemeProvider virtual-rerender 783 776 5000
ThemeProvider virtual-rerender-with-unmount 1763 1723 5000
Toggle mount 815 799 5000
buttonNative mount 290 291 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2023

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell merged commit dbda7fa into microsoft:master May 2, 2023
@Hotell Hotell deleted the hotell/build/fix-npm-releases-after-node16 branch May 2, 2023 13:58
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 2, 2023
@marcosmoura
Merge branch 'feat/drawer-components' into feat/drawer-footer
5a4a3d1 
* feat/drawer-components: (120 commits)
  fix: add missing change file
  Component testing - Donut chart (microsoft#27033)
  fix: update .npmignore files to resolve npm8/node16 regression with npm publish for v9 packages (microsoft#27741)
  chore: add .swcrc to .npmignore (generator) (microsoft#27739)
  docs: update API
  Autogenerate react-toast package (microsoft#27730)
  applying package updates
  fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736)
  Add DraggableZone into export map (microsoft#27569)
  Add export for FolderCover.scss (microsoft#27507)
  applying package updates
  Add filetype icon for Microsoft Designer (microsoft#27724)
  ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729)
  fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728)
  Added partition for controlled overflow menu (microsoft#27520)
  Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186)
  Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346)
  chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605)
  chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710)
  chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686)
  ...
@Hotell Hotell mentioned this pull request May 4, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@layershifter layershifter layershifter approved these changes

@tudorpopams tudorpopams tudorpopams approved these changes

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@sopranopillow sopranopillow Awaiting requested review from sopranopillow

@khmakoto khmakoto Awaiting requested review from khmakoto

@YuanboXue-Amber YuanboXue-Amber Awaiting requested review from YuanboXue-Amber

@Mitch-At-Work Mitch-At-Work Awaiting requested review from Mitch-At-Work

@tomi-msft tomi-msft Awaiting requested review from tomi-msft

@ms-acalzaretto ms-acalzaretto Awaiting requested review from ms-acalzaretto

@chpalac chpalac Awaiting requested review from chpalac

@behowell behowell Awaiting requested review from behowell

@spmonahan spmonahan Awaiting requested review from spmonahan

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

@smhigley smhigley Awaiting requested review from smhigley

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bsunderhus bsunderhus

Labels

Area: Build System Fluent UI react-components (v9) Priority 1: High

Projects

None yet

Milestone

May Project Cycle Q2 2023

Development

Successfully merging this pull request may close these issues.

6 participants

@Hotell @fabricteam @layershifter @ling1726 @tudorpopams @bsunderhus