chore(react-tree): restructure stories, add separate category for flat tree#27586
Merged
bsunderhus merged 1 commit intomicrosoft:masterfrom Apr 21, 2023
Merged
Conversation
7417f44 to
8842810
Compare
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 24 | 26 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 830 | 814 | 5000 | |
| Button | mount | 447 | 465 | 5000 | |
| Field | mount | 1494 | 1502 | 5000 | |
| FluentProvider | mount | 1111 | 1096 | 5000 | |
| FluentProviderWithTheme | mount | 146 | 150 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 123 | 132 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 131 | 130 | 10 | |
| InfoButton | mount | 24 | 26 | 5000 | Possible regression |
| MakeStyles | mount | 1336 | 1331 | 50000 | |
| Persona | mount | 2386 | 2375 | 5000 | |
| SpinButton | mount | 1865 | 1809 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 35a0ad8:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 04c2e8a600ef3a446c903ade92b492d1feea60e9 (build) |
f7a62a8 to
1d4fd67
Compare
Hotell
reviewed
Apr 18, 2023
Contributor
|
Can you provide some more context for this PR ? This doesn't say much ty |
Contributor
Author
Yup, sorry there. Forgot this PR was not a draft anymore 😅 |
1d4fd67 to
72dbd7e
Compare
72dbd7e to
35a0ad8
Compare
Contributor
|
I would put the Virtualization example first in the flat tree section since, it's one of the only two use cases you would really need a flat tree for |
ling1726
approved these changes
Apr 21, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 24, 2023
* master: (58 commits) fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655) Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577) chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666) applying package updates applying package updates Make line chart screen reader accessible (microsoft#27632) fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172) docs(react-textarea): Update examples to use Field (microsoft#27644) bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555) applying package updates chore: restructure stories, add separate category for flat tree (microsoft#27586) fix document link (microsoft#27499) fix(react): exclude React.HTMLAttributes defined `content` prop for Tooltip and TooltipHost Prop types to mitigate @types/react breaking changes (microsoft#27467) chore(react-tabs): adopts custom JSX pragma (microsoft#27640) fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable (microsoft#27650) feat(react-datepicker-compat): Move DatePicker compat to stable (microsoft#27378) bugfix(react-tree): fix parent navigation after independency from id (microsoft#27642) applying package updates feat(react-datepicker-compat): Add error handling to DatePicker and update popup's padding (microsoft#27637) feat(public-docsite): Add banner to React component pages to promote v9 (microsoft#27557) ...
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 25, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 25, 2023
* feat/drawer-components: (81 commits) docs: remove TODO marks fix: remove conflict code leftover applying package updates microsoft#25730: TimePicker Default Value Fix, Controllable Usage, Example Updates (microsoft#26482) docs(react-datepicker-compat): Add description to README.md (microsoft#27677) Updated to use single hook selector (microsoft#27491) fix: Make border around Avatar's badge transparent using a mask (microsoft#27527) Disable focus on non-interactive elements (microsoft#27580) feat(react-drawer): implement "prevent close on click outside" feature (microsoft#27551) fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655) Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577) chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666) applying package updates applying package updates Make line chart screen reader accessible (microsoft#27632) fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172) docs(react-textarea): Update examples to use Field (microsoft#27644) bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555) applying package updates chore: restructure stories, add separate category for flat tree (microsoft#27586) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Tree stories were split into:
New Behavior
Splits stories into:
This way, scenarios that are specific to a flat tree can be properly segregated from the rest