fix(react-dialog): DialogContent scrollbar always visible#27367
Merged
bsunderhus merged 2 commits intomicrosoft:masterfrom Mar 31, 2023
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bded5d0:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a36754d76ad5afb444c9f6975266bd32ba2e7b1d (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
ling1726
reviewed
Mar 29, 2023
packages/react-components/react-dialog/src/components/DialogContent/useDialogContentStyles.ts
Outdated
Show resolved
Hide resolved
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 920 | 891 | 5000 | |
| Button | mount | 596 | 588 | 5000 | |
| Field | mount | 1552 | 1541 | 5000 | |
| FluentProvider | mount | 1112 | 1077 | 5000 | |
| FluentProviderWithTheme | mount | 288 | 290 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 283 | 287 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 283 | 288 | 10 | |
| InfoButton | mount | 204 | 213 | 5000 | |
| MakeStyles | mount | 1386 | 1376 | 50000 | |
| Persona | mount | 2150 | 2060 | 5000 | |
| SpinButton | mount | 1862 | 1834 | 5000 |
fabricteam
reviewed
Mar 29, 2023
6727304 to
bded5d0
Compare
Contributor
|
This seems to work. Did some quick testing on the Codesandbox. I'm gonna have to do some changes to my code though because I add padding-top and padding-bottom to the const useDialogStyles = makeStyles({
sections: {
display: 'flex',
flexDirection: 'column',
rowGap: tokens.spacingVerticalL,
paddingTop: tokens.spacingVerticalS,
paddingBottom: tokens.spacingVerticalXXXL,
},
title: {
overflowWrap: 'break-word',
},
})
function MyCustomDialog({
open = true,
onClose,
title,
children,
}) {
const dialogStyles = useDialogStyles()
return (
<Dialog
open={open}
onOpenChange={(_event, data) => !data.open && onClose?.()}
>
<DialogSurface>
<DialogBody>
<DialogTitle className={dialogStyles.title}>{title}</DialogTitle>
<DialogContent className={dialogStyles.sections}>{children}</DialogContent>
<DialogActions>
<DialogTrigger disableButtonEnhancement><Button /></DialogTrigger>
<Button />
</DialogActions>
</DialogBody>
</DialogSurface>
</Dialog>
)
} |
ling1726
approved these changes
Mar 31, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 4, 2023
* master: (39 commits) Added merge tests for custom styles (microsoft#27086) fix: make Option's checkIcon slot render conditionally (microsoft#27409) docs: add subcomponents to Combobox and Dropdown docs (microsoft#27410) Breadcrumb spec (microsoft#26742) bugfix(react-utilities): increments SlotRenderFunction signature to include children (microsoft#27377) fix: Menu should not steal focus on close (microsoft#27414) Fixed Overflow component when there's more then one children element (microsoft#27402) feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected (microsoft#27364) applying package updates feat(scripts-tasks): make perf test setup generic (microsoft#26920) fix: ColorPicker preview color updated to ignore forced colors (microsoft#27394) fix: Fix babel build error on windows (microsoft#27406) chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker (microsoft#27351) fix(react-dialog): DialogContent scrollbar always visible (microsoft#27367) docs: Add tokens search (microsoft#27265) chore(scripts-tasks): remove not needed api-extractor task logs (microsoft#27094) chore(react-tree): adds e2e flat tree tests (microsoft#27318) applying package updates Accessibility fix for empty vertical bar chart (microsoft#26254) fix(react-datepicker-compat): Fix theming issues with all themes and WHCM (microsoft#27361) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
PR #27248 introduced a regression where the scrollbar would always be visible due to a negative margin.
New Behavior
height: 100%fromDialogContent, which makes heightauto, which will properly varyDialogContentheight taking into account the negative margin in cases where the scrollbar should be visible or notheightandwidthstyles fromDialogContent,DialogBodyandDialogSurfaceRelated Issue(s)