Include values in Fluent 9 storybook typography table#27189
Merged
layershifter merged 2 commits intomicrosoft:masterfrom Mar 14, 2023
Merged
Include values in Fluent 9 storybook typography table#27189layershifter merged 2 commits intomicrosoft:masterfrom
layershifter merged 2 commits intomicrosoft:masterfrom
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 533fcd3f705bc3161fb85f773fc396455f507d10 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9083c9c:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1335 | 1287 | 5000 | |
| Button | mount | 935 | 940 | 5000 | |
| Field | mount | 2059 | 2037 | 5000 | |
| FluentProvider | mount | 1679 | 1649 | 5000 | |
| FluentProviderWithTheme | mount | 638 | 629 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 603 | 595 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 641 | 635 | 10 | |
| InfoButton | mount | 570 | 571 | 5000 | |
| MakeStyles | mount | 1907 | 1918 | 50000 | |
| Persona | mount | 3101 | 3030 | 5000 | |
| SpinButton | mount | 2453 | 2451 | 5000 |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Member
|
/azp run Fluent UI React - PR and CI |
layershifter
approved these changes
Mar 14, 2023
|
Azure Pipelines successfully started running 1 pipeline(s). |
GeoffCoxMSFT
pushed a commit
to GeoffCoxMSFT/fluentui
that referenced
this pull request
Mar 14, 2023
Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 15, 2023
* master: (141 commits) chore: prerequisite changes before migrating v9 packages to SWC based transpilation (microsoft#26965) feat: Add InfoLabel component (microsoft#27118) fix(tools): update migrate-converged generator to add node field to package.json exports map (microsoft#27152) applying package updates fix: Embed play/pause indicator should render correctly in high contrast mode (microsoft#27213) feat(tokens): Add colorNeutralBackgroundAlpha and colorNeutralStrokeAlpha tokens (microsoft#27034) chore: Prepare release 0.66.4 (microsoft#27163) fix(react-datepicker-compat): Fix text entry issues with input (microsoft#27204) fix: Smooth out animation of indeterminate progress bar (microsoft#27201) Add cxe-red as a codeowner of react-file-type-icons (microsoft#27147) Added documentation about custom style hooks (microsoft#27087) Custom style react-text (microsoft#27078) Custom style react-image (microsoft#27066) Add JSDoc for tabster focus indicator selector (microsoft#27041) Theme designer: Move colors to local files (microsoft#27191) docs(react-card): move card out of preview (microsoft#27185) Include values in typography table (microsoft#27189) feat: accept a className in `mountNode` in `Portal` (microsoft#27008) RFC: Extend `mountNode` prop in `Portal` (microsoft#27009) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Mar 15, 2023
* master: (141 commits) chore: prerequisite changes before migrating v9 packages to SWC based transpilation (microsoft#26965) feat: Add InfoLabel component (microsoft#27118) fix(tools): update migrate-converged generator to add node field to package.json exports map (microsoft#27152) applying package updates fix: Embed play/pause indicator should render correctly in high contrast mode (microsoft#27213) feat(tokens): Add colorNeutralBackgroundAlpha and colorNeutralStrokeAlpha tokens (microsoft#27034) chore: Prepare release 0.66.4 (microsoft#27163) fix(react-datepicker-compat): Fix text entry issues with input (microsoft#27204) fix: Smooth out animation of indeterminate progress bar (microsoft#27201) Add cxe-red as a codeowner of react-file-type-icons (microsoft#27147) Added documentation about custom style hooks (microsoft#27087) Custom style react-text (microsoft#27078) Custom style react-image (microsoft#27066) Add JSDoc for tabster focus indicator selector (microsoft#27041) Theme designer: Move colors to local files (microsoft#27191) docs(react-card): move card out of preview (microsoft#27185) Include values in typography table (microsoft#27189) feat: accept a className in `mountNode` in `Portal` (microsoft#27008) RFC: Extend `mountNode` prop in `Portal` (microsoft#27009) applying package updates ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The current typography table doesn't show the literal font-size values. This makes it difficult to figure out the typography token that best corresponds with literal font sizes (such as "12px") which are often used in Figma designs.
New Behavior
Added column that includes font values, similar to the colors page.
Related Issue(s)
See internal docs that I've shared with @paulgildea