feat(react-tree): implements roving tabIndex navigation#27047

Merged

bsunderhus merged 1 commit intomicrosoft:masterfrom

bsunderhus:react-tree/feat--implements-roving-tab-index-navigation

Mar 9, 2023

Contributor

bsunderhus commented Mar 3, 2023 •

edited

Loading

New Behavior

introduces the notion of roving tab indexes to control currently focused element on the tree and ensure only a single item in the whole tree is focusable by tabindex.

bsunderhus added Fluent UI react-components (v9) Component: Tree labels

bsunderhus self-assigned this

github-actions bot added this to the March Project Cycle Q1 2023 milestone

bsunderhus force-pushed the react-tree/feat--implements-roving-tab-index-navigation branch from a898c1e to cf8bb5f Compare

March 3, 2023 17:16

Collaborator

fabricteam commented Mar 3, 2023 •

edited

Loading

📊 Bundle size report

_{🤖 This report was generated against bec67979083d85abf2d23b71185c9dee61b286e9}

size-auditor bot commented Mar 3, 2023 •

edited

Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bec67979083d85abf2d23b71185c9dee61b286e9 (build)

codesandbox-ci bot commented Mar 3, 2023 •

edited

Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b789a1a:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

bsunderhus commented

View reviewed changes

packages/react-components/react-tree/src/components/Tree/Tree.types.ts Show resolved Hide resolved

bsunderhus marked this pull request as ready for review

March 3, 2023 18:07

bsunderhus requested a review from a team as a code owner

March 3, 2023 18:08

bsunderhus force-pushed the react-tree/feat--implements-roving-tab-index-navigation branch from 911b7f8 to dc1259b Compare

March 7, 2023 13:58

ling1726 reviewed

View reviewed changes

packages/react-components/react-tree/src/hooks/useRovingTabIndexes.ts Outdated Show resolved Hide resolved

ling1726 reviewed

View reviewed changes

packages/react-components/react-tree/src/hooks/useRovingTabIndexes.ts Outdated Show resolved Hide resolved

ling1726 reviewed

View reviewed changes

packages/react-components/react-tree/src/hooks/useRovingTabIndexes.ts Show resolved Hide resolved

ling1726 reviewed

View reviewed changes

packages/react-components/react-tree/src/hooks/useHTMLElementWalker.ts Outdated Show resolved Hide resolved

ling1726 reviewed

View reviewed changes

packages/react-components/react-tree/src/hooks/useHTMLElementWalker.ts Outdated Show resolved Hide resolved

ling1726 reviewed

View reviewed changes

packages/react-components/react-tree/src/hooks/useFlatTree.ts Outdated Show resolved Hide resolved

bsunderhus force-pushed the react-tree/feat--implements-roving-tab-index-navigation branch 2 times, most recently from 36fd6b1 to 0a9c143 Compare

March 8, 2023 16:56

bsunderhus requested a review from ling1726

March 8, 2023 17:07


          feat(react-tree): implements roving tabIndex navigation

b789a1a

bsunderhus force-pushed the react-tree/feat--implements-roving-tab-index-navigation branch from 0a9c143 to b789a1a Compare

March 8, 2023 18:05

ling1726 approved these changes

View reviewed changes

bsunderhus merged commit 737fe1f into microsoft:master

bsunderhus deleted the react-tree/feat--implements-roving-tab-index-navigation branch

March 9, 2023 13:17

bsunderhus mentioned this pull request

Closed

22 tasks

GeoffCoxMSFT pushed a commit to GeoffCoxMSFT/fluentui that referenced this pull request


          feat(react-tree): implements roving tabIndex navigation (microsoft#27047

58136c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Tree Fluent UI react-components (v9)