Skip to content

chore(scripts): remove type declaration duplication within /scripts/monorepo and remove non public API#26139

Merged
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v18
Jan 3, 2023
Merged

chore(scripts): remove type declaration duplication within /scripts/monorepo and remove non public API#26139
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v18

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Jan 3, 2023 •
edited
Loading

Previous Behavior

  • every api definition needs to be manually duplicated within index.d.ts

New Behavior

  • no duplication and need for manual monorepo/ api definition

Related Issue(s)

@github-actions github-actions bot added this to the October Project Cycle Q4 2022 milestone Jan 3, 2023
@size-auditor
Copy link

size-auditor bot commented Jan 3, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 290fb885246f86efa306c9bb65ff17107b390b8b (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 3, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f2c2c7f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 3, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1326 1298 5000
Button mount 929 942 5000
FluentProvider mount 1577 1568 5000
FluentProviderWithTheme mount 633 632 10
FluentProviderWithTheme virtual-rerender 584 588 10
FluentProviderWithTheme virtual-rerender-with-unmount 623 636 10
MakeStyles mount 1898 1881 50000
Persona mount 3035 3000 5000
SpinButton mount 2522 2542 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 3, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 3.153 kB
1.299 kB
react-accordion
Accordion (including children components)		 79.673 kB
24.57 kB
react-alert
Alert		 84.15 kB
21.28 kB
react-avatar
Avatar		 51.083 kB
14.289 kB
react-avatar
AvatarGroup		 15.006 kB
6.009 kB
react-avatar
AvatarGroupItem		 67.313 kB
18.585 kB
react-badge
Badge		 23.357 kB
7.361 kB
react-badge
CounterBadge		 24.247 kB
7.643 kB
react-badge
PresenceBadge		 24.001 kB
7.049 kB
react-button
Button		 32.923 kB
8.61 kB
react-button
CompoundButton		 39.953 kB
9.933 kB
react-button
MenuButton		 37.611 kB
9.942 kB
react-button
SplitButton		 45.057 kB
11.323 kB
react-button
ToggleButton		 48.753 kB
10.715 kB
react-card
Card - All		 77.54 kB
22.326 kB
react-card
Card		 72.484 kB
20.915 kB
react-card
CardFooter		 8.617 kB
3.62 kB
react-card
CardHeader		 10.382 kB
4.258 kB
react-card
CardPreview		 9.424 kB
3.97 kB
react-checkbox
Checkbox		 28.65 kB
9.09 kB
react-checkbox
CheckboxField		 35.067 kB
10.89 kB
react-combobox
Combobox (including child components)		 79.532 kB
25.434 kB
react-combobox
ComboboxField		 76.735 kB
25.396 kB
react-combobox
Dropdown (including child components)		 78.78 kB
25.373 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 59.381 kB
16.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 188.355 kB
52.891 kB
react-components
react-components: FluentProvider & webLightTheme		 33.843 kB
11.129 kB
react-dialog
Dialog (including children components)		 83.035 kB
24.76 kB
react-divider
Divider		 16.515 kB
5.921 kB
react-image
Image		 10.836 kB
4.283 kB
react-infobutton
InfoButton		 119.2 kB
35.738 kB
react-input
Input		 24.194 kB
7.89 kB
react-input
InputField		 33.408 kB
10.584 kB
react-label
Label		 9.394 kB
3.88 kB
react-link
Link		 11.862 kB
4.885 kB
react-menu
Menu (including children components)		 119.068 kB
36.76 kB
react-menu
Menu (including selectable components)		 122.137 kB
37.287 kB
react-overflow
hooks only		 11.004 kB
4.188 kB
react-persona
Persona		 57.12 kB
15.945 kB
react-popover
Popover		 104.936 kB
32.304 kB
react-portal
Portal		 10.697 kB
3.938 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 20.694 kB
7.691 kB
react-progress
ProgressBar		 13.155 kB
5.048 kB
react-progress
ProgressField		 22.461 kB
7.919 kB
react-provider
FluentProvider		 15.91 kB
5.931 kB
react-radio
Radio		 31.827 kB
10.316 kB
react-radio
RadioGroup		 14.304 kB
5.72 kB
react-radio
RadioGroupField		 23.604 kB
8.65 kB
react-select
Select		 23.474 kB
8.017 kB
react-select
SelectField		 31.731 kB
10.256 kB
react-slider
Slider		 32.091 kB
10.183 kB
react-slider
SliderField		 41.113 kB
12.903 kB
react-spinbutton
SpinButton		 44.502 kB
12.812 kB
react-spinbutton
SpinButtonField		 52.784 kB
15.085 kB
react-spinner
Spinner		 20.013 kB
6.446 kB
react-switch
Switch		 33.427 kB
10.581 kB
react-switch
SwitchField		 39.745 kB
12.362 kB
react-text
Text - Default		 11.838 kB
4.625 kB
react-text
Text - Wrappers		 15.148 kB
5.06 kB
react-textarea
Textarea		 25.733 kB
8.328 kB
react-textarea
TextareaField		 34.949 kB
11.012 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 30.908 kB
6.714 kB
react-theme
Teams: Light theme		 17.776 kB
5.141 kB
react-tooltip
Tooltip		 42.969 kB
15.016 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 290fb885246f86efa306c9bb65ff17107b390b8b

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 3, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 3, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 3, 2023

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 3, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1188 1196 5000
Breadcrumb mount 2809 2824 1000
Checkbox mount 2643 2649 5000
CheckboxBase mount 2351 2396 5000
ChoiceGroup mount 4285 4290 5000
ComboBox mount 1182 1201 1000
CommandBar mount 9308 9296 1000
ContextualMenu mount 10127 10337 1000
DefaultButton mount 1363 1344 5000
DetailsRow mount 3356 3350 5000
DetailsRowFast mount 3343 3297 5000
DetailsRowNoStyles mount 3257 3217 5000
Dialog mount 2970 2931 1000
DocumentCardTitle mount 567 576 1000
Dropdown mount 3162 3171 5000
FocusTrapZone mount 1939 1937 5000
FocusZone mount 1917 1935 5000
GroupedList mount 1860 2035 2
GroupedList virtual-rerender 1086 1089 2
GroupedList virtual-rerender-with-unmount 1604 1608 2
GroupedListV2 mount 568 573 2
GroupedListV2 virtual-rerender 556 542 2
GroupedListV2 virtual-rerender-with-unmount 571 563 2
IconButton mount 1799 1761 5000
Label mount 762 756 5000
Layer mount 4200 4210 5000
Link mount 843 862 5000
MenuButton mount 1625 1628 5000
MessageBar mount 2346 2350 5000
Nav mount 3047 3050 1000
OverflowSet mount 1420 1419 5000
Panel mount 2467 2499 1000
Persona mount 1292 1303 1000
Pivot mount 1513 1516 1000
PrimaryButton mount 1502 1483 5000
Rating mount 6907 6971 5000
SearchBox mount 1489 1501 5000
Shimmer mount 2872 2892 5000
Slider mount 2139 2096 5000
SpinButton mount 4227 4250 5000
Spinner mount 833 841 5000
SplitButton mount 2829 2823 5000
Stack mount 874 872 5000
StackWithIntrinsicChildren mount 2282 2245 5000
StackWithTextChildren mount 4964 4975 5000
SwatchColorPicker mount 9423 9447 5000
TagPicker mount 2360 2363 5000
TeachingBubble mount 74708 75186 5000
Text mount 825 818 5000
TextField mount 1579 1563 5000
ThemeProvider mount 1432 1438 5000
ThemeProvider virtual-rerender 1139 1142 5000
ThemeProvider virtual-rerender-with-unmount 2010 2000 5000
Toggle mount 1146 1135 5000
buttonNative mount 538 529 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 3, 2023 •
edited
Loading

🕵 FluentUI-v0 No visual regressions between this PR and main

@Hotell Hotell force-pushed the hotell/build/scripts/ts-solution-config-v18 branch 2 times, most recently from bfc42b0 to 036e275 Compare January 3, 2023 11:38
@Hotell Hotell force-pushed the hotell/build/scripts/ts-solution-config-v18 branch from 036e275 to f2c2c7f Compare January 3, 2023 11:53
@Hotell Hotell marked this pull request as ready for review January 3, 2023 12:46
@Hotell Hotell requested a review from a team as a code owner January 3, 2023 12:46
@Hotell Hotell merged commit 811e285 into microsoft:master Jan 3, 2023
@Hotell Hotell deleted the hotell/build/scripts/ts-solution-config-v18 branch January 3, 2023 16:40
@Hotell Hotell mentioned this pull request Jan 3, 2023
Closed
18 tasks
q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023
@Hotell @q1b
chore(scripts): remove type declaration duplication within /scripts/m…
03e59cc 
…onorepo and remove non public API (microsoft#26139)
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
@Hotell
chore(scripts): remove type declaration duplication within /scripts/m…
11ff679 
…onorepo and remove non public API (microsoft#26139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Build System

Projects

None yet

Milestone

October Project Cycle Q4 2022

Development

Successfully merging this pull request may close these issues.

5 participants

@Hotell @fabricteam @ling1726 @smhigley @msft-fluent-ui-bot