chore (tools): cleanup TODO items in migrate-converged-pkg generator by TristanWatanabe · Pull Request #26112 · microsoft/fluentui

TristanWatanabe · 2022-12-27T18:21:16Z

Changes:

Addresses TODO items in migrate-converged-pkg workspace generator and removes functions no longer needed with v9 package migrations complete.
Addresses miscellaneous TODO items in other files.

Related Issue(s)

Part of Defined standard for v9 package file organization #24129

TristanWatanabe · 2022-12-27T18:23:52Z

scripts/storybook/utils.js

      const storiesGlob = '**/@(index.stories.@(ts|tsx)|*.stories.mdx)';
      const pkgMetadata = getProjectMetadata({ name: pkgName });

-      //TODO: simplify once v9 migration [https://github.com/microsoft/fluentui/issues/24129] is complete.


Starting storybook will error out since certain v9 packages don't have stories and thus don't have a stories/ subfolder. This means that this will now require a default fallback if a stories subfolder doesn't exist so will be keeping the conditions and removing the TODO comment

sounds good, ty

size-auditor · 2022-12-27T18:32:58Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 20221afa1c8dde9afe17a278ddcc0a8a9a4817e2 (build)

codesandbox-ci · 2022-12-27T18:36:53Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b2ee23:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-12-27T18:39:03Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1330	1295	5000
Button	mount	940	935	5000
FluentProvider	mount	1582	1573	5000
FluentProviderWithTheme	mount	629	623	10
FluentProviderWithTheme	virtual-rerender	600	589	10
FluentProviderWithTheme	virtual-rerender-with-unmount	623	626	10
MakeStyles	mount	1895	1910	50000
Persona	mount	3010	2942	5000
SpinButton	mount	2456	2490	5000

fabricteam · 2022-12-27T18:41:08Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.673 kB` `24.57 kB`
`react-alert` Alert	`84.15 kB` `21.28 kB`
`react-avatar` Avatar	`51.083 kB` `14.289 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.313 kB` `18.585 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`77.54 kB` `22.326 kB`
`react-card` Card	`72.484 kB` `20.915 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`10.382 kB` `4.258 kB`
`react-card` CardPreview	`9.424 kB` `3.97 kB`
`react-checkbox` Checkbox	`28.65 kB` `9.09 kB`
`react-checkbox` CheckboxField	`35.067 kB` `10.89 kB`
`react-combobox` Combobox (including child components)	`78.713 kB` `25.211 kB`
`react-combobox` ComboboxField	`75.916 kB` `25.158 kB`
`react-combobox` Dropdown (including child components)	`77.961 kB` `25.154 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.381 kB` `16.465 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`187.536 kB` `52.644 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.843 kB` `11.129 kB`
`react-dialog` Dialog (including children components)	`83.035 kB` `24.76 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`118.381 kB` `35.495 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-input` InputField	`33.408 kB` `10.584 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`118.257 kB` `36.535 kB`
`react-menu` Menu (including selectable components)	`121.326 kB` `37.065 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.12 kB` `15.945 kB`
`react-popover` Popover	`104.125 kB` `32.068 kB`
`react-portal` Portal	`10.697 kB` `3.938 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.883 kB` `7.439 kB`
`react-progress` ProgressBar	`13.155 kB` `5.048 kB`
`react-progress` ProgressField	`22.461 kB` `7.919 kB`
`react-provider` FluentProvider	`15.91 kB` `5.931 kB`
`react-radio` Radio	`31.827 kB` `10.316 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-radio` RadioGroupField	`23.604 kB` `8.65 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-select` SelectField	`31.731 kB` `10.256 kB`
`react-slider` Slider	`32.091 kB` `10.183 kB`
`react-slider` SliderField	`41.113 kB` `12.903 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinbutton` SpinButtonField	`52.784 kB` `15.085 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.427 kB` `10.581 kB`
`react-switch` SwitchField	`39.745 kB` `12.362 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-textarea` TextareaField	`34.949 kB` `11.012 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`42.158 kB` `14.796 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 20221afa1c8dde9afe17a278ddcc0a8a9a4817e2}

fabricteam · 2022-12-27T18:41:21Z

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 2 screenshots removed, 1043 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 2 screenshots

Image Name	Diff(in Pixels)	Image Type
Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png	0	Removed
Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png	0	Removed

fabricteam · 2022-12-27T18:42:06Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-12-27T18:44:41Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2022-12-27T18:49:06Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1185	1209	5000
Breadcrumb	mount	2857	2865	1000
Checkbox	mount	2635	2648	5000
CheckboxBase	mount	2377	2389	5000
ChoiceGroup	mount	4330	4326	5000
ComboBox	mount	1182	1170	1000
CommandBar	mount	9364	9419	1000
ContextualMenu	mount	10388	10306	1000
DefaultButton	mount	1356	1372	5000
DetailsRow	mount	3413	3384	5000
DetailsRowFast	mount	3384	3401	5000
DetailsRowNoStyles	mount	3232	3262	5000
Dialog	mount	2958	2967	1000
DocumentCardTitle	mount	572	576	1000
Dropdown	mount	3163	3156	5000
FocusTrapZone	mount	1963	1980	5000
FocusZone	mount	1935	1937	5000
GroupedList	mount	1840	2053	2
GroupedList	virtual-rerender	1104	1117	2
GroupedList	virtual-rerender-with-unmount	1594	1616	2
GroupedListV2	mount	568	583	2
GroupedListV2	virtual-rerender	548	544	2
GroupedListV2	virtual-rerender-with-unmount	558	568	2
IconButton	mount	1788	1912	5000
Label	mount	742	745	5000
Layer	mount	4160	4172	5000
Link	mount	859	869	5000
MenuButton	mount	1611	1616	5000
MessageBar	mount	2349	2401	5000
Nav	mount	3102	3093	1000
OverflowSet	mount	1412	1424	5000
Panel	mount	2501	2528	1000
Persona	mount	1286	1281	1000
Pivot	mount	1499	1518	1000
PrimaryButton	mount	1487	1499	5000
Rating	mount	7008	7015	5000
SearchBox	mount	1512	1502	5000
Shimmer	mount	2935	2935	5000
Slider	mount	2120	2122	5000
SpinButton	mount	4328	4263	5000
Spinner	mount	827	836	5000
SplitButton	mount	2839	2821	5000
Stack	mount	864	859	5000
StackWithIntrinsicChildren	mount	2274	2260	5000
StackWithTextChildren	mount	4986	4979	5000
SwatchColorPicker	mount	9445	9550	5000
TagPicker	mount	2332	2322	5000
TeachingBubble	mount	76930	79331	5000
Text	mount	839	820	5000
TextField	mount	1553	1539	5000
ThemeProvider	mount	1454	1456	5000
ThemeProvider	virtual-rerender	1144	1153	5000
ThemeProvider	virtual-rerender-with-unmount	1991	2002	5000
Toggle	mount	1135	1153	5000
buttonNative	mount	538	534	5000

fabricteam · 2022-12-27T18:52:27Z

🕵 FluentUI-v0 No visual regressions between this PR and main

…icrosoft#26112)

TristanWatanabe added 4 commits December 23, 2022 19:18

chore: address TODO items

7bdadc5

chore: chore: remove temp functions from migrate-converged-pkg generator

f4edf41

chore: remove unneedfed tests

546aa0f

chore: remove moveDocsToSubfolder

8b2ee23

TristanWatanabe self-assigned this Dec 27, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Dec 27, 2022

TristanWatanabe commented Dec 27, 2022

View reviewed changes

TristanWatanabe mentioned this pull request Dec 27, 2022

Defined standard for v9 package file organization #24129

Closed

59 tasks

TristanWatanabe marked this pull request as ready for review December 27, 2022 20:41

TristanWatanabe requested a review from a team as a code owner December 27, 2022 20:41

ling1726 approved these changes Dec 28, 2022

View reviewed changes

Hotell approved these changes Dec 28, 2022

View reviewed changes

TristanWatanabe merged commit 598fc76 into microsoft:master Dec 28, 2022

TristanWatanabe deleted the pkg-migration-cleanups branch December 28, 2022 19:18

q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023

chore (tools): cleanup TODO items in migrate-converged-pkg generator (m…

3744998

…icrosoft#26112)

Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore (tools): cleanup TODO items in migrate-converged-pkg generator (m…

8dbf080

…icrosoft#26112)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore (tools): cleanup TODO items in migrate-converged-pkg generator#26112

chore (tools): cleanup TODO items in migrate-converged-pkg generator#26112
TristanWatanabe merged 4 commits intomicrosoft:masterfrom
TristanWatanabe:pkg-migration-cleanups

TristanWatanabe commented Dec 27, 2022

Uh oh!

TristanWatanabe Dec 27, 2022

Uh oh!

Hotell Dec 28, 2022

Uh oh!

size-auditor bot commented Dec 27, 2022

Uh oh!

codesandbox-ci bot commented Dec 27, 2022

Uh oh!

fabricteam commented Dec 27, 2022

Uh oh!

fabricteam commented Dec 27, 2022

Uh oh!

fabricteam commented Dec 27, 2022

Uh oh!

fabricteam commented Dec 27, 2022

Uh oh!

fabricteam commented Dec 27, 2022

Uh oh!

fabricteam commented Dec 27, 2022

Uh oh!

fabricteam commented Dec 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

TristanWatanabe commented Dec 27, 2022

Changes:

Related Issue(s)

Uh oh!

TristanWatanabe Dec 27, 2022

Choose a reason for hiding this comment

Uh oh!

Hotell Dec 28, 2022

Choose a reason for hiding this comment

Uh oh!

size-auditor bot commented Dec 27, 2022

Asset size changes

Uh oh!

codesandbox-ci bot commented Dec 27, 2022

Uh oh!

fabricteam commented Dec 27, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Dec 27, 2022

📊 Bundle size report

Uh oh!

fabricteam commented Dec 27, 2022

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

Uh oh!

fabricteam commented Dec 27, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Dec 27, 2022

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 27, 2022

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Dec 27, 2022

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)