Skip to content

chore(scripts): introduce ts-node sub-package#26109

Merged
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v13
Dec 28, 2022
Merged

chore(scripts): introduce ts-node sub-package#26109
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v13

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Dec 27, 2022 •
edited
Loading

New Behavior

ts-node register is moved under sub-package folder

Related Issue(s)

@size-auditor
Copy link

size-auditor bot commented Dec 27, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 20221afa1c8dde9afe17a278ddcc0a8a9a4817e2 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1545 1543 5000
Button mount 1120 1108 5000
FluentProvider mount 1922 1919 5000
FluentProviderWithTheme mount 754 746 10
FluentProviderWithTheme virtual-rerender 708 716 10
FluentProviderWithTheme virtual-rerender-with-unmount 751 761 10
MakeStyles mount 2279 2277 50000
Persona mount 3634 3572 5000
SpinButton mount 3001 2988 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 3.153 kB
1.299 kB
react-accordion
Accordion (including children components)		 79.673 kB
24.57 kB
react-alert
Alert		 84.15 kB
21.28 kB
react-avatar
Avatar		 51.083 kB
14.289 kB
react-avatar
AvatarGroup		 15.006 kB
6.009 kB
react-avatar
AvatarGroupItem		 67.313 kB
18.585 kB
react-badge
Badge		 23.357 kB
7.361 kB
react-badge
CounterBadge		 24.247 kB
7.643 kB
react-badge
PresenceBadge		 24.001 kB
7.049 kB
react-button
Button		 32.923 kB
8.61 kB
react-button
CompoundButton		 39.953 kB
9.933 kB
react-button
MenuButton		 37.611 kB
9.942 kB
react-button
SplitButton		 45.057 kB
11.323 kB
react-button
ToggleButton		 48.753 kB
10.715 kB
react-card
Card - All		 77.54 kB
22.326 kB
react-card
Card		 72.484 kB
20.915 kB
react-card
CardFooter		 8.617 kB
3.62 kB
react-card
CardHeader		 10.382 kB
4.258 kB
react-card
CardPreview		 9.424 kB
3.97 kB
react-checkbox
Checkbox		 28.65 kB
9.09 kB
react-checkbox
CheckboxField		 35.067 kB
10.89 kB
react-combobox
Combobox (including child components)		 78.713 kB
25.211 kB
react-combobox
ComboboxField		 75.916 kB
25.158 kB
react-combobox
Dropdown (including child components)		 77.961 kB
25.154 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 59.381 kB
16.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 187.536 kB
52.644 kB
react-components
react-components: FluentProvider & webLightTheme		 33.843 kB
11.129 kB
react-dialog
Dialog (including children components)		 83.035 kB
24.76 kB
react-divider
Divider		 16.515 kB
5.921 kB
react-image
Image		 10.836 kB
4.283 kB
react-infobutton
InfoButton		 118.381 kB
35.495 kB
react-input
Input		 24.194 kB
7.89 kB
react-input
InputField		 33.408 kB
10.584 kB
react-label
Label		 9.394 kB
3.88 kB
react-link
Link		 11.862 kB
4.885 kB
react-menu
Menu (including children components)		 118.257 kB
36.535 kB
react-menu
Menu (including selectable components)		 121.326 kB
37.065 kB
react-overflow
hooks only		 11.004 kB
4.188 kB
react-persona
Persona		 57.12 kB
15.945 kB
react-popover
Popover		 104.125 kB
32.068 kB
react-portal
Portal		 10.697 kB
3.938 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.883 kB
7.439 kB
react-progress
ProgressBar		 13.155 kB
5.048 kB
react-progress
ProgressField		 22.461 kB
7.919 kB
react-provider
FluentProvider		 15.91 kB
5.931 kB
react-radio
Radio		 31.827 kB
10.316 kB
react-radio
RadioGroup		 14.304 kB
5.72 kB
react-radio
RadioGroupField		 23.604 kB
8.65 kB
react-select
Select		 23.474 kB
8.017 kB
react-select
SelectField		 31.731 kB
10.256 kB
react-slider
Slider		 32.091 kB
10.183 kB
react-slider
SliderField		 41.113 kB
12.903 kB
react-spinbutton
SpinButton		 44.502 kB
12.812 kB
react-spinbutton
SpinButtonField		 52.784 kB
15.085 kB
react-spinner
Spinner		 20.013 kB
6.446 kB
react-switch
Switch		 33.427 kB
10.581 kB
react-switch
SwitchField		 39.745 kB
12.362 kB
react-text
Text - Default		 11.838 kB
4.625 kB
react-text
Text - Wrappers		 15.148 kB
5.06 kB
react-textarea
Textarea		 25.733 kB
8.328 kB
react-textarea
TextareaField		 34.949 kB
11.012 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 30.908 kB
6.714 kB
react-theme
Teams: Light theme		 17.776 kB
5.141 kB
react-tooltip
Tooltip		 42.158 kB
14.796 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 20221afa1c8dde9afe17a278ddcc0a8a9a4817e2

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1403 1413 5000
Breadcrumb mount 3401 3457 1000
Checkbox mount 3074 3048 5000
CheckboxBase mount 2743 2762 5000
ChoiceGroup mount 5188 5253 5000
ComboBox mount 1442 1440 1000
CommandBar mount 11151 11240 1000
ContextualMenu mount 12666 12655 1000
DefaultButton mount 1601 1633 5000
DetailsRow mount 4256 4198 5000
DetailsRowFast mount 4280 4205 5000
DetailsRowNoStyles mount 4064 3994 5000
Dialog mount 3661 3581 1000
DocumentCardTitle mount 678 662 1000
Dropdown mount 3751 3751 5000
FocusTrapZone mount 2371 2356 5000
FocusZone mount 2280 2313 5000
GroupedList mount 2190 2493 2
GroupedList virtual-rerender 1325 1313 2
GroupedList virtual-rerender-with-unmount 1951 1972 2
GroupedListV2 mount 671 670 2
GroupedListV2 virtual-rerender 637 634 2
GroupedListV2 virtual-rerender-with-unmount 672 685 2
IconButton mount 2215 2250 5000
Label mount 855 843 5000
Layer mount 4966 5042 5000
Link mount 984 959 5000
MenuButton mount 1955 2001 5000
MessageBar mount 2739 2708 5000
Nav mount 3771 3807 1000
OverflowSet mount 1605 1618 5000
Panel mount 2987 2985 1000
Persona mount 1580 1564 1000
Pivot mount 1875 1935 1000
PrimaryButton mount 1823 1781 5000
Rating mount 8249 8148 5000
SearchBox mount 1781 1789 5000
Shimmer mount 3317 3336 5000
Slider mount 2482 2471 5000
SpinButton mount 5446 5402 5000
Spinner mount 940 911 5000
SplitButton mount 3685 3640 5000
Stack mount 1010 980 5000
StackWithIntrinsicChildren mount 2743 2705 5000
StackWithTextChildren mount 5650 5571 5000
SwatchColorPicker mount 12075 12298 5000
TagPicker mount 3064 3024 5000
TeachingBubble mount 97963 98231 5000
Text mount 921 939 5000
TextField mount 1852 1884 5000
ThemeProvider mount 1821 1770 5000
ThemeProvider virtual-rerender 1264 1285 5000
ThemeProvider virtual-rerender-with-unmount 2525 2531 5000
Toggle mount 1306 1273 5000
buttonNative mount 649 633 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c288aa4:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022

🕵 FluentUI-v0 No visual regressions between this PR and main

@Hotell Hotell marked this pull request as ready for review December 27, 2022 19:51
@Hotell Hotell requested review from a team as code owners December 27, 2022 19:51
@Hotell Hotell merged commit f02e92f into microsoft:master Dec 28, 2022
@Hotell Hotell deleted the hotell/build/scripts/ts-solution-config-v13 branch December 28, 2022 10:12
@Hotell Hotell mentioned this pull request Dec 28, 2022
Closed
18 tasks
layershifter
layershifter reviewed Jan 3, 2023
View reviewed changes
scripts/ts-node/register.js
Comment on lines 4 to 6
// https://github.com/TypeStrong/ts-node#skipproject - don't read tsconfig within ts-node
skipProject: true,
swc: true,
Copy link
Member

@layershifter layershifter Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we can remove this completely and just use config in tsconfig.json (https://typestrong.org/ts-node/docs/swc/). Or this will be too implicit?

q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023
@Hotell @q1b
chore(scripts): introduce ts-node sub-package (microsoft#26109)
f33d9f5 
* chore(scripts): introduce ts-node sub-package

* generate change-files
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
@Hotell
chore(scripts): introduce ts-node sub-package (microsoft#26109)
2cc265f 
* chore(scripts): introduce ts-node sub-package

* generate change-files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter left review comments

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Build System

Projects

None yet

Milestone

October Project Cycle Q4 2022

Development

Successfully merging this pull request may close these issues.

5 participants

@Hotell @fabricteam @layershifter @ling1726 @smhigley