Skip to content

refactor(scripts): introduce barrel api within /jest#26100

Merged
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v10
Dec 29, 2022
Merged

refactor(scripts): introduce barrel api within /jest#26100
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v10

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Dec 23, 2022 •
edited
Loading

Previous Behavior

  • /scripts/jest contains both v8 and v0 that is used via deep imports across packages

New Behavior

  • /scripts/jest contains encapsulate v8 and v0 that is used via barrel API
  • api surface has been also reduced and configs simplified

Related Issue(s)

@Hotell Hotell changed the title refactor(scripts): separate introduce barrel api within /jest refactor(scripts): separate introduce barrel api within /jest Dec 23, 2022
@Hotell Hotell mentioned this pull request Dec 23, 2022
Closed
18 tasks
@DustyTheBot
Copy link

DustyTheBot commented Dec 23, 2022 •
edited
Loading

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 7c2e1c8

@Hotell Hotell force-pushed the hotell/build/scripts/ts-solution-config-v10 branch from 448f8f4 to 7abcfaf Compare December 23, 2022 15:52
@fabricteam
Copy link
Collaborator

fabricteam commented Dec 23, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 3.153 kB
1.299 kB
react-accordion
Accordion (including children components)		 79.673 kB
24.57 kB
react-alert
Alert		 84.15 kB
21.28 kB
react-avatar
Avatar		 51.083 kB
14.289 kB
react-avatar
AvatarGroup		 15.006 kB
6.009 kB
react-avatar
AvatarGroupItem		 67.313 kB
18.585 kB
react-badge
Badge		 23.357 kB
7.361 kB
react-badge
CounterBadge		 24.247 kB
7.643 kB
react-badge
PresenceBadge		 24.001 kB
7.049 kB
react-button
Button		 32.923 kB
8.61 kB
react-button
CompoundButton		 39.953 kB
9.933 kB
react-button
MenuButton		 37.611 kB
9.942 kB
react-button
SplitButton		 45.057 kB
11.323 kB
react-button
ToggleButton		 48.753 kB
10.715 kB
react-card
Card - All		 77.54 kB
22.326 kB
react-card
Card		 72.484 kB
20.915 kB
react-card
CardFooter		 8.617 kB
3.62 kB
react-card
CardHeader		 10.382 kB
4.258 kB
react-card
CardPreview		 9.424 kB
3.97 kB
react-checkbox
Checkbox		 28.65 kB
9.09 kB
react-checkbox
CheckboxField		 35.067 kB
10.89 kB
react-combobox
Combobox (including child components)		 78.713 kB
25.211 kB
react-combobox
ComboboxField		 75.916 kB
25.158 kB
react-combobox
Dropdown (including child components)		 77.961 kB
25.154 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 59.381 kB
16.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 187.536 kB
52.644 kB
react-components
react-components: FluentProvider & webLightTheme		 33.843 kB
11.129 kB
react-dialog
Dialog (including children components)		 83.035 kB
24.76 kB
react-divider
Divider		 16.515 kB
5.921 kB
react-image
Image		 10.836 kB
4.283 kB
react-infobutton
InfoButton		 118.381 kB
35.495 kB
react-input
Input		 24.194 kB
7.89 kB
react-input
InputField		 33.408 kB
10.584 kB
react-label
Label		 9.394 kB
3.88 kB
react-link
Link		 11.862 kB
4.885 kB
react-menu
Menu (including children components)		 118.257 kB
36.535 kB
react-menu
Menu (including selectable components)		 121.326 kB
37.065 kB
react-overflow
hooks only		 11.004 kB
4.188 kB
react-persona
Persona		 57.12 kB
15.945 kB
react-popover
Popover		 104.125 kB
32.068 kB
react-portal
Portal		 10.697 kB
3.938 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.883 kB
7.439 kB
react-progress
ProgressBar		 13.155 kB
5.048 kB
react-progress
ProgressField		 22.461 kB
7.919 kB
react-provider
FluentProvider		 15.91 kB
5.931 kB
react-radio
Radio		 31.827 kB
10.316 kB
react-radio
RadioGroup		 14.304 kB
5.72 kB
react-radio
RadioGroupField		 23.604 kB
8.65 kB
react-select
Select		 23.474 kB
8.017 kB
react-select
SelectField		 31.731 kB
10.256 kB
react-slider
Slider		 32.091 kB
10.183 kB
react-slider
SliderField		 41.113 kB
12.903 kB
react-spinbutton
SpinButton		 44.502 kB
12.812 kB
react-spinbutton
SpinButtonField		 52.784 kB
15.085 kB
react-spinner
Spinner		 20.013 kB
6.446 kB
react-switch
Switch		 33.427 kB
10.581 kB
react-switch
SwitchField		 39.745 kB
12.362 kB
react-text
Text - Default		 11.838 kB
4.625 kB
react-text
Text - Wrappers		 15.148 kB
5.06 kB
react-textarea
Textarea		 25.733 kB
8.328 kB
react-textarea
TextareaField		 34.949 kB
11.012 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 30.908 kB
6.714 kB
react-theme
Teams: Light theme		 17.776 kB
5.141 kB
react-tooltip
Tooltip		 42.158 kB
14.796 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 714a5f0e9744575fb265f561f7174ca949171b1f

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 23, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1267 1282 5000
Button mount 920 910 5000
FluentProvider mount 1506 1513 5000
FluentProviderWithTheme mount 584 590 10
FluentProviderWithTheme virtual-rerender 544 548 10
FluentProviderWithTheme virtual-rerender-with-unmount 579 582 10
MakeStyles mount 1983 1950 50000
Persona mount 2820 2796 5000
SpinButton mount 2331 2377 5000

@size-auditor
Copy link

size-auditor bot commented Dec 23, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 714a5f0e9744575fb265f561f7174ca949171b1f (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 23, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c2e1c8:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 23, 2022

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 23, 2022 •
edited
Loading

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 2 screenshots added, 0 screenshots removed, 1043 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png 0 Added
Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png 0 Added

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 23, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1258 1190 5000
Breadcrumb mount 2949 2888 1000
Checkbox mount 2645 2646 5000
CheckboxBase mount 2382 2386 5000
ChoiceGroup mount 4283 4285 5000
ComboBox mount 1198 1177 1000
CommandBar mount 9553 9585 1000
ContextualMenu mount 11375 11407 1000
DefaultButton mount 1382 1376 5000
DetailsRow mount 3376 3383 5000
DetailsRowFast mount 3333 3375 5000
DetailsRowNoStyles mount 3297 3252 5000
Dialog mount 2954 2944 1000
DocumentCardTitle mount 588 590 1000
Dropdown mount 3160 3195 5000
FocusTrapZone mount 1997 1961 5000
FocusZone mount 1960 1974 5000
GroupedList mount 1837 2102 2
GroupedList virtual-rerender 1130 1140 2
GroupedList virtual-rerender-with-unmount 1624 1645 2
GroupedListV2 mount 568 594 2
GroupedListV2 virtual-rerender 549 555 2
GroupedListV2 virtual-rerender-with-unmount 567 566 2
IconButton mount 1792 1838 5000
Label mount 764 772 5000
Layer mount 4212 4211 5000
Link mount 859 872 5000
MenuButton mount 1595 1593 5000
MessageBar mount 2391 2323 5000
Nav mount 3066 3070 1000
OverflowSet mount 1406 1409 5000
Panel mount 2503 2555 1000
Persona mount 1314 1300 1000
Pivot mount 1531 1529 1000
PrimaryButton mount 1480 1471 5000
Rating mount 6948 7052 5000
SearchBox mount 1504 1514 5000
Shimmer mount 2903 2910 5000
Slider mount 2098 2142 5000
SpinButton mount 4314 4252 5000
Spinner mount 867 841 5000
SplitButton mount 2861 2822 5000
Stack mount 876 863 5000
StackWithIntrinsicChildren mount 2243 2257 5000
StackWithTextChildren mount 4951 4940 5000
SwatchColorPicker mount 9570 9520 5000
TagPicker mount 2317 2326 5000
TeachingBubble mount 85110 86257 5000
Text mount 828 827 5000
TextField mount 1536 1562 5000
ThemeProvider mount 1458 1448 5000
ThemeProvider virtual-rerender 1141 1154 5000
ThemeProvider virtual-rerender-with-unmount 2021 2002 5000
Toggle mount 1144 1166 5000
buttonNative mount 539 544 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 23, 2022 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 23, 2022 •
edited
Loading

🕵 FluentUI-v0 No visual regressions between this PR and main

@Hotell Hotell changed the title refactor(scripts): separate introduce barrel api within /jest refactor(scripts): introduce barrel api within /jest Dec 27, 2022
@Hotell Hotell force-pushed the hotell/build/scripts/ts-solution-config-v10 branch from 7abcfaf to 148cc5f Compare December 27, 2022 11:00
@Hotell Hotell force-pushed the hotell/build/scripts/ts-solution-config-v10 branch from 148cc5f to 7c2e1c8 Compare December 27, 2022 13:03
@Hotell Hotell marked this pull request as ready for review December 27, 2022 13:52
@Hotell Hotell requested review from a team as code owners December 27, 2022 13:52
AtishayMsft
AtishayMsft approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@AtishayMsft AtishayMsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Charting team

@Hotell Hotell mentioned this pull request Dec 27, 2022
Merged
@Hotell Hotell merged commit f0e7c52 into microsoft:master Dec 29, 2022
@Hotell Hotell deleted the hotell/build/scripts/ts-solution-config-v10 branch December 29, 2022 13:41
q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023
@Hotell @q1b
refactor(scripts): separate introduce barrel api within /jest (micros…
07e90f5 
…oft#26100)
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
@Hotell
refactor(scripts): separate introduce barrel api within /jest (micros…
4d10c8a 
…oft#26100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@AtishayMsft AtishayMsft AtishayMsft approved these changes

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@khmakoto khmakoto Awaiting requested review from khmakoto

@dzearing dzearing Awaiting requested review from dzearing

@Jahnp Jahnp Awaiting requested review from Jahnp

@bigbadcapers bigbadcapers Awaiting requested review from bigbadcapers

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Build System

Projects

None yet

Milestone

October Project Cycle Q4 2022

Development

Successfully merging this pull request may close these issues.

7 participants

@Hotell @DustyTheBot @fabricteam @TristanWatanabe @ling1726 @AtishayMsft @bsunderhus