chore(scripts): remove deep imports from /scripts/tasks/* by Hotell · Pull Request #26099 · microsoft/fluentui

Hotell · 2022-12-23T13:53:50Z

Previous Behavior

packages use deep imports to scripts/tasks

New Behavior

packages dont use deep imports from scripts/tasks

Related Issue(s)

Fixes partially feat: make backbone of our tooling compliant with package standards (packaging /scripts) #24349

size-auditor · 2022-12-23T14:05:26Z

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 613f784

Possible causes

The baseline build 613f784 is broken
The Size Auditor run for the baseline build 613f784 was not triggered

Recommendations

Please merge your branch for this Pull request with the latest master build and commit your changes once again

fabricteam · 2022-12-23T14:09:36Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1549	1555	5000
Button	mount	1185	1131	5000
FluentProvider	mount	1867	1934	5000
FluentProviderWithTheme	mount	755	754	10
FluentProviderWithTheme	virtual-rerender	693	700	10
FluentProviderWithTheme	virtual-rerender-with-unmount	743	761	10
MakeStyles	mount	2243	2251	50000
Persona	mount	3552	3556	5000
SpinButton	mount	2944	2940	5000

codesandbox-ci · 2022-12-23T14:10:05Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c4d1034:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-12-23T14:13:29Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.673 kB` `24.57 kB`
`react-alert` Alert	`84.15 kB` `21.28 kB`
`react-avatar` Avatar	`51.083 kB` `14.289 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.313 kB` `18.585 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`77.54 kB` `22.326 kB`
`react-card` Card	`72.484 kB` `20.915 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`10.382 kB` `4.258 kB`
`react-card` CardPreview	`9.424 kB` `3.97 kB`
`react-checkbox` Checkbox	`28.65 kB` `9.09 kB`
`react-checkbox` CheckboxField	`35.067 kB` `10.89 kB`
`react-combobox` Combobox (including child components)	`78.713 kB` `25.211 kB`
`react-combobox` ComboboxField	`75.916 kB` `25.158 kB`
`react-combobox` Dropdown (including child components)	`77.961 kB` `25.154 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.381 kB` `16.465 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`187.536 kB` `52.644 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.843 kB` `11.129 kB`
`react-dialog` Dialog (including children components)	`83.035 kB` `24.76 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`118.381 kB` `35.495 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-input` InputField	`33.408 kB` `10.584 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`118.257 kB` `36.535 kB`
`react-menu` Menu (including selectable components)	`121.326 kB` `37.065 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.12 kB` `15.945 kB`
`react-popover` Popover	`104.125 kB` `32.068 kB`
`react-portal` Portal	`10.697 kB` `3.938 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.883 kB` `7.439 kB`
`react-progress` ProgressBar	`13.155 kB` `5.048 kB`
`react-progress` ProgressField	`22.461 kB` `7.919 kB`
`react-provider` FluentProvider	`15.91 kB` `5.931 kB`
`react-radio` Radio	`31.827 kB` `10.316 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-radio` RadioGroupField	`23.604 kB` `8.65 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-select` SelectField	`31.731 kB` `10.256 kB`
`react-slider` Slider	`32.091 kB` `10.183 kB`
`react-slider` SliderField	`41.113 kB` `12.903 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinbutton` SpinButtonField	`52.784 kB` `15.085 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.427 kB` `10.581 kB`
`react-switch` SwitchField	`39.745 kB` `12.362 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-textarea` TextareaField	`34.949 kB` `11.012 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`42.158 kB` `14.796 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 613f784ec4ef8055efdebcf1ff31540ad9b8eadd}

fabricteam · 2022-12-23T14:14:40Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2022-12-23T14:18:37Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-12-23T14:20:33Z

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 4 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1756 screenshots unchanged, 0 screenshots with different dimensions and 4 screenshots with visible difference.

unknown 4 screenshots

Image Name	Diff(in Pixels)	Image Type
Avatar Converged.basic - Dark Mode.normal.chromium.png	395	Changed
Avatar Converged.basic - High Contrast.normal.chromium.png	597	Changed
Avatar Converged.basic - RTL.normal.chromium.png	602	Changed
Avatar Converged.basic.normal.chromium.png	615	Changed

fabricteam · 2022-12-23T14:21:13Z

Perf Analysis (`@fluentui/react`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
GroupedList	mount	2468	2831	2	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
BaseButton	mount	1539	1554	5000
Breadcrumb	mount	3693	3700	1000
Checkbox	mount	3332	3410	5000
CheckboxBase	mount	3055	3052	5000
ChoiceGroup	mount	6017	5912	5000
ComboBox	mount	1568	1580	1000
CommandBar	mount	11860	11860	1000
ContextualMenu	mount	13543	13655	1000
DefaultButton	mount	1774	1800	5000
DetailsRow	mount	4628	4700	5000
DetailsRowFast	mount	4704	4624	5000
DetailsRowNoStyles	mount	4517	4527	5000
Dialog	mount	3769	3822	1000
DocumentCardTitle	mount	742	717	1000
Dropdown	mount	4162	4219	5000
FocusTrapZone	mount	2493	2545	5000
FocusZone	mount	2620	2481	5000
GroupedList	mount	2468	2831	2	Possible regression
GroupedList	virtual-rerender	1448	1430	2
GroupedList	virtual-rerender-with-unmount	2119	2131	2
GroupedListV2	mount	718	691	2
GroupedListV2	virtual-rerender	670	663	2
GroupedListV2	virtual-rerender-with-unmount	684	720	2
IconButton	mount	2460	2540	5000
Label	mount	952	924	5000
Layer	mount	5393	5569	5000
Link	mount	1037	1044	5000
MenuButton	mount	2234	2256	5000
MessageBar	mount	2982	2860	5000
Nav	mount	4234	4194	1000
OverflowSet	mount	1733	1738	5000
Panel	mount	3158	3161	1000
Persona	mount	1688	1695	1000
Pivot	mount	2074	2114	1000
PrimaryButton	mount	1977	1941	5000
Rating	mount	9350	9385	5000
SearchBox	mount	2022	1970	5000
Shimmer	mount	3715	3783	5000
Slider	mount	2707	2709	5000
SpinButton	mount	5955	6107	5000
Spinner	mount	990	987	5000
SplitButton	mount	3992	4017	5000
Stack	mount	1046	1051	5000
StackWithIntrinsicChildren	mount	3173	3226	5000
StackWithTextChildren	mount	6471	6652	5000
SwatchColorPicker	mount	13294	13318	5000
TagPicker	mount	3321	3400	5000
TeachingBubble	mount	106437	107283	5000
Text	mount	996	1005	5000
TextField	mount	2048	2050	5000
ThemeProvider	mount	1878	1930	5000
ThemeProvider	virtual-rerender	1329	1340	5000
ThemeProvider	virtual-rerender-with-unmount	2711	2692	5000
Toggle	mount	1416	1418	5000
buttonNative	mount	668	659	5000

fabricteam · 2022-12-23T14:34:22Z

🕵 FluentUI-v0 No visual regressions between this PR and main

…26099) * chore(scripts): remove deep imports from /scripts/tasks/* * generate changefiles

msft-fluent-ui-bot added the Area: Website label Dec 23, 2022

msft-fluent-ui-bot assigned bsunderhus Dec 23, 2022

Hotell changed the title ~~Hotell/build/scripts/ts solution config v9~~ chore(scripts): remove deep imports from /scripts/tasks/* Dec 23, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Dec 23, 2022

Hotell unassigned bsunderhus Dec 23, 2022

Hotell added Area: Build System and removed Area: Website labels Dec 23, 2022

Hotell mentioned this pull request Dec 23, 2022

feat: make backbone of our tooling compliant with package standards (packaging /scripts) #24349

Closed

18 tasks

Hotell added 2 commits December 23, 2022 16:48

chore(scripts): remove deep imports from /scripts/tasks/*

9078900

generate changefiles

c4d1034

Hotell force-pushed the hotell/build/scripts/ts-solution-config-v9 branch from 804c893 to c4d1034 Compare December 23, 2022 15:48

Hotell marked this pull request as ready for review December 23, 2022 15:49

Hotell requested review from a team as code owners December 23, 2022 15:49

TristanWatanabe approved these changes Dec 27, 2022

View reviewed changes

sopranopillow approved these changes Dec 28, 2022

View reviewed changes

Hotell merged commit 2119358 into microsoft:master Dec 28, 2022

Hotell deleted the hotell/build/scripts/ts-solution-config-v9 branch December 28, 2022 17:05

q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023

chore(scripts): remove deep imports from /scripts/tasks/* (microsoft#…

03441d3

…26099) * chore(scripts): remove deep imports from /scripts/tasks/* * generate changefiles

Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore(scripts): remove deep imports from /scripts/tasks/* (microsoft#…

7217357

…26099) * chore(scripts): remove deep imports from /scripts/tasks/* * generate changefiles

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(scripts): remove deep imports from /scripts/tasks/*#26099

chore(scripts): remove deep imports from /scripts/tasks/*#26099
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v9

Hotell commented Dec 23, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Dec 23, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 23, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Dec 23, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 23, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 23, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 23, 2022

Uh oh!

fabricteam commented Dec 23, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 23, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 23, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Hotell commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

size-auditor bot commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

codesandbox-ci bot commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 23, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 4 screenshots

Uh oh!

fabricteam commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Hotell commented Dec 23, 2022 •

edited

Loading

size-auditor bot commented Dec 23, 2022 •

edited

Loading

fabricteam commented Dec 23, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

codesandbox-ci bot commented Dec 23, 2022 •

edited

Loading

fabricteam commented Dec 23, 2022 •

edited

Loading

fabricteam commented Dec 23, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Dec 23, 2022 •

edited

Loading

fabricteam commented Dec 23, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Dec 23, 2022 •

edited

Loading