Skip to content

chore (v0 vr-tests): Remove unneeded eslint rule disable comments#26073

Merged
TristanWatanabe merged 2 commits intomicrosoft:masterfrom
TristanWatanabe:v0-remove-lint-disable-lines
Dec 22, 2022
Merged

chore (v0 vr-tests): Remove unneeded eslint rule disable comments#26073
TristanWatanabe merged 2 commits intomicrosoft:masterfrom
TristanWatanabe:v0-remove-lint-disable-lines

Conversation

@TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Dec 21, 2022

Changes:

  • removes unneeded eslint-disable-next-line import/no-extraneous-dependencies line comments.
  • updates eslint config rule override to also include "src/vr-tests/**/*.tsx".

Related Issue(s)

@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against db7d2bd

@size-auditor
Copy link

size-auditor bot commented Dec 21, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0dced6be8495f5341e09d8e0c5af7d20d9869b48 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against c12218d1b3f86d2db62131490dc04651821c334b

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db7d2bd:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v0 No visual regressions between this PR and main

@TristanWatanabe TristanWatanabe marked this pull request as ready for review December 22, 2022 00:08
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner December 22, 2022 00:08
@TristanWatanabe TristanWatanabe merged commit 64040a4 into microsoft:master Dec 22, 2022
q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all the eslint-disable-next-line import/no-extraneous-dependencies lines that were added to northstar stories

5 participants