Skip to content

refactor(scripts): separate /storybook and /webpack and introduce barrel api within /webpack#26072

Merged
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v8
Dec 23, 2022
Merged

refactor(scripts): separate /storybook and /webpack and introduce barrel api within /webpack#26072
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v8

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Dec 21, 2022 •
edited
Loading

Previous Behavior

  • /storybook contains mixed v8 and v9 code
  • /webpack exposes deep imports for v8 tooling

New Behavior

  • /storybook contains only v9 code
  • /webpack uses barrel file to prevent deep imports

Related Issue(s)

@Hotell Hotell changed the title refactor(scripts): separate /storybook and /webpack and introduce bar… refactor(scripts): separate /storybook and /webpack and introduce barell api within /webpack Dec 21, 2022
@size-auditor
Copy link

size-auditor bot commented Dec 21, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c12218d1b3f86d2db62131490dc04651821c334b (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 21, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be47b9a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 21, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 3.153 kB
1.299 kB
react-accordion
Accordion (including children components)		 79.294 kB
24.443 kB
react-alert
Alert		 84.15 kB
21.28 kB
react-avatar
Avatar		 51.083 kB
14.289 kB
react-avatar
AvatarGroup		 15.006 kB
6.009 kB
react-avatar
AvatarGroupItem		 67.313 kB
18.585 kB
react-badge
Badge		 23.357 kB
7.361 kB
react-badge
CounterBadge		 24.247 kB
7.643 kB
react-badge
PresenceBadge		 24.001 kB
7.049 kB
react-button
Button		 32.923 kB
8.61 kB
react-button
CompoundButton		 39.953 kB
9.933 kB
react-button
MenuButton		 37.611 kB
9.942 kB
react-button
SplitButton		 45.057 kB
11.323 kB
react-button
ToggleButton		 48.753 kB
10.715 kB
react-card
Card - All		 77.541 kB
22.325 kB
react-card
Card		 72.485 kB
20.913 kB
react-card
CardFooter		 8.617 kB
3.62 kB
react-card
CardHeader		 10.382 kB
4.258 kB
react-card
CardPreview		 9.424 kB
3.97 kB
react-checkbox
Checkbox		 28.65 kB
9.09 kB
react-checkbox
CheckboxField		 35.067 kB
10.89 kB
react-combobox
Combobox (including child components)		 78.629 kB
25.167 kB
react-combobox
ComboboxField		 75.831 kB
25.116 kB
react-combobox
Dropdown (including child components)		 77.876 kB
25.104 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 59.381 kB
16.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 187.067 kB
52.466 kB
react-components
react-components: FluentProvider & webLightTheme		 33.843 kB
11.129 kB
react-dialog
Dialog (including children components)		 83.036 kB
24.754 kB
react-divider
Divider		 16.515 kB
5.921 kB
react-image
Image		 10.836 kB
4.283 kB
react-infobutton
InfoButton		 118.298 kB
35.438 kB
react-input
Input		 24.194 kB
7.89 kB
react-input
InputField		 33.408 kB
10.584 kB
react-label
Label		 9.394 kB
3.88 kB
react-link
Link		 11.862 kB
4.885 kB
react-menu
Menu (including children components)		 117.794 kB
36.361 kB
react-menu
Menu (including selectable components)		 120.863 kB
36.895 kB
react-overflow
hooks only		 11.004 kB
4.188 kB
react-persona
Persona		 57.12 kB
15.945 kB
react-popover
Popover		 104.042 kB
32.021 kB
react-portal
Portal		 10.495 kB
3.851 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.868 kB
7.432 kB
react-progress
ProgressBar		 13.155 kB
5.048 kB
react-progress
ProgressField		 22.461 kB
7.919 kB
react-provider
FluentProvider		 15.91 kB
5.931 kB
react-radio
Radio		 31.827 kB
10.316 kB
react-radio
RadioGroup		 14.304 kB
5.72 kB
react-radio
RadioGroupField		 23.604 kB
8.65 kB
react-select
Select		 23.474 kB
8.017 kB
react-select
SelectField		 31.731 kB
10.256 kB
react-slider
Slider		 32.091 kB
10.183 kB
react-slider
SliderField		 41.113 kB
12.903 kB
react-spinbutton
SpinButton		 44.502 kB
12.812 kB
react-spinbutton
SpinButtonField		 52.784 kB
15.085 kB
react-spinner
Spinner		 20.013 kB
6.446 kB
react-switch
Switch		 33.427 kB
10.581 kB
react-switch
SwitchField		 39.745 kB
12.362 kB
react-text
Text - Default		 11.838 kB
4.625 kB
react-text
Text - Wrappers		 15.148 kB
5.06 kB
react-textarea
Textarea		 25.733 kB
8.328 kB
react-textarea
TextareaField		 34.949 kB
11.012 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 30.908 kB
6.714 kB
react-theme
Teams: Light theme		 17.776 kB
5.141 kB
react-tooltip
Tooltip		 42.074 kB
14.752 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against c12218d1b3f86d2db62131490dc04651821c334b

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 21, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1574 1585 5000
Button mount 1128 1122 5000
FluentProvider mount 1892 1917 5000
FluentProviderWithTheme mount 749 786 10
FluentProviderWithTheme virtual-rerender 718 701 10
FluentProviderWithTheme virtual-rerender-with-unmount 740 748 10
MakeStyles mount 2278 2335 50000
Persona mount 3568 3614 5000
SpinButton mount 2968 3049 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 21, 2022 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 21, 2022

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 21, 2022 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 21, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
GroupedList mount 2239 2601 2 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1405 1377 5000
Breadcrumb mount 3467 3444 1000
Checkbox mount 3058 3062 5000
CheckboxBase mount 2834 2779 5000
ChoiceGroup mount 5156 5218 5000
ComboBox mount 1475 1437 1000
CommandBar mount 11291 11224 1000
ContextualMenu mount 12698 12707 1000
DefaultButton mount 1643 1625 5000
DetailsRow mount 4246 4222 5000
DetailsRowFast mount 4446 4228 5000
DetailsRowNoStyles mount 4072 4068 5000
Dialog mount 3582 3698 1000
DocumentCardTitle mount 689 679 1000
Dropdown mount 3864 3837 5000
FocusTrapZone mount 2426 2414 5000
FocusZone mount 2387 2357 5000
GroupedList mount 2239 2601 2 Possible regression
GroupedList virtual-rerender 1317 1350 2
GroupedList virtual-rerender-with-unmount 1974 1999 2
GroupedListV2 mount 673 677 2
GroupedListV2 virtual-rerender 649 658 2
GroupedListV2 virtual-rerender-with-unmount 686 669 2
IconButton mount 2250 2232 5000
Label mount 883 865 5000
Layer mount 5119 5167 5000
Link mount 975 986 5000
MenuButton mount 2007 1978 5000
MessageBar mount 2778 2770 5000
Nav mount 3854 3891 1000
OverflowSet mount 1629 1630 5000
Panel mount 3003 3020 1000
Persona mount 1536 1568 1000
Pivot mount 1933 1905 1000
PrimaryButton mount 1805 1844 5000
Rating mount 8216 8376 5000
SearchBox mount 1779 1835 5000
Shimmer mount 3371 3371 5000
Slider mount 2447 2544 5000
SpinButton mount 5497 5562 5000
Spinner mount 962 954 5000
SplitButton mount 3651 3629 5000
Stack mount 990 992 5000
StackWithIntrinsicChildren mount 2759 2794 5000
StackWithTextChildren mount 5746 5706 5000
SwatchColorPicker mount 12222 12418 5000
TagPicker mount 3352 3080 5000
TeachingBubble mount 97978 100276 5000
Text mount 953 945 5000
TextField mount 1868 1904 5000
ThemeProvider mount 1832 1844 5000
ThemeProvider virtual-rerender 1257 1248 5000
ThemeProvider virtual-rerender-with-unmount 2494 2545 5000
Toggle mount 1314 1312 5000
buttonNative mount 633 628 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 21, 2022

🕵 FluentUI-v0 No visual regressions between this PR and main

@Hotell Hotell changed the title refactor(scripts): separate /storybook and /webpack and introduce barell api within /webpack refactor(scripts): separate /storybook and /webpack and introduce barrel api within /webpack Dec 22, 2022
@Hotell Hotell marked this pull request as ready for review December 22, 2022 14:32
@Hotell Hotell requested review from a team as code owners December 22, 2022 14:32
@Hotell Hotell merged commit 0ba1e7e into microsoft:master Dec 23, 2022
@Hotell Hotell deleted the hotell/build/scripts/ts-solution-config-v8 branch December 23, 2022 12:31
@Hotell Hotell mentioned this pull request Dec 23, 2022
Closed
18 tasks
q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023
@Hotell @q1b
refactor(scripts): separate /storybook and /webpack and introduce…
8010c69 
… barrel api within `/webpack` (microsoft#26072)

* refactor(scripts): separate /storybook and /webpack and introduce barell api within /webpack

* generate change files
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
@Hotell
refactor(scripts): separate /storybook and /webpack and introduce…
8fc9f2d 
… barrel api within `/webpack` (microsoft#26072)

* refactor(scripts): separate /storybook and /webpack and introduce barell api within /webpack

* generate change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khmakoto khmakoto khmakoto approved these changes

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@spmonahan spmonahan spmonahan approved these changes

Assignees

No one assigned

Labels

Area: Build System

Projects

None yet

Milestone

October Project Cycle Q4 2022

Development

Successfully merging this pull request may close these issues.

6 participants

@Hotell @fabricteam @khmakoto @TristanWatanabe @spmonahan @bsunderhus