chore: remove screener dependencies and various screener removal cleanups by TristanWatanabe · Pull Request #26070 · microsoft/fluentui

TristanWatanabe · 2022-12-21T18:57:40Z

Changes:

removes screener-storybook dependency from monorepo package.json and updates yarn.lock file.
removes convert script from v8 and v9 VR tests packages since it's no longer needed.
renames screener:build script to vr:build and test:component to vr:test across v0, v8 and v9. Renames are also reflected in the runpublishscreenshot template file used by the 1JS VR tool.
various nit renames of screener to storywright.
removals of unneeded usage of screener-storybook in a couple of packages.

Related Issue(s)

Part of [Epic]: Visual Regression Tool Migration #25078

…st scripts

DustyTheBot · 2022-12-21T19:03:00Z

	Warnings
⚠️	There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against dffdbb8

fabricteam · 2022-12-21T19:03:08Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.294 kB` `24.443 kB`
`react-alert` Alert	`84.15 kB` `21.28 kB`
`react-avatar` Avatar	`51.083 kB` `14.289 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.313 kB` `18.585 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`77.541 kB` `22.325 kB`
`react-card` Card	`72.485 kB` `20.913 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`10.382 kB` `4.258 kB`
`react-card` CardPreview	`9.424 kB` `3.97 kB`
`react-checkbox` Checkbox	`28.65 kB` `9.09 kB`
`react-checkbox` CheckboxField	`35.067 kB` `10.89 kB`
`react-combobox` Combobox (including child components)	`78.629 kB` `25.167 kB`
`react-combobox` ComboboxField	`75.831 kB` `25.116 kB`
`react-combobox` Dropdown (including child components)	`77.876 kB` `25.104 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.381 kB` `16.465 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`187.067 kB` `52.466 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.843 kB` `11.129 kB`
`react-dialog` Dialog (including children components)	`83.036 kB` `24.754 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`118.298 kB` `35.438 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-input` InputField	`33.408 kB` `10.584 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`117.794 kB` `36.361 kB`
`react-menu` Menu (including selectable components)	`120.863 kB` `36.895 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.12 kB` `15.945 kB`
`react-popover` Popover	`104.042 kB` `32.021 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.868 kB` `7.432 kB`
`react-progress` ProgressBar	`13.155 kB` `5.048 kB`
`react-progress` ProgressField	`22.461 kB` `7.919 kB`
`react-provider` FluentProvider	`15.91 kB` `5.931 kB`
`react-radio` Radio	`31.827 kB` `10.316 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-radio` RadioGroupField	`23.604 kB` `8.65 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-select` SelectField	`31.731 kB` `10.256 kB`
`react-slider` Slider	`32.091 kB` `10.183 kB`
`react-slider` SliderField	`41.113 kB` `12.903 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinbutton` SpinButtonField	`52.784 kB` `15.085 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.427 kB` `10.581 kB`
`react-switch` SwitchField	`39.745 kB` `12.362 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-textarea` TextareaField	`34.949 kB` `11.012 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`42.074 kB` `14.752 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against c12218d1b3f86d2db62131490dc04651821c334b}

fabricteam · 2022-12-21T19:27:36Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-12-21T19:28:26Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1527	1542	5000
Button	mount	1147	1129	5000
FluentProvider	mount	1872	1874	5000
FluentProviderWithTheme	mount	749	749	10
FluentProviderWithTheme	virtual-rerender	721	732	10
FluentProviderWithTheme	virtual-rerender-with-unmount	788	756	10
MakeStyles	mount	2326	2339	50000
Persona	mount	3653	3571	5000
SpinButton	mount	3106	3044	5000

size-auditor · 2022-12-21T19:38:54Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c12218d1b3f86d2db62131490dc04651821c334b (build)

codesandbox-ci · 2022-12-21T19:39:52Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dffdbb8:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-12-21T19:44:12Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2022-12-21T19:47:22Z

Perf Analysis (`@fluentui/react`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
GroupedList	mount	2218	2531	2	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
BaseButton	mount	1416	1406	5000
Breadcrumb	mount	3557	3453	1000
Checkbox	mount	3103	3141	5000
CheckboxBase	mount	2796	2780	5000
ChoiceGroup	mount	5290	5256	5000
ComboBox	mount	1497	1459	1000
CommandBar	mount	11394	11495	1000
ContextualMenu	mount	12876	12677	1000
DefaultButton	mount	1616	1644	5000
DetailsRow	mount	4335	4271	5000
DetailsRowFast	mount	4320	4288	5000
DetailsRowNoStyles	mount	4138	4203	5000
Dialog	mount	3841	3605	1000
DocumentCardTitle	mount	666	701	1000
Dropdown	mount	3820	3801	5000
FocusTrapZone	mount	2436	2409	5000
FocusZone	mount	2371	2307	5000
GroupedList	mount	2218	2531	2	Possible regression
GroupedList	virtual-rerender	1362	1330	2
GroupedList	virtual-rerender-with-unmount	1983	2001	2
GroupedListV2	mount	667	687	2
GroupedListV2	virtual-rerender	671	652	2
GroupedListV2	virtual-rerender-with-unmount	688	671	2
IconButton	mount	2259	2259	5000
Label	mount	857	883	5000
Layer	mount	5083	5051	5000
Link	mount	974	991	5000
MenuButton	mount	2002	1998	5000
MessageBar	mount	2677	2795	5000
Nav	mount	3922	4009	1000
OverflowSet	mount	1637	1589	5000
Panel	mount	2976	3156	1000
Persona	mount	1557	1544	1000
Pivot	mount	1919	1962	1000
PrimaryButton	mount	1843	1827	5000
Rating	mount	8276	8231	5000
SearchBox	mount	1841	1776	5000
Shimmer	mount	3373	3377	5000
Slider	mount	2524	2515	5000
SpinButton	mount	5513	5579	5000
Spinner	mount	953	961	5000
SplitButton	mount	3675	3606	5000
Stack	mount	966	985	5000
StackWithIntrinsicChildren	mount	2724	2744	5000
StackWithTextChildren	mount	5910	5686	5000
SwatchColorPicker	mount	12277	12672	5000
TagPicker	mount	3132	3085	5000
TeachingBubble	mount	98487	100727	5000
Text	mount	939	929	5000
TextField	mount	1914	1868	5000
ThemeProvider	mount	1813	1828	5000
ThemeProvider	virtual-rerender	1261	1279	5000
ThemeProvider	virtual-rerender-with-unmount	2544	2536	5000
Toggle	mount	1292	1300	5000
buttonNative	mount	638	655	5000

fabricteam · 2022-12-21T19:48:05Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2022-12-21T19:56:28Z

🕵 FluentUI-v0 No visual regressions between this PR and main

…nups (microsoft#26070)

TristanWatanabe added 10 commits December 16, 2022 14:50

chore(root): remove screener-storybook dependency

083a9a3

chore: update yarn.lock

bf73328

nit: rename scripts to vr:build and vr:test

04e1ca0

nit: update runpublishvrscreenshot template to use vr:build and vr:te…

19fdc9f

…st scripts

chore: remove convert scripts from v8 and v9 vr tests pkgs

881734b

chore(docsite-v9, v0-vr-tests): remove stray screener-storybook usage

2821f18

chore: replace screener word usage with storywright

1a8c827

Change File

d11284e

chore: deduplicate form-data

7f2f7d6

chore: deduplicate punycode

dffdbb8

TristanWatanabe self-assigned this Dec 21, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Dec 21, 2022

TristanWatanabe force-pushed the screener-removal-cleanup branch from c226472 to d11284e Compare December 21, 2022 19:11

TristanWatanabe marked this pull request as ready for review December 21, 2022 21:09

TristanWatanabe requested review from a team as code owners December 21, 2022 21:09

layershifter approved these changes Dec 21, 2022

View reviewed changes

TristanWatanabe mentioned this pull request Dec 21, 2022

[Epic]: Visual Regression Tool Migration #25078

Closed

27 tasks

ling1726 approved these changes Dec 22, 2022

View reviewed changes

TristanWatanabe merged commit a18b520 into microsoft:master Dec 22, 2022

TristanWatanabe deleted the screener-removal-cleanup branch December 22, 2022 16:51

q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023

chore: remove screener dependencies and various screener removal clea…

ca489f8

…nups (microsoft#26070)

Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore: remove screener dependencies and various screener removal clea…

24e60ea

…nups (microsoft#26070)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove screener dependencies and various screener removal cleanups#26070

chore: remove screener dependencies and various screener removal cleanups#26070
TristanWatanabe merged 10 commits intomicrosoft:masterfrom
TristanWatanabe:screener-removal-cleanup

TristanWatanabe commented Dec 21, 2022 •

edited

Loading

Uh oh!

DustyTheBot commented Dec 21, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2022

Uh oh!

fabricteam commented Dec 21, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Dec 21, 2022

Uh oh!

codesandbox-ci bot commented Dec 21, 2022

Uh oh!

fabricteam commented Dec 21, 2022

Uh oh!

fabricteam commented Dec 21, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2022

Uh oh!

fabricteam commented Dec 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

TristanWatanabe commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Related Issue(s)

Uh oh!

DustyTheBot commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Dec 21, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor bot commented Dec 21, 2022

Asset size changes

Uh oh!

codesandbox-ci bot commented Dec 21, 2022

Uh oh!

fabricteam commented Dec 21, 2022

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Dec 21, 2022

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 21, 2022

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TristanWatanabe commented Dec 21, 2022 •

edited

Loading

DustyTheBot commented Dec 21, 2022 •

edited

Loading

fabricteam commented Dec 21, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Dec 21, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Dec 21, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)