chore (scripts): update create-package and create-component plop templates to reflect new v9 package structure by TristanWatanabe · Pull Request #26067 · microsoft/fluentui

TristanWatanabe · 2022-12-21T17:37:25Z

Changes:

updates create-package react plop template and moves Spec.md file to new docs/ subfolder.
updates create-component plop template and renames common folder to testing and makes appropriate import path change.

Related Issue(s)

Part of Defined standard for v9 package file organization #24129

size-auditor · 2022-12-21T17:53:41Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c12218d1b3f86d2db62131490dc04651821c334b (build)

codesandbox-ci · 2022-12-21T17:53:46Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 09b55a4:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-12-21T17:56:03Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1555	1560	5000
Button	mount	1119	1122	5000
FluentProvider	mount	1885	1892	5000
FluentProviderWithTheme	mount	767	742	10
FluentProviderWithTheme	virtual-rerender	729	701	10
FluentProviderWithTheme	virtual-rerender-with-unmount	731	735	10
MakeStyles	mount	2250	2259	50000
Persona	mount	3588	3578	5000
SpinButton	mount	3017	2942	5000

fabricteam · 2022-12-21T17:58:06Z

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 2 screenshots removed, 1043 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 2 screenshots

Image Name	Diff(in Pixels)	Image Type
Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png	0	Removed
Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png	0	Removed

fabricteam · 2022-12-21T17:58:33Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.294 kB` `24.443 kB`
`react-alert` Alert	`84.15 kB` `21.28 kB`
`react-avatar` Avatar	`51.083 kB` `14.289 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.313 kB` `18.585 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`77.541 kB` `22.325 kB`
`react-card` Card	`72.485 kB` `20.913 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`10.382 kB` `4.258 kB`
`react-card` CardPreview	`9.424 kB` `3.97 kB`
`react-checkbox` Checkbox	`28.65 kB` `9.09 kB`
`react-checkbox` CheckboxField	`35.067 kB` `10.89 kB`
`react-combobox` Combobox (including child components)	`78.629 kB` `25.167 kB`
`react-combobox` ComboboxField	`75.831 kB` `25.116 kB`
`react-combobox` Dropdown (including child components)	`77.876 kB` `25.104 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.381 kB` `16.465 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`187.067 kB` `52.466 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.843 kB` `11.129 kB`
`react-dialog` Dialog (including children components)	`83.036 kB` `24.754 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`118.298 kB` `35.438 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-input` InputField	`33.408 kB` `10.584 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`117.794 kB` `36.361 kB`
`react-menu` Menu (including selectable components)	`120.863 kB` `36.895 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.12 kB` `15.945 kB`
`react-popover` Popover	`104.042 kB` `32.021 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.868 kB` `7.432 kB`
`react-progress` ProgressBar	`13.155 kB` `5.048 kB`
`react-progress` ProgressField	`22.461 kB` `7.919 kB`
`react-provider` FluentProvider	`15.91 kB` `5.931 kB`
`react-radio` Radio	`31.827 kB` `10.316 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-radio` RadioGroupField	`23.604 kB` `8.65 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-select` SelectField	`31.731 kB` `10.256 kB`
`react-slider` Slider	`32.091 kB` `10.183 kB`
`react-slider` SliderField	`41.113 kB` `12.903 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinbutton` SpinButtonField	`52.784 kB` `15.085 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.427 kB` `10.581 kB`
`react-switch` SwitchField	`39.745 kB` `12.362 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-textarea` TextareaField	`34.949 kB` `11.012 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`42.074 kB` `14.752 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against c12218d1b3f86d2db62131490dc04651821c334b}

fabricteam · 2022-12-21T18:01:50Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-12-21T18:02:05Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2022-12-21T18:10:29Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2022-12-21T18:10:29Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1201	1205	5000
Breadcrumb	mount	2829	2804	1000
Checkbox	mount	2634	2607	5000
CheckboxBase	mount	2383	2363	5000
ChoiceGroup	mount	4238	4211	5000
ComboBox	mount	1183	1187	1000
CommandBar	mount	9228	9230	1000
ContextualMenu	mount	10152	10058	1000
DefaultButton	mount	1345	1347	5000
DetailsRow	mount	3379	3363	5000
DetailsRowFast	mount	3349	3337	5000
DetailsRowNoStyles	mount	3224	3251	5000
Dialog	mount	2931	2918	1000
DocumentCardTitle	mount	570	589	1000
Dropdown	mount	3156	3154	5000
FocusTrapZone	mount	1940	1964	5000
FocusZone	mount	1912	1947	5000
GroupedList	mount	1805	2054	2
GroupedList	virtual-rerender	1082	1074	2
GroupedList	virtual-rerender-with-unmount	1598	1610	2
GroupedListV2	mount	564	555	2
GroupedListV2	virtual-rerender	546	532	2
GroupedListV2	virtual-rerender-with-unmount	563	554	2
IconButton	mount	1788	1785	5000
Label	mount	756	747	5000
Layer	mount	4148	4212	5000
Link	mount	847	855	5000
MenuButton	mount	1576	1607	5000
MessageBar	mount	2301	2348	5000
Nav	mount	3033	3055	1000
OverflowSet	mount	1404	1425	5000
Panel	mount	2475	2495	1000
Persona	mount	1272	1286	1000
Pivot	mount	1531	1521	1000
PrimaryButton	mount	1490	1492	5000
Rating	mount	6985	6989	5000
SearchBox	mount	1489	1515	5000
Shimmer	mount	2924	2911	5000
Slider	mount	2089	2109	5000
SpinButton	mount	4235	4235	5000
Spinner	mount	824	839	5000
SplitButton	mount	2825	2826	5000
Stack	mount	846	875	5000
StackWithIntrinsicChildren	mount	2283	2273	5000
StackWithTextChildren	mount	4981	4949	5000
SwatchColorPicker	mount	9383	9478	5000
TagPicker	mount	2312	2316	5000
TeachingBubble	mount	74731	73247	5000
Text	mount	820	817	5000
TextField	mount	1562	1529	5000
ThemeProvider	mount	1458	1429	5000
ThemeProvider	virtual-rerender	1135	1143	5000
ThemeProvider	virtual-rerender-with-unmount	1996	1996	5000
Toggle	mount	1146	1125	5000
buttonNative	mount	534	527	5000

…lates to reflect new v9 package structure (microsoft#26067)

TristanWatanabe added 2 commits December 16, 2022 13:08

chore: move spec file to docs subfolder

8c2ea1d

chore: rename common folder to testing and update test file import path

09b55a4

TristanWatanabe self-assigned this Dec 21, 2022

msft-fluent-ui-bot added the Area: Build System label Dec 21, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Dec 21, 2022

TristanWatanabe mentioned this pull request Dec 21, 2022

Defined standard for v9 package file organization #24129

Closed

59 tasks

TristanWatanabe marked this pull request as ready for review December 21, 2022 19:28

TristanWatanabe requested a review from a team as a code owner December 21, 2022 19:28

Hotell approved these changes Dec 21, 2022

View reviewed changes

TristanWatanabe closed this Dec 21, 2022

TristanWatanabe reopened this Dec 21, 2022

TristanWatanabe merged commit 0dced6b into microsoft:master Dec 21, 2022

TristanWatanabe deleted the update-create-pkg-template branch December 21, 2022 23:31

q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023

chore (scripts): update create-package and create-component plop temp…

0418586

…lates to reflect new v9 package structure (microsoft#26067)

Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore (scripts): update create-package and create-component plop temp…

e6221b9

…lates to reflect new v9 package structure (microsoft#26067)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore (scripts): update create-package and create-component plop templates to reflect new v9 package structure#26067

chore (scripts): update create-package and create-component plop templates to reflect new v9 package structure#26067
TristanWatanabe merged 2 commits intomicrosoft:masterfrom
TristanWatanabe:update-create-pkg-template

TristanWatanabe commented Dec 21, 2022

Uh oh!

size-auditor bot commented Dec 21, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Dec 21, 2022

Uh oh!

fabricteam commented Dec 21, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2022

Uh oh!

fabricteam commented Dec 21, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 21, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

TristanWatanabe commented Dec 21, 2022

Changes:

Related Issue(s)

Uh oh!

size-auditor bot commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

codesandbox-ci bot commented Dec 21, 2022

Uh oh!

fabricteam commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

Uh oh!

fabricteam commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Dec 21, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

size-auditor bot commented Dec 21, 2022 •

edited

Loading

fabricteam commented Dec 21, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Dec 21, 2022 •

edited

Loading

fabricteam commented Dec 21, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Dec 21, 2022 •

edited

Loading

fabricteam commented Dec 21, 2022 •

edited

Loading

fabricteam commented Dec 21, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)