chore(eslint config v9): turn off react/jsx-no-bind rule for cypress tests by TristanWatanabe · Pull Request #26003 · microsoft/fluentui

TristanWatanabe · 2022-12-14T23:05:10Z

Changes:

turns off react/jsx-no-bind rule for cypress test files.
removes one line comments disabling said rule in a couple of v9 cypress tests.

Related Issue(s)

Fixes Disable react/jsx-no-bind lint rule for v9 test files #25576

fabricteam · 2022-12-14T23:21:10Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1586	1562	5000
Button	mount	1115	1149	5000
FluentProvider	mount	1926	1902	5000
FluentProviderWithTheme	mount	756	733	10
FluentProviderWithTheme	virtual-rerender	711	697	10
FluentProviderWithTheme	virtual-rerender-with-unmount	750	761	10
MakeStyles	mount	2287	2269	50000
Persona	mount	3488	3524	5000
SpinButton	mount	2995	3047	5000

size-auditor · 2022-12-14T23:22:03Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 983c8a8477ffb675d5c756b5407d926bb90a5ad7 (build)

codesandbox-ci · 2022-12-14T23:22:57Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca043f4:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-12-14T23:25:29Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2022-12-14T23:30:50Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.294 kB` `24.443 kB`
`react-alert` Alert	`82.974 kB` `21.028 kB`
`react-avatar` Avatar	`51.083 kB` `14.289 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.313 kB` `18.585 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`77.541 kB` `22.325 kB`
`react-card` Card	`72.485 kB` `20.913 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`10.382 kB` `4.258 kB`
`react-card` CardPreview	`9.424 kB` `3.97 kB`
`react-checkbox` Checkbox	`28.65 kB` `9.09 kB`
`react-combobox` Combobox (including child components)	`78.546 kB` `25.167 kB`
`react-combobox` Dropdown (including child components)	`77.775 kB` `25.069 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.288 kB` `16.435 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`186.264 kB` `52.303 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.75 kB` `11.101 kB`
`react-dialog` Dialog (including children components)	`83.036 kB` `24.754 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`117.922 kB` `35.391 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`117.418 kB` `36.256 kB`
`react-menu` Menu (including selectable components)	`120.487 kB` `36.785 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.12 kB` `15.945 kB`
`react-popover` Popover	`103.666 kB` `31.858 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.826 kB` `7.417 kB`
`react-progress` ProgressBar	`13.563 kB` `5.12 kB`
`react-provider` FluentProvider	`15.817 kB` `5.905 kB`
`react-radio` Radio	`31.827 kB` `10.316 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-slider` Slider	`32.091 kB` `10.183 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.427 kB` `10.581 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`42.032 kB` `14.739 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 983c8a8477ffb675d5c756b5407d926bb90a5ad7}

fabricteam · 2022-12-14T23:31:02Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2022-12-14T23:31:22Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-12-14T23:33:38Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1432	1431	5000
Breadcrumb	mount	3571	3526	1000
Checkbox	mount	3192	3155	5000
CheckboxBase	mount	2815	2814	5000
ChoiceGroup	mount	5429	5322	5000
ComboBox	mount	1490	1520	1000
CommandBar	mount	11611	11571	1000
ContextualMenu	mount	13214	13128	1000
DefaultButton	mount	1673	1741	5000
DetailsRow	mount	4335	4189	5000
DetailsRowFast	mount	4368	4309	5000
DetailsRowNoStyles	mount	4064	4129	5000
Dialog	mount	3768	3660	1000
DocumentCardTitle	mount	698	696	1000
Dropdown	mount	3842	4011	5000
FocusTrapZone	mount	2416	2430	5000
FocusZone	mount	2382	2338	5000
GroupedList	mount	2370	2668	2
GroupedList	virtual-rerender	1431	1378	2
GroupedList	virtual-rerender-with-unmount	2083	2098	2
GroupedListV2	mount	720	685	2
GroupedListV2	virtual-rerender	664	691	2
GroupedListV2	virtual-rerender-with-unmount	700	689	2
IconButton	mount	2356	2286	5000
Label	mount	912	905	5000
Layer	mount	5250	5326	5000
Link	mount	1015	1007	5000
MenuButton	mount	2031	2002	5000
MessageBar	mount	2833	2772	5000
Nav	mount	4001	3944	1000
OverflowSet	mount	1653	1603	5000
Panel	mount	3043	3092	1000
Persona	mount	1532	1601	1000
Pivot	mount	1958	1969	1000
PrimaryButton	mount	1855	1776	5000
Rating	mount	8384	8381	5000
SearchBox	mount	1908	1933	5000
Shimmer	mount	3460	3504	5000
Slider	mount	2552	2541	5000
SpinButton	mount	5482	5614	5000
Spinner	mount	955	1014	5000
SplitButton	mount	3656	3792	5000
Stack	mount	993	1014	5000
StackWithIntrinsicChildren	mount	2771	2973	5000
StackWithTextChildren	mount	5828	5882	5000
SwatchColorPicker	mount	12489	12574	5000
TagPicker	mount	3102	3113	5000
TeachingBubble	mount	101936	100744	5000
Text	mount	950	965	5000
TextField	mount	1941	1881	5000
ThemeProvider	mount	1836	1870	5000
ThemeProvider	virtual-rerender	1279	1304	5000
ThemeProvider	virtual-rerender-with-unmount	2631	2558	5000
Toggle	mount	1375	1316	5000
buttonNative	mount	673	673	5000

fabricteam · 2022-12-14T23:39:33Z

🕵 FluentUI-v0 No visual regressions between this PR and main

…tests (microsoft#26003) Fixes undefined

TristanWatanabe added 5 commits December 14, 2022 17:17

chore: turn off react-jsx-no-bind rule for cypress tests

9a5c0c9

Change File

c15293e

fix: rule name typo

391cfac

chore: remove react/jsx-no-bind one line disables

1195c6c

Change Files

ca043f4

TristanWatanabe requested a review from a team as a code owner December 14, 2022 23:05

TristanWatanabe self-assigned this Dec 14, 2022

TristanWatanabe requested a review from a team as a code owner December 14, 2022 23:05

msft-fluent-ui-bot added the Area: Build System label Dec 14, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Dec 14, 2022

TristanWatanabe closed this Dec 15, 2022

TristanWatanabe reopened this Dec 15, 2022

ling1726 approved these changes Dec 19, 2022

View reviewed changes

TristanWatanabe merged commit bfe6a0a into microsoft:master Dec 19, 2022

TristanWatanabe deleted the turn-off-no-bind-lint-rule branch December 19, 2022 16:33

Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore(eslint config v9): turn off react/jsx-no-bind rule for cypress …

0bfe489

…tests (microsoft#26003) Fixes undefined

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(eslint config v9): turn off react/jsx-no-bind rule for cypress tests#26003

chore(eslint config v9): turn off react/jsx-no-bind rule for cypress tests#26003
TristanWatanabe merged 5 commits intomicrosoft:masterfrom
TristanWatanabe:turn-off-no-bind-lint-rule

TristanWatanabe commented Dec 14, 2022

Uh oh!

fabricteam commented Dec 14, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Dec 14, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Dec 14, 2022

Uh oh!

fabricteam commented Dec 14, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 14, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 14, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 14, 2022

Uh oh!

fabricteam commented Dec 14, 2022 •

edited

Loading

Uh oh!

fabricteam commented Dec 14, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

TristanWatanabe commented Dec 14, 2022

Changes:

Related Issue(s)

Uh oh!

fabricteam commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor bot commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

codesandbox-ci bot commented Dec 14, 2022

Uh oh!

fabricteam commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Dec 14, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fabricteam commented Dec 14, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

size-auditor bot commented Dec 14, 2022 •

edited

Loading

fabricteam commented Dec 14, 2022 •

edited

Loading

fabricteam commented Dec 14, 2022 •

edited

Loading

fabricteam commented Dec 14, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Dec 14, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Dec 14, 2022 •

edited

Loading