chore (v8-vr-tests): Remove usage of Screener#25979
Merged
TristanWatanabe merged 6 commits intomicrosoft:masterfrom Dec 20, 2022
Merged
chore (v8-vr-tests): Remove usage of Screener#25979TristanWatanabe merged 6 commits intomicrosoft:masterfrom
TristanWatanabe merged 6 commits intomicrosoft:masterfrom
Conversation
TristanWatanabe
commented
Dec 13, 2022
| @@ -12,7 +12,6 @@ | |||
| "just": "just-scripts", | |||
| "lint": "just-scripts lint", | |||
| "screener:build": "cross-env NODE_OPTIONS=--max-old-space-size=3072 just-scripts storybook:build", | |||
Member
Author
There was a problem hiding this comment.
screener:build will be renamed in a separate PR along with other miscellaneous changes
Collaborator
📊 Bundle size report🤖 This report was generated against 3ec3c7736e16e84dc94c85f6fbb71b5d0177a5e7 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 97c1c1ab218afb20e37bfc35936fd88177d439b4 (build) |
Collaborator
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 4 screenshots✅ There was 0 screenshots added, 4 screenshots removed, 1041 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. unknown 4 screenshots
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c5f5d17:
|
27 tasks
micahgodbolt
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Screenerspecific configs.Screenerrelated dependencies from package.json.Screenertags withStoryWrighttags,screenerrelated imports withstorywright.Related Issue(s)