fix(react-persona): Make Persona's text wrap when overflowing its container#25880
Merged
sopranopillow merged 4 commits intomicrosoft:masterfrom Dec 2, 2022
Merged
fix(react-persona): Make Persona's text wrap when overflowing its container#25880sopranopillow merged 4 commits intomicrosoft:masterfrom
sopranopillow merged 4 commits intomicrosoft:masterfrom
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e1d595b1b12066d3ef1fd7dfc71bd0a81728316e (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1301 | 1283 | 5000 | |
| Button | mount | 922 | 924 | 5000 | |
| FluentProvider | mount | 1495 | 1484 | 5000 | |
| FluentProviderWithTheme | mount | 577 | 596 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 548 | 538 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 585 | 568 | 10 | |
| MakeStyles | mount | 1972 | 1965 | 50000 | |
| Persona | mount | 2847 | 2814 | 5000 | |
| SpinButton | mount | 2345 | 2391 | 5000 |
This was referenced Dec 2, 2022
Closed
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 40ac6e9:
|
Collaborator
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 1 screenshots✅ There was 1 screenshots added, 0 screenshots removed, 1754 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. unknown 1 screenshots
|
sopranopillow
commented
Dec 2, 2022
| after: { | ||
| gridAutoFlow: 'column', | ||
| justifyItems: 'start', | ||
| gridTemplateColumns: 'max-content [middle] auto', |
Contributor
Author
There was a problem hiding this comment.
In order for the wrap to work, the column containing the text needs to be set to auto. If it's set to max-content it will ignore the container's size.
Member
|
Can you add a VR story, or even regular story demonstrating this overflow behavior? |
micahgodbolt
approved these changes
Dec 2, 2022
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…tainer (microsoft#25880) * make Persona's text wrap when overflowing * change file * removing gap from avatar/presence * adding vr-test to check wrapping behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Persona's text did not wrap when overflowing its container due to using
gridAutoColumns: max-content.New Behavior
Persona's text now wraps when overflowing its container.
Related Issue(s)