Skip to content

chore: migrate all packages to generate-api approach with unified tsc processing#25609

Merged
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/api-generation-migration
Nov 15, 2022
Merged

chore: migrate all packages to generate-api approach with unified tsc processing#25609
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/build/api-generation-migration

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Nov 10, 2022 •
edited
Loading

Pre-requirements

Changes

All v9 packages migrated to generate-api and unified tsc processing (via nx workspace-generator migrate-converged-pkg --all)

New DX

updating/generating api.md

Before:
yarn workspace @fluentui/react-text build:local

After:
yarn workspace @fluentui/react-text generate-api

Related Issue(s)

Follows #25575
Replaces #25319

@Hotell Hotell mentioned this pull request Nov 10, 2022
Merged
1 task
@Hotell Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 10, 2022
@size-auditor
Copy link

size-auditor bot commented Nov 10, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 06d0d5598c28ac70e07d9b9e7d1b77151369d193 (build)

@Hotell Hotell force-pushed the hotell/build/api-generation-migration branch from ad01e37 to 7b9a09f Compare November 10, 2022 11:52
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 10, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 3.153 kB
1.299 kB
react-accordion
Accordion (including children components)		 79.284 kB
24.446 kB
react-alert
Alert		 86.986 kB
21.736 kB
react-avatar
Avatar		 51.171 kB
14.313 kB
react-avatar
AvatarGroup		 14.996 kB
6.013 kB
react-avatar
AvatarGroupItem		 65.749 kB
18.412 kB
react-badge
Badge		 22.646 kB
7.228 kB
react-badge
CounterBadge		 23.536 kB
7.512 kB
react-badge
PresenceBadge		 24.096 kB
7.09 kB
react-button
Button		 36.85 kB
9.917 kB
react-button
CompoundButton		 43.875 kB
11.134 kB
react-button
MenuButton		 41.527 kB
11.19 kB
react-button
SplitButton		 48.973 kB
12.592 kB
react-button
ToggleButton		 52.675 kB
11.418 kB
react-card
Card - All		 71.863 kB
20.939 kB
react-card
Card		 67.641 kB
19.897 kB
react-card
CardFooter		 8.607 kB
3.622 kB
react-card
CardHeader		 9.782 kB
3.998 kB
react-card
CardPreview		 8.708 kB
3.678 kB
react-combobox
Combobox (including child components)		 78.076 kB
24.991 kB
react-combobox
Dropdown (including child components)		 77.363 kB
24.893 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 62.941 kB
17.678 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.948 kB
52.991 kB
react-components
react-components: FluentProvider & webLightTheme		 33.446 kB
11.033 kB
react-dialog
Dialog (including children components)		 83.147 kB
24.799 kB
react-divider
Divider		 16.505 kB
5.925 kB
react-image
Image		 10.826 kB
4.286 kB
react-infobutton
InfoButton		 117.928 kB
35.402 kB
react-input
Input		 24.112 kB
7.892 kB
react-label
Label		 9.384 kB
3.883 kB
react-link
Link		 11.852 kB
4.888 kB
react-menu
Menu (including children components)		 117.131 kB
36.2 kB
react-menu
Menu (including selectable components)		 120.2 kB
36.726 kB
react-overflow
hooks only		 11.004 kB
4.188 kB
react-persona
Persona		 56.289 kB
15.712 kB
react-popover
Popover		 103.672 kB
31.871 kB
react-portal
Portal		 10.495 kB
3.851 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.826 kB
7.417 kB
react-progress
Progress		 13.526 kB
5.113 kB
react-provider
FluentProvider		 15.807 kB
5.909 kB
react-radio
Radio		 36.436 kB
12.126 kB
react-radio
RadioGroup		 14.294 kB
5.723 kB
react-select
Select		 23.428 kB
8.023 kB
react-slider
Slider		 32.108 kB
10.195 kB
react-spinbutton
SpinButton		 44.42 kB
12.815 kB
react-spinner
Spinner		 20.003 kB
6.449 kB
react-switch
Switch		 33.443 kB
10.585 kB
react-text
Text - Default		 11.828 kB
4.627 kB
react-text
Text - Wrappers		 15.138 kB
5.064 kB
react-textarea
Textarea		 25.687 kB
8.331 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.65 kB
6.444 kB
react-theme
Teams: Light theme		 17.486 kB
5.057 kB
react-tooltip
Tooltip		 42.032 kB
14.739 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 06d0d5598c28ac70e07d9b9e7d1b77151369d193

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 10, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1260 1293 5000
Button mount 925 924 5000
FluentProvider mount 1500 1497 5000
FluentProviderWithTheme mount 570 580 10
FluentProviderWithTheme virtual-rerender 540 534 10
FluentProviderWithTheme virtual-rerender-with-unmount 582 583 10
MakeStyles mount 1969 1972 50000
SpinButton mount 2337 2336 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 10, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 132 119 1.11:1
ChatDuplicateMessagesPerf.default 223 206 1.08:1
ChatMinimalPerf.default 655 615 1.07:1
VideoMinimalPerf.default 620 578 1.07:1
AttachmentMinimalPerf.default 132 125 1.06:1
DropdownManyItemsPerf.default 553 529 1.05:1
FlexMinimalPerf.default 258 245 1.05:1
LayoutMinimalPerf.default 326 311 1.05:1
RadioGroupMinimalPerf.default 408 390 1.05:1
CarouselMinimalPerf.default 363 349 1.04:1
FormMinimalPerf.default 340 328 1.04:1
TooltipMinimalPerf.default 1901 1827 1.04:1
CardMinimalPerf.default 477 464 1.03:1
HeaderMinimalPerf.default 320 310 1.03:1
PopupMinimalPerf.default 572 557 1.03:1
StatusMinimalPerf.default 625 605 1.03:1
AttachmentSlotsPerf.default 882 866 1.02:1
BoxMinimalPerf.default 302 296 1.02:1
ButtonMinimalPerf.default 138 135 1.02:1
ItemLayoutMinimalPerf.default 985 965 1.02:1
ListWith60ListItems.default 489 480 1.02:1
RosterPerf.default 1742 1710 1.02:1
SegmentMinimalPerf.default 306 300 1.02:1
SkeletonMinimalPerf.default 304 297 1.02:1
TextAreaMinimalPerf.default 413 403 1.02:1
AvatarMinimalPerf.default 165 164 1.01:1
CheckboxMinimalPerf.default 1550 1533 1.01:1
DropdownMinimalPerf.default 2185 2154 1.01:1
HeaderSlotsPerf.default 690 681 1.01:1
LabelMinimalPerf.default 342 338 1.01:1
ListNestedPerf.default 473 469 1.01:1
MenuButtonMinimalPerf.default 1358 1348 1.01:1
ProviderMergeThemesPerf.default 997 990 1.01:1
SplitButtonMinimalPerf.default 3325 3287 1.01:1
TextMinimalPerf.default 301 297 1.01:1
CustomToolbarPrototype.default 2191 2170 1.01:1
TreeMinimalPerf.default 712 703 1.01:1
ButtonOverridesMissPerf.default 1019 1017 1:1
DialogMinimalPerf.default 690 688 1:1
EmbedMinimalPerf.default 2662 2662 1:1
ImageMinimalPerf.default 336 335 1:1
InputMinimalPerf.default 850 852 1:1
PortalMinimalPerf.default 138 138 1:1
ReactionMinimalPerf.default 328 327 1:1
TableManyItemsPerf.default 1582 1577 1:1
TableMinimalPerf.default 358 357 1:1
ToolbarMinimalPerf.default 793 790 1:1
AnimationMinimalPerf.default 467 471 0.99:1
DatepickerMinimalPerf.default 4670 4695 0.99:1
MenuMinimalPerf.default 737 741 0.99:1
ProviderMinimalPerf.default 317 319 0.99:1
RefMinimalPerf.default 186 187 0.99:1
SliderMinimalPerf.default 1238 1247 0.99:1
ListCommonPerf.default 521 530 0.98:1
ListMinimalPerf.default 448 457 0.98:1
IconMinimalPerf.default 557 570 0.98:1
ButtonSlotsPerf.default 417 429 0.97:1
ChatWithPopoverPerf.default 286 298 0.96:1
DividerMinimalPerf.default 304 316 0.96:1
GridMinimalPerf.default 286 297 0.96:1
LoaderMinimalPerf.default 257 267 0.96:1
AlertMinimalPerf.default 217 229 0.95:1
TreeWith60ListItems.default 126 134 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 10, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1212 1204 5000
Breadcrumb mount 2865 2857 1000
Checkbox mount 2678 2664 5000
CheckboxBase mount 2406 2385 5000
ChoiceGroup mount 4284 4352 5000
ComboBox mount 1242 1214 1000
CommandBar mount 9485 9520 1000
ContextualMenu mount 10966 11028 1000
DefaultButton mount 1376 1391 5000
DetailsRow mount 3371 3421 5000
DetailsRowFast mount 3402 3381 5000
DetailsRowNoStyles mount 3296 3269 5000
Dialog mount 3006 2983 1000
DocumentCardTitle mount 582 594 1000
Dropdown mount 3183 3199 5000
FocusTrapZone mount 1968 1942 5000
FocusZone mount 1965 1921 5000
GroupedList mount 1857 2087 2
GroupedList virtual-rerender 1117 1112 2
GroupedList virtual-rerender-with-unmount 1661 1651 2
GroupedListV2 mount 577 568 2
GroupedListV2 virtual-rerender 551 550 2
GroupedListV2 virtual-rerender-with-unmount 572 581 2
IconButton mount 1809 1809 5000
Label mount 761 761 5000
Layer mount 4213 4244 5000
Link mount 838 860 5000
MenuButton mount 1603 1616 5000
MessageBar mount 2336 2370 5000
Nav mount 3106 3089 1000
OverflowSet mount 1420 1405 5000
Panel mount 2501 2483 1000
Persona mount 1262 1280 1000
Pivot mount 1621 1543 1000
PrimaryButton mount 1508 1487 5000
Rating mount 6999 7049 5000
SearchBox mount 1503 1508 5000
Shimmer mount 2976 2959 5000
Slider mount 2126 2064 5000
SpinButton mount 4346 4273 5000
Spinner mount 826 825 5000
SplitButton mount 2850 2865 5000
Stack mount 870 868 5000
StackWithIntrinsicChildren mount 2370 2335 5000
StackWithTextChildren mount 5043 5053 5000
SwatchColorPicker mount 9654 9584 5000
TagPicker mount 2373 2372 5000
TeachingBubble mount 82320 82263 5000
Text mount 828 827 5000
TextField mount 1535 1560 5000
ThemeProvider mount 1448 1460 5000
ThemeProvider virtual-rerender 1136 1140 5000
ThemeProvider virtual-rerender-with-unmount 2014 2011 5000
Toggle mount 1148 1129 5000
buttonNative mount 529 541 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 10, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42e63b3:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@Hotell Hotell marked this pull request as ready for review November 11, 2022 12:55
@Hotell Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 11, 2022
@Hotell Hotell force-pushed the hotell/build/api-generation-migration branch from 7b9a09f to 42e63b3 Compare November 11, 2022 18:19
spmonahan
spmonahan approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@spmonahan spmonahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Input and SpinButton.

@Hotell Hotell merged commit ea76850 into microsoft:master Nov 15, 2022
@Hotell Hotell deleted the hotell/build/api-generation-migration branch November 15, 2022 12:57
@Hotell Hotell mentioned this pull request Nov 15, 2022
Merged
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@Hotell @NotWoods
chore: migrate all packages to generate-api approach with unified tsc…
58011ff 
… processing (microsoft#25609)
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
@Hotell
chore: migrate all packages to generate-api approach with unified tsc…
0a6cdd7 
… processing (microsoft#25609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsunderhus bsunderhus bsunderhus approved these changes

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@miroslavstastny miroslavstastny miroslavstastny approved these changes

@spmonahan spmonahan spmonahan approved these changes

@tudorpopams tudorpopams tudorpopams approved these changes

@sopranopillow sopranopillow Awaiting requested review from sopranopillow

@tomi-msft tomi-msft Awaiting requested review from tomi-msft

@chpalac chpalac Awaiting requested review from chpalac

@behowell behowell Awaiting requested review from behowell

@khmakoto khmakoto Awaiting requested review from khmakoto

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

@smhigley smhigley Awaiting requested review from smhigley

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Build System Fluent UI react-components (v9)

Projects

None yet

Milestone

October Project Cycle Q4 2022

Development

Successfully merging this pull request may close these issues.

9 participants

@Hotell @fabricteam @bsunderhus @TristanWatanabe @miroslavstastny @ling1726 @spmonahan @tudorpopams @smhigley