chore(vr-tests-v9): Convert Card VR tests to CSF#25526
Merged
TristanWatanabe merged 6 commits intomicrosoft:masterfrom Nov 16, 2022
Merged
chore(vr-tests-v9): Convert Card VR tests to CSF#25526TristanWatanabe merged 6 commits intomicrosoft:masterfrom
TristanWatanabe merged 6 commits intomicrosoft:masterfrom
Conversation
27 tasks
Collaborator
📊 Bundle size report🤖 This report was generated against e22929a533e0830fc75e547b733b38dee60af00e |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 38cbc51623baf411e5379936c050f0b2c53ecc54 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2e9d455:
|
Member
Author
|
Screener change seems to be a minor crop issue caused by the usage of the |
marcosmoura
approved these changes
Nov 10, 2022
marcosmoura
approved these changes
Nov 16, 2022
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* chore: convert card stories to csf * nit: remove unused import * convert CardSelectable stories to CSF * fix asset url * fix: delete old story file * Add side margins to Appearance stories
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* chore: convert card stories to csf * nit: remove unused import * convert CardSelectable stories to CSF * fix asset url * fix: delete old story file * Add side margins to Appearance stories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
storiesOfstories to CSF:npx sb migrate storiesof-to-csf --glob="apps/vr-tests-react-components/src/stories/{ComponentName}/*.stories.tsx"getStoryVariantfunction.Follows pattern set in #25108.
Related Issue(s)
Part of #25078