fix: Menu trigger should be focused when dismissed on menuitem click#25289
Merged
ling1726 merged 6 commits intomicrosoft:masterfrom Oct 19, 2022
Merged
fix: Menu trigger should be focused when dismissed on menuitem click#25289ling1726 merged 6 commits intomicrosoft:masterfrom
ling1726 merged 6 commits intomicrosoft:masterfrom
Conversation
Replaces `shouldHandleKeyboardRef` with `shouldHandlCloseRef` so that mouse and keyboard click are handled the same way.
ling1726
commented
Oct 19, 2022
bsunderhus
approved these changes
Oct 19, 2022
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 643aff32bdf62c90367408c060e24b92c6005380 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1530 | 1588 | 5000 | |
| Button | mount | 1115 | 1146 | 5000 | |
| FluentProvider | mount | 1911 | 1877 | 5000 | |
| FluentProviderWithTheme | mount | 771 | 754 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 706 | 703 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 743 | 763 | 10 | |
| MakeStyles | mount | 2255 | 2267 | 50000 | |
| SpinButton | mount | 3026 | 2986 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d2f1cef:
|
44fece2 to
31ab432
Compare
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…icrosoft#25289) * fix: Menu trigger should be focused when dismissed on menuitem click Replaces `shouldHandleKeyboardRef` with `shouldHandlCloseRef` so that mouse and keyboard click are handled the same way. * changefiles * revert overflow changes * update change file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldHandleKeyboardRefwithshouldHandlCloseRefso that mouse and keyboard click are handled the same way.Fixes #24680