chore: scaffold react-tree package by bsunderhus · Pull Request #25267 · microsoft/fluentui

bsunderhus · 2022-10-18T10:51:31Z

Scaffolds `@fluentui/react-tree` package

Scaffold new package for the implementation of the TreeView widget compliant component(s).

Scaffolding tool used:

yarn create-package

fabricteam · 2022-10-18T11:04:38Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1290	1295	5000
Button	mount	947	951	5000
FluentProvider	mount	1560	1574	5000
FluentProviderWithTheme	mount	629	635	10
FluentProviderWithTheme	virtual-rerender	583	592	10
FluentProviderWithTheme	virtual-rerender-with-unmount	621	621	10
MakeStyles	mount	1909	1917	50000
SpinButton	mount	2539	2571	5000

size-auditor · 2022-10-18T11:04:40Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5280dfeda349453f42b51ae49c9d128bc322c609 (build)

codesandbox-ci · 2022-10-18T11:05:04Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f6123dd:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-10-18T11:11:09Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ChatDuplicateMessagesPerf.default	281	228	1.23:1
GridMinimalPerf.default	295	240	1.23:1
LayoutMinimalPerf.default	294	246	1.2:1
TextMinimalPerf.default	289	248	1.17:1
ListWith60ListItems.default	512	451	1.14:1
AttachmentMinimalPerf.default	123	109	1.13:1
ChatWithPopoverPerf.default	314	277	1.13:1
PopupMinimalPerf.default	537	481	1.12:1
PortalMinimalPerf.default	145	129	1.12:1
SkeletonMinimalPerf.default	273	245	1.11:1
AccordionMinimalPerf.default	118	107	1.1:1
TableManyItemsPerf.default	1540	1396	1.1:1
ButtonSlotsPerf.default	451	414	1.09:1
DropdownMinimalPerf.default	2215	2023	1.09:1
VideoMinimalPerf.default	581	534	1.09:1
AvatarMinimalPerf.default	145	134	1.08:1
HeaderSlotsPerf.default	587	543	1.08:1
MenuMinimalPerf.default	702	649	1.08:1
ProviderMergeThemesPerf.default	1063	996	1.07:1
RadioGroupMinimalPerf.default	341	318	1.07:1
AttachmentSlotsPerf.default	956	900	1.06:1
TableMinimalPerf.default	310	295	1.05:1
ButtonMinimalPerf.default	121	116	1.04:1
AlertMinimalPerf.default	218	212	1.03:1
ListCommonPerf.default	530	514	1.03:1
SplitButtonMinimalPerf.default	3522	3411	1.03:1
TextAreaMinimalPerf.default	380	369	1.03:1
CarouselMinimalPerf.default	382	376	1.02:1
RosterPerf.default	1738	1712	1.02:1
ReactionMinimalPerf.default	311	304	1.02:1
StatusMinimalPerf.default	496	485	1.02:1
InputMinimalPerf.default	851	841	1.01:1
TreeWith60ListItems.default	128	127	1.01:1
CheckboxMinimalPerf.default	1553	1550	1:1
LoaderMinimalPerf.default	483	484	1:1
SliderMinimalPerf.default	1319	1313	1:1
LabelMinimalPerf.default	272	276	0.99:1
CustomToolbarPrototype.default	2218	2251	0.99:1
ToolbarMinimalPerf.default	762	772	0.99:1
ButtonOverridesMissPerf.default	1049	1075	0.98:1
TooltipMinimalPerf.default	1852	1882	0.98:1
AnimationMinimalPerf.default	382	395	0.97:1
DatepickerMinimalPerf.default	4944	5119	0.97:1
IconMinimalPerf.default	522	536	0.97:1
TreeMinimalPerf.default	603	624	0.97:1
BoxMinimalPerf.default	268	279	0.96:1
EmbedMinimalPerf.default	2869	2982	0.96:1
ItemLayoutMinimalPerf.default	863	900	0.96:1
ListMinimalPerf.default	399	417	0.96:1
MenuButtonMinimalPerf.default	1329	1408	0.94:1
RefMinimalPerf.default	161	171	0.94:1
ChatMinimalPerf.default	550	593	0.93:1
DividerMinimalPerf.default	266	290	0.92:1
FormMinimalPerf.default	283	308	0.92:1
DropdownManyItemsPerf.default	484	533	0.91:1
ListNestedPerf.default	406	448	0.91:1
HeaderMinimalPerf.default	260	290	0.9:1
ImageMinimalPerf.default	282	318	0.89:1
CardMinimalPerf.default	384	434	0.88:1
DialogMinimalPerf.default	572	649	0.88:1
SegmentMinimalPerf.default	251	287	0.87:1
FlexMinimalPerf.default	197	229	0.86:1
ProviderMinimalPerf.default	332	588	0.56:1

fabricteam · 2022-10-18T11:11:39Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.083 kB` `24.079 kB`
`react-alert` Alert	`84.688 kB` `21.233 kB`
`react-avatar` Avatar	`48.874 kB` `13.864 kB`
`react-avatar` AvatarGroup	`14.996 kB` `6.013 kB`
`react-avatar` AvatarGroupItem	`68.842 kB` `19.205 kB`
`react-badge` Badge	`22.646 kB` `7.228 kB`
`react-badge` CounterBadge	`23.536 kB` `7.512 kB`
`react-badge` PresenceBadge	`24.096 kB` `7.09 kB`
`react-button` Button	`36.849 kB` `9.907 kB`
`react-button` CompoundButton	`43.874 kB` `11.123 kB`
`react-button` MenuButton	`39.543 kB` `10.807 kB`
`react-button` SplitButton	`46.989 kB` `12.192 kB`
`react-button` ToggleButton	`52.716 kB` `11.381 kB`
`react-card` Card - All	`67.216 kB` `19.304 kB`
`react-card` Card	`62.898 kB` `18.22 kB`
`react-card` CardFooter	`8.607 kB` `3.622 kB`
`react-card` CardHeader	`9.65 kB` `3.962 kB`
`react-card` CardPreview	`8.708 kB` `3.678 kB`
`react-combobox` Combobox (including child components)	`75.85 kB` `24.632 kB`
`react-combobox` Dropdown (including child components)	`75.579 kB` `24.594 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`62.94 kB` `17.663 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`189.488 kB` `52.587 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.446 kB` `11.033 kB`
`react-dialog` Dialog (including children components)	`82.626 kB` `24.504 kB`
`react-divider` Divider	`16.505 kB` `5.925 kB`
`react-image` Image	`10.826 kB` `4.286 kB`
`react-infobutton` InfoButton	`7.742 kB` `3.265 kB`
`react-input` Input	`24.428 kB` `7.899 kB`
`react-label` Label	`9.384 kB` `3.883 kB`
`react-link` Link	`11.852 kB` `4.888 kB`
`react-menu` Menu (including children components)	`116.668 kB` `35.792 kB`
`react-menu` Menu (including selectable components)	`119.737 kB` `36.316 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`53.992 kB` `15.25 kB`
`react-popover` Popover	`102.864 kB` `31.542 kB`
`react-portal` Portal	`10.628 kB` `3.899 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.724 kB` `7.415 kB`
`react-progress` Progress	`12.789 kB` `4.927 kB`
`react-provider` FluentProvider	`15.807 kB` `5.909 kB`
`react-radio` Radio	`36.436 kB` `12.126 kB`
`react-radio` RadioGroup	`14.294 kB` `5.723 kB`
`react-select` Select	`21.61 kB` `7.568 kB`
`react-slider` Slider	`31.805 kB` `10.085 kB`
`react-spinbutton` SpinButton	`45.541 kB` `12.758 kB`
`react-spinner` Spinner	`20.023 kB` `6.461 kB`
`react-switch` Switch	`33.388 kB` `10.578 kB`
`react-text` Text - Default	`11.828 kB` `4.627 kB`
`react-text` Text - Wrappers	`15.138 kB` `5.064 kB`
`react-textarea` Textarea	`25.687 kB` `8.331 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`41.718 kB` `14.687 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 5280dfeda349453f42b51ae49c9d128bc322c609}

fabricteam · 2022-10-18T11:28:35Z

Perf Analysis (`@fluentui/react`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FocusZone	mount	1938	1943	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
BaseButton	mount	1184	1201	5000
Breadcrumb	mount	2774	2827	1000
Checkbox	mount	2643	2629	5000
CheckboxBase	mount	2347	2347	5000
ChoiceGroup	mount	4236	4269	5000
ComboBox	mount	1191	1160	1000
CommandBar	mount	9334	9274	1000
ContextualMenu	mount	10297	10617	1000
DefaultButton	mount	1370	1352	5000
DetailsRow	mount	3445	3418	5000
DetailsRowFast	mount	3414	3443	5000
DetailsRowNoStyles	mount	3295	3270	5000
Dialog	mount	2942	2940	1000
DocumentCardTitle	mount	582	582	1000
Dropdown	mount	3171	3148	5000
FocusTrapZone	mount	1954	2004	5000
FocusZone	mount	1938	1943	5000	Possible regression
GroupedList	mount	48775	54312	2
GroupedList	virtual-rerender	23411	23620	2
GroupedList	virtual-rerender-with-unmount	82396	82545	2
GroupedListV2	mount	565	549	2
GroupedListV2	virtual-rerender	531	528	2
GroupedListV2	virtual-rerender-with-unmount	552	582	2
IconButton	mount	1800	1805	5000
Label	mount	755	766	5000
Layer	mount	4140	4109	5000
Link	mount	863	844	5000
MenuButton	mount	1622	1625	5000
MessageBar	mount	2358	2359	5000
Nav	mount	3081	3354	1000
OverflowSet	mount	1418	1418	5000
Panel	mount	2578	2533	1000
Persona	mount	1245	1267	1000
Pivot	mount	1532	1521	1000
PrimaryButton	mount	1486	1480	5000
Rating	mount	7043	7024	5000
SearchBox	mount	1502	1521	5000
Shimmer	mount	2934	2916	5000
Slider	mount	2117	2103	5000
SpinButton	mount	4338	4307	5000
Spinner	mount	842	851	5000
SplitButton	mount	2869	2843	5000
Stack	mount	901	907	5000
StackWithIntrinsicChildren	mount	2271	2294	5000
StackWithTextChildren	mount	4922	4935	5000
SwatchColorPicker	mount	9604	9466	5000
TagPicker	mount	2336	2348	5000
TeachingBubble	mount	79404	78874	5000
Text	mount	828	813	5000
TextField	mount	1549	1584	5000
ThemeProvider	mount	1443	1462	5000
ThemeProvider	virtual-rerender	1162	1144	5000
ThemeProvider	virtual-rerender-with-unmount	1991	2007	5000
Toggle	mount	1125	1135	5000
buttonNative	mount	540	539	5000

bsunderhus added Fluent UI react-components (v9) Component: Tree labels Oct 18, 2022

bsunderhus self-assigned this Oct 18, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Oct 18, 2022

bsunderhus mentioned this pull request Oct 18, 2022

Tree #25266

Closed

22 tasks

chore: scaffold react-tree package

f6123dd

bsunderhus force-pushed the react-tree/scaffold branch from 5a7336e to f6123dd Compare October 18, 2022 10:52

bsunderhus marked this pull request as ready for review October 18, 2022 11:25

bsunderhus requested review from a team, JustSlone and jurokapsiar as code owners October 18, 2022 11:25

JustSlone approved these changes Oct 18, 2022

View reviewed changes

Hotell approved these changes Oct 18, 2022

View reviewed changes

bsunderhus merged commit 4535a21 into microsoft:master Oct 19, 2022

bsunderhus deleted the react-tree/scaffold branch October 19, 2022 08:00

NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022

chore: scaffold react-tree package (microsoft#25267)

68d8a1f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: scaffold react-tree package#25267

chore: scaffold react-tree package#25267
bsunderhus merged 1 commit intomicrosoft:masterfrom
bsunderhus:react-tree/scaffold

bsunderhus commented Oct 18, 2022 •

edited

Loading

Uh oh!

fabricteam commented Oct 18, 2022

Uh oh!

size-auditor bot commented Oct 18, 2022

Uh oh!

codesandbox-ci bot commented Oct 18, 2022

Uh oh!

fabricteam commented Oct 18, 2022

Uh oh!

fabricteam commented Oct 18, 2022

Uh oh!

fabricteam commented Oct 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bsunderhus commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scaffolds @fluentui/react-tree package

Uh oh!

fabricteam commented Oct 18, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor bot commented Oct 18, 2022

Asset size changes

Uh oh!

codesandbox-ci bot commented Oct 18, 2022

Uh oh!

fabricteam commented Oct 18, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Oct 18, 2022

📊 Bundle size report

Uh oh!

fabricteam commented Oct 18, 2022

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bsunderhus commented Oct 18, 2022 •

edited

Loading

Scaffolds `@fluentui/react-tree` package

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)