feat: Add red border to form controls when aria-invalid is set#25252
Merged
behowell merged 17 commits intomicrosoft:masterfrom Oct 17, 2022
Merged
feat: Add red border to form controls when aria-invalid is set#25252behowell merged 17 commits intomicrosoft:masterfrom
behowell merged 17 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5e9d7c3:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1334 | 1293 | 5000 | |
| Button | mount | 949 | 956 | 5000 | |
| FluentProvider | mount | 1569 | 1590 | 5000 | |
| FluentProviderWithTheme | mount | 633 | 643 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 602 | 592 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 635 | 645 | 10 | |
| MakeStyles | mount | 1921 | 1934 | 50000 | |
| SpinButton | mount | 2577 | 2557 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 21e5ce216620a11db2aeed0f3b3ecfdb9d61809a (build) |
This was referenced Oct 15, 2022
spmonahan
approved these changes
Oct 17, 2022
spmonahan
approved these changes
Oct 17, 2022
micahgodbolt
approved these changes
Oct 17, 2022
sopranopillow
approved these changes
Oct 17, 2022
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…soft#25252) Change the border to be red when `aria-invalid` is set for: `Combobox`, `Dropdown`, `Input`, `Select`, `SpinButton`, and `Textarea`. This also results in the border being red on the field versions of these controls when `validationState="error"`, because Field sets `aria-invalid` in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
Change the border to be red when
aria-invalidis set for:Combobox,Dropdown,Input,Select,SpinButton, andTextarea.This also results in the border being red on the field versions of these controls when
validationState="error", because Field setsaria-invalidin that case.For background on the reasoning why we're using the aria-invalid prop, see this discussion thread: #25225 (comment)
Related Issue(s)