Skip to content

feat(scripts): enable strict checking for additional sub-folders(packages) v3#25074

Merged
Hotell merged 9 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v3
Oct 11, 2022
Merged

feat(scripts): enable strict checking for additional sub-folders(packages) v3#25074
Hotell merged 9 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v3

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 4, 2022 •
edited
Loading

Description

  • adds more scripts subfolders to ts-solution config and fixes types/logic (please check commit messages for more info)
  • applies single version policy some packages that are used in affected sub-folders

Related Issue(s)

Fixes partially #24349

@github-actions github-actions bot added this to the October Project Cycle Q4 2022 milestone Oct 4, 2022
@Hotell Hotell mentioned this pull request Oct 4, 2022
Closed
18 tasks
Hotell
Hotell commented Oct 4, 2022
View reviewed changes
scripts/package.json
"connect-history-api-fallback": "^1.3.0",
"doctoc": "^2.0.1",
"doctrine": "^3.0.0",
"dotparser": "^1.0.0",
Copy link
Contributor Author

@Hotell Hotell Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to root package.json (single version policy)

@size-auditor
Copy link

size-auditor bot commented Oct 4, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0a36b540acac5eca7081a8aa479ca2a07708eb2b (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 4, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3388983:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 4, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1315 1331 5000
Button mount 959 946 5000
FluentProvider mount 1564 1577 5000
FluentProviderWithTheme mount 622 629 10
FluentProviderWithTheme virtual-rerender 584 597 10
FluentProviderWithTheme virtual-rerender-with-unmount 629 631 10
MakeStyles mount 1907 1897 50000
SpinButton mount 2488 2512 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 4, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 79.037 kB
24.059 kB
react-alert
Alert		 84.117 kB
21.07 kB
react-avatar
Avatar		 48.828 kB
13.842 kB
react-avatar
AvatarGroup		 14.95 kB
5.989 kB
react-avatar
AvatarGroupItem		 68.796 kB
19.182 kB
react-badge
Badge		 22.6 kB
7.205 kB
react-badge
CounterBadge		 23.49 kB
7.489 kB
react-badge
PresenceBadge		 24.05 kB
7.067 kB
react-button
Button		 36.278 kB
9.636 kB
react-button
CompoundButton		 43.303 kB
10.852 kB
react-button
MenuButton		 38.972 kB
10.536 kB
react-button
SplitButton		 46.418 kB
11.916 kB
react-button
ToggleButton		 52.145 kB
11.108 kB
react-card
Card - All		 67.17 kB
19.281 kB
react-card
Card		 62.852 kB
18.198 kB
react-card
CardFooter		 8.561 kB
3.601 kB
react-card
CardHeader		 9.604 kB
3.94 kB
react-card
CardPreview		 8.662 kB
3.656 kB
react-combobox
Combobox (including child components)		 74.642 kB
24.19 kB
react-combobox
Dropdown (including child components)		 74.242 kB
24.089 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.209 kB
52.401 kB
react-components
react-components: FluentProvider & webLightTheme		 33.4 kB
11.008 kB
react-dialog
Dialog (including children components)		 82.438 kB
24.444 kB
react-divider
Divider		 16.459 kB
5.902 kB
react-image
Image		 10.78 kB
4.264 kB
react-input
Input		 23.762 kB
7.706 kB
react-label
Label		 9.338 kB
3.86 kB
react-link
Link		 11.806 kB
4.868 kB
react-menu
Menu (including children components)		 116.771 kB
35.786 kB
react-menu
Menu (including selectable components)		 119.84 kB
36.296 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-persona
Persona		 53.946 kB
15.225 kB
react-popover
Popover		 102.929 kB
31.542 kB
react-portal
Portal		 10.582 kB
3.875 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-progress
Progress		 13.44 kB
5.247 kB
react-provider
FluentProvider		 15.761 kB
5.885 kB
react-radio
Radio		 36.39 kB
12.103 kB
react-radio
RadioGroup		 14.248 kB
5.7 kB
react-select
Select		 20.846 kB
7.346 kB
react-slider
Slider		 31.759 kB
10.064 kB
react-spinbutton
SpinButton		 44.102 kB
12.425 kB
react-spinner
Spinner		 19.977 kB
6.438 kB
react-switch
Switch		 33.342 kB
10.557 kB
react-text
Text - Default		 11.782 kB
4.605 kB
react-text
Text - Wrappers		 15.092 kB
5.044 kB
react-textarea
Textarea		 25.018 kB
8.133 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.65 kB
6.444 kB
react-theme
Teams: Light theme		 17.486 kB
5.057 kB
react-tooltip
Tooltip		 41.541 kB
14.646 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 0a36b540acac5eca7081a8aa479ca2a07708eb2b

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 4, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CarouselMinimalPerf.default 389 359 1.08:1
ListMinimalPerf.default 439 415 1.06:1
DividerMinimalPerf.default 297 283 1.05:1
SkeletonMinimalPerf.default 291 277 1.05:1
TreeWith60ListItems.default 139 133 1.05:1
AccordionMinimalPerf.default 118 113 1.04:1
ChatDuplicateMessagesPerf.default 237 228 1.04:1
FlexMinimalPerf.default 233 224 1.04:1
GridMinimalPerf.default 273 263 1.04:1
PortalMinimalPerf.default 147 141 1.04:1
SegmentMinimalPerf.default 287 275 1.04:1
AttachmentSlotsPerf.default 916 890 1.03:1
AvatarMinimalPerf.default 151 147 1.03:1
HeaderSlotsPerf.default 629 613 1.03:1
LabelMinimalPerf.default 318 308 1.03:1
LayoutMinimalPerf.default 293 284 1.03:1
ButtonMinimalPerf.default 134 131 1.02:1
ChatMinimalPerf.default 598 588 1.02:1
ChatWithPopoverPerf.default 305 298 1.02:1
DropdownManyItemsPerf.default 555 546 1.02:1
ImageMinimalPerf.default 312 305 1.02:1
MenuMinimalPerf.default 707 694 1.02:1
MenuButtonMinimalPerf.default 1423 1397 1.02:1
ProviderMinimalPerf.default 342 335 1.02:1
TableManyItemsPerf.default 1559 1534 1.02:1
ToolbarMinimalPerf.default 769 754 1.02:1
AlertMinimalPerf.default 217 215 1.01:1
AnimationMinimalPerf.default 441 436 1.01:1
ButtonOverridesMissPerf.default 1094 1086 1.01:1
ButtonSlotsPerf.default 454 448 1.01:1
CheckboxMinimalPerf.default 1736 1714 1.01:1
DialogMinimalPerf.default 644 635 1.01:1
HeaderMinimalPerf.default 295 291 1.01:1
LoaderMinimalPerf.default 549 543 1.01:1
SliderMinimalPerf.default 1324 1311 1.01:1
TableMinimalPerf.default 326 324 1.01:1
TreeMinimalPerf.default 666 661 1.01:1
AttachmentMinimalPerf.default 119 119 1:1
BoxMinimalPerf.default 277 276 1:1
CardMinimalPerf.default 435 433 1:1
DropdownMinimalPerf.default 2239 2248 1:1
EmbedMinimalPerf.default 3044 3038 1:1
FormMinimalPerf.default 305 304 1:1
InputMinimalPerf.default 942 941 1:1
ItemLayoutMinimalPerf.default 961 958 1:1
ListNestedPerf.default 450 452 1:1
PopupMinimalPerf.default 527 529 1:1
ProviderMergeThemesPerf.default 1066 1062 1:1
ReactionMinimalPerf.default 306 306 1:1
SplitButtonMinimalPerf.default 3635 3628 1:1
IconMinimalPerf.default 543 541 1:1
DatepickerMinimalPerf.default 4840 4874 0.99:1
RadioGroupMinimalPerf.default 361 365 0.99:1
RefMinimalPerf.default 173 174 0.99:1
CustomToolbarPrototype.default 2241 2256 0.99:1
RosterPerf.default 1742 1783 0.98:1
StatusMinimalPerf.default 550 561 0.98:1
ListCommonPerf.default 510 526 0.97:1
ListWith60ListItems.default 502 515 0.97:1
TooltipMinimalPerf.default 1934 1985 0.97:1
VideoMinimalPerf.default 603 621 0.97:1
TextMinimalPerf.default 268 282 0.95:1
TextAreaMinimalPerf.default 380 404 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 4, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1181 1193 5000
Breadcrumb mount 2954 2904 1000
Checkbox mount 2622 2661 5000
CheckboxBase mount 2351 2353 5000
ChoiceGroup mount 4416 4403 5000
ComboBox mount 1263 1218 1000
CommandBar mount 9517 9533 1000
ContextualMenu mount 11117 11005 1000
DefaultButton mount 1360 1405 5000
DetailsRow mount 3660 3567 5000
DetailsRowFast mount 3639 3620 5000
DetailsRowNoStyles mount 3478 3472 5000
Dialog mount 3087 3090 1000
DocumentCardTitle mount 573 570 1000
Dropdown mount 3230 3219 5000
FocusTrapZone mount 2037 1989 5000
FocusZone mount 1966 1972 5000
GroupedList mount 53702 60466 2
GroupedList virtual-rerender 25075 25138 2
GroupedList virtual-rerender-with-unmount 92963 95349 2
GroupedListV2 mount 556 569 2
GroupedListV2 virtual-rerender 543 529 2
GroupedListV2 virtual-rerender-with-unmount 566 570 2
IconButton mount 1904 1891 5000
Label mount 742 720 5000
Layer mount 4254 4264 5000
Link mount 834 829 5000
MenuButton mount 1686 1691 5000
MessageBar mount 2346 2346 5000
Nav mount 3268 3290 1000
OverflowSet mount 1355 1355 5000
Panel mount 2571 2564 1000
Persona mount 1269 1267 1000
Pivot mount 1638 1668 1000
PrimaryButton mount 1535 1539 5000
Rating mount 7008 6991 5000
SearchBox mount 1546 1522 5000
Shimmer mount 2876 2865 5000
Slider mount 2104 2085 5000
SpinButton mount 4672 4661 5000
Spinner mount 811 801 5000
SplitButton mount 3088 3090 5000
Stack mount 869 870 5000
StackWithIntrinsicChildren mount 2349 2335 5000
StackWithTextChildren mount 4802 4782 5000
SwatchColorPicker mount 10583 10537 5000
TagPicker mount 2644 2622 5000
TeachingBubble mount 85568 86087 5000
Text mount 781 790 5000
TextField mount 1614 1606 5000
ThemeProvider mount 1526 1502 5000
ThemeProvider virtual-rerender 1067 1091 5000
ThemeProvider virtual-rerender-with-unmount 2177 2155 5000
Toggle mount 1101 1129 5000
buttonNative mount 547 560 5000

@Hotell Hotell force-pushed the hotell/build/scripts/ts-solution-config-v3 branch from f214bcb to 699055d Compare October 4, 2022 15:55
@Hotell Hotell marked this pull request as ready for review October 4, 2022 15:56
@Hotell Hotell requested a review from a team as a code owner October 4, 2022 15:56
@Hotell
Copy link
Contributor Author

Hotell commented Oct 4, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 4, 2022

Azure Pipelines successfully started running 3 pipeline(s).

@tudorpopams tudorpopams self-requested a review October 5, 2022 12:11
@Hotell Hotell merged commit df1e8f5 into microsoft:master Oct 11, 2022
@Hotell Hotell deleted the hotell/build/scripts/ts-solution-config-v3 branch October 11, 2022 13:47
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@Hotell @NotWoods
feat(scripts): enable strict checking for additional sub-folders(pack…
d98de92 
…ages) v3 (microsoft#25074)

* feat(scripts): enable strict checking for dependency-graph-generator

* feat(scripts): enable strict checking for jest/

* feat(scripts): enable strict checking for babel/

* feat(scripts): enable strict checking for api-extractor/

* feat(scripts): enable strict checking for typescript/

* feat(scripts): enable strict checking for webpack/

* feat(scripts): enable strict checking for tasks/

* feat(scripts): register new sub-folders to ts-solution config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees

No one assigned

Labels

Area: Build System

Projects

None yet

Milestone

October Project Cycle Q4 2022

Development

Successfully merging this pull request may close these issues.

4 participants

@Hotell @fabricteam @tudorpopams @miroslavstastny