Skip to content

Fixed a prop name in doc#25037

Merged
layershifter merged 1 commit intomicrosoft:masterfrom
tony-xia:wrong-prop-name
Oct 3, 2022
Merged

Fixed a prop name in doc#25037
layershifter merged 1 commit intomicrosoft:masterfrom
tony-xia:wrong-prop-name

Conversation

@tony-xia
Copy link
Contributor

@tony-xia tony-xia commented Oct 1, 2022

Current Behavior

wrong prop name: ariaPoisitionInSet

New Behavior

it is ariaPositionInSet now

Related Issue(s)

Fixes #

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ecb8b72:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 1, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 79174e4d44832bed28251cde2fa1217509b2a3c2 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1283 1297 5000
Button mount 919 908 5000
FluentProvider mount 1518 1488 5000
FluentProviderWithTheme mount 573 591 10
FluentProviderWithTheme virtual-rerender 547 538 10
FluentProviderWithTheme virtual-rerender-with-unmount 576 581 10
MakeStyles mount 1969 1969 50000
SpinButton mount 2332 2343 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 79.037 kB
24.059 kB
react-alert
Alert		 84.117 kB
21.07 kB
react-avatar
Avatar		 48.828 kB
13.842 kB
react-avatar
AvatarGroup		 14.95 kB
5.989 kB
react-avatar
AvatarGroupItem		 68.796 kB
19.182 kB
react-badge
Badge		 22.6 kB
7.205 kB
react-badge
CounterBadge		 23.49 kB
7.489 kB
react-badge
PresenceBadge		 24.05 kB
7.067 kB
react-button
Button		 36.278 kB
9.636 kB
react-button
CompoundButton		 43.303 kB
10.852 kB
react-button
MenuButton		 38.972 kB
10.536 kB
react-button
SplitButton		 46.418 kB
11.916 kB
react-button
ToggleButton		 52.145 kB
11.108 kB
react-card
Card - All		 67.17 kB
19.281 kB
react-card
Card		 62.852 kB
18.198 kB
react-card
CardFooter		 8.561 kB
3.601 kB
react-card
CardHeader		 9.604 kB
3.94 kB
react-card
CardPreview		 8.662 kB
3.656 kB
react-combobox
Combobox (including child components)		 74.642 kB
24.19 kB
react-combobox
Dropdown (including child components)		 74.242 kB
24.089 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.156 kB
52.385 kB
react-components
react-components: FluentProvider & webLightTheme		 33.4 kB
11.008 kB
react-dialog
Dialog (including children components)		 82.438 kB
24.444 kB
react-divider
Divider		 16.459 kB
5.902 kB
react-image
Image		 10.78 kB
4.264 kB
react-input
Input		 23.762 kB
7.706 kB
react-label
Label		 9.338 kB
3.86 kB
react-link
Link		 11.806 kB
4.868 kB
react-menu
Menu (including children components)		 116.718 kB
35.78 kB
react-menu
Menu (including selectable components)		 119.787 kB
36.289 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-popover
Popover		 102.929 kB
31.542 kB
react-portal
Portal		 10.582 kB
3.875 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-progress
Progress		 13.44 kB
5.247 kB
react-provider
FluentProvider		 15.761 kB
5.885 kB
react-radio
Radio		 36.39 kB
12.103 kB
react-radio
RadioGroup		 14.248 kB
5.7 kB
react-select
Select		 20.846 kB
7.346 kB
react-slider
Slider		 31.759 kB
10.064 kB
react-spinbutton
SpinButton		 44.102 kB
12.425 kB
react-spinner
Spinner		 19.977 kB
6.438 kB
react-switch
Switch		 33.342 kB
10.557 kB
react-text
Text - Default		 11.782 kB
4.605 kB
react-text
Text - Wrappers		 15.092 kB
5.044 kB
react-textarea
Textarea		 25.018 kB
8.133 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.65 kB
6.444 kB
react-theme
Teams: Light theme		 17.486 kB
5.057 kB
react-tooltip
Tooltip		 41.541 kB
14.646 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 79174e4d44832bed28251cde2fa1217509b2a3c2

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 248 196 1.27:1
HeaderMinimalPerf.default 300 249 1.2:1
ListWith60ListItems.default 535 448 1.19:1
AccordionMinimalPerf.default 125 106 1.18:1
TableMinimalPerf.default 331 283 1.17:1
RadioGroupMinimalPerf.default 370 319 1.16:1
HeaderSlotsPerf.default 613 548 1.12:1
ReactionMinimalPerf.default 297 266 1.12:1
SegmentMinimalPerf.default 280 249 1.12:1
CardMinimalPerf.default 425 382 1.11:1
RefMinimalPerf.default 195 178 1.1:1
SliderMinimalPerf.default 1343 1223 1.1:1
DropdownManyItemsPerf.default 527 483 1.09:1
TextMinimalPerf.default 276 256 1.08:1
AttachmentMinimalPerf.default 110 104 1.06:1
PopupMinimalPerf.default 540 511 1.06:1
AttachmentSlotsPerf.default 839 799 1.05:1
AvatarMinimalPerf.default 140 133 1.05:1
ButtonMinimalPerf.default 122 116 1.05:1
ButtonOverridesMissPerf.default 994 950 1.05:1
CarouselMinimalPerf.default 339 323 1.05:1
ChatDuplicateMessagesPerf.default 198 188 1.05:1
VideoMinimalPerf.default 585 558 1.05:1
StatusMinimalPerf.default 508 489 1.04:1
IconMinimalPerf.default 478 461 1.04:1
ToolbarMinimalPerf.default 689 664 1.04:1
ItemLayoutMinimalPerf.default 900 870 1.03:1
TreeMinimalPerf.default 600 583 1.03:1
AnimationMinimalPerf.default 396 390 1.02:1
EmbedMinimalPerf.default 2853 2804 1.02:1
GridMinimalPerf.default 245 241 1.02:1
MenuMinimalPerf.default 626 612 1.02:1
ProviderMinimalPerf.default 329 322 1.02:1
TextAreaMinimalPerf.default 385 376 1.02:1
CustomToolbarPrototype.default 2048 2013 1.02:1
TooltipMinimalPerf.default 1758 1725 1.02:1
DialogMinimalPerf.default 571 567 1.01:1
ListCommonPerf.default 464 458 1.01:1
MenuButtonMinimalPerf.default 1274 1264 1.01:1
SkeletonMinimalPerf.default 251 249 1.01:1
SplitButtonMinimalPerf.default 3253 3232 1.01:1
ChatMinimalPerf.default 533 531 1:1
ChatWithPopoverPerf.default 279 280 1:1
ButtonSlotsPerf.default 403 406 0.99:1
LayoutMinimalPerf.default 260 262 0.99:1
LoaderMinimalPerf.default 479 484 0.99:1
TableManyItemsPerf.default 1399 1409 0.99:1
ImageMinimalPerf.default 294 302 0.97:1
InputMinimalPerf.default 902 930 0.97:1
PortalMinimalPerf.default 121 125 0.97:1
TreeWith60ListItems.default 119 123 0.97:1
DatepickerMinimalPerf.default 4159 4310 0.96:1
ListMinimalPerf.default 404 419 0.96:1
AlertMinimalPerf.default 184 194 0.95:1
DropdownMinimalPerf.default 1996 2093 0.95:1
RosterPerf.default 1591 1683 0.95:1
BoxMinimalPerf.default 260 278 0.94:1
DividerMinimalPerf.default 248 264 0.94:1
CheckboxMinimalPerf.default 1594 1721 0.93:1
FormMinimalPerf.default 260 280 0.93:1
ListNestedPerf.default 400 444 0.9:1
ProviderMergeThemesPerf.default 935 1060 0.88:1
LabelMinimalPerf.default 275 317 0.87:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1575 1570 5000
Breadcrumb mount 3715 3734 1000
Checkbox mount 3512 3480 5000
CheckboxBase mount 3048 3092 5000
ChoiceGroup mount 5859 5929 5000
ComboBox mount 1588 1614 1000
CommandBar mount 12076 11963 1000
ContextualMenu mount 13715 13724 1000
DefaultButton mount 1809 1810 5000
DetailsRow mount 4708 4760 5000
DetailsRowFast mount 4727 4703 5000
DetailsRowNoStyles mount 4514 4546 5000
Dialog mount 3842 3905 1000
DocumentCardTitle mount 726 725 1000
Dropdown mount 4210 4249 5000
FocusTrapZone mount 2506 2562 5000
FocusZone mount 2498 2446 5000
GroupedList mount 70178 81539 2
GroupedList virtual-rerender 33680 33359 2
GroupedList virtual-rerender-with-unmount 112046 113732 2
GroupedListV2 mount 697 696 2
GroupedListV2 virtual-rerender 662 649 2
GroupedListV2 virtual-rerender-with-unmount 703 695 2
IconButton mount 2522 2537 5000
Label mount 918 919 5000
Layer mount 5381 5452 5000
Link mount 1052 1077 5000
MenuButton mount 2186 2238 5000
MessageBar mount 2975 2868 5000
Nav mount 4302 4365 1000
OverflowSet mount 1713 1700 5000
Panel mount 3263 3177 1000
Persona mount 1632 1639 1000
Pivot mount 2059 2153 1000
PrimaryButton mount 1941 1981 5000
Rating mount 9502 9519 5000
SearchBox mount 2038 1980 5000
Shimmer mount 3754 3714 5000
Slider mount 2676 2690 5000
SpinButton mount 6007 6039 5000
Spinner mount 1005 1000 5000
SplitButton mount 4033 3994 5000
Stack mount 1081 1098 5000
StackWithIntrinsicChildren mount 3278 3277 5000
StackWithTextChildren mount 6683 6578 5000
SwatchColorPicker mount 13519 13637 5000
TagPicker mount 3444 3445 5000
TeachingBubble mount 107772 107743 5000
Text mount 996 1010 5000
TextField mount 2088 2087 5000
ThemeProvider mount 1927 1925 5000
ThemeProvider virtual-rerender 1339 1369 5000
ThemeProvider virtual-rerender-with-unmount 2687 2729 5000
Toggle mount 1397 1407 5000
buttonNative mount 655 674 5000

@layershifter layershifter reopened this Oct 3, 2022
@layershifter layershifter reopened this Oct 3, 2022
@layershifter layershifter merged commit a27927f into microsoft:master Oct 3, 2022
GeoffCoxMSFT pushed a commit to GeoffCoxMSFT/fluentui that referenced this pull request Oct 3, 2022
@tony-xia @GeoffCoxMSFT
Fixed a prop name in doc (microsoft#25037)
283b052
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@tony-xia @NotWoods
Fixed a prop name in doc (microsoft#25037)
8355879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

Assignees

@tomi-msft tomi-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tony-xia @fabricteam @layershifter @tomi-msft