fix: Checkbox's label shouldn't have a pointer cursor when disabled#25018
Merged
behowell merged 3 commits intomicrosoft:masterfrom Sep 30, 2022
Merged
Conversation
khmakoto
approved these changes
Sep 29, 2022
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2e8d044a4ce2c1095f13e08716c3ba13069ebf0d (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5208119:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1286 | 1279 | 5000 | |
| Button | mount | 923 | 927 | 5000 | |
| FluentProvider | mount | 1507 | 1482 | 5000 | |
| FluentProviderWithTheme | mount | 581 | 581 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 537 | 525 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 574 | 584 | 10 | |
| MakeStyles | mount | 1906 | 1929 | 50000 | |
| SpinButton | mount | 2319 | 2335 | 5000 |
GeoffCoxMSFT
pushed a commit
to GeoffCoxMSFT/fluentui
that referenced
this pull request
Oct 3, 2022
…icrosoft#25018) * Use the default cursor (not pointer) on the label when the checkbox is disabled * Simplify the styles controlling the padding between the checkbox and label
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…icrosoft#25018) * Use the default cursor (not pointer) on the label when the checkbox is disabled * Simplify the styles controlling the padding between the checkbox and label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The cursor is a pointer when hovering a disabled checkbox's label.
New Behavior