feat(react-components): Move Persona to unstable#25008
Merged
sopranopillow merged 7 commits intomicrosoft:masterfrom Sep 29, 2022
Merged
feat(react-components): Move Persona to unstable#25008sopranopillow merged 7 commits intomicrosoft:masterfrom
sopranopillow merged 7 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1311 | 1179 | 5000 | |
| Button | mount | 880 | 927 | 5000 | |
| FluentProvider | mount | 1481 | 1472 | 5000 | |
| FluentProviderWithTheme | mount | 632 | 639 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 524 | 600 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 630 | 627 | 10 | |
| MakeStyles | mount | 1840 | 1901 | 50000 | |
| SpinButton | mount | 2446 | 2440 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0885025f43076ebdf3a395cfb6ae65b3304cc5b2 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 99247cc:
|
khmakoto
reviewed
Sep 29, 2022
packages/react-components/react-persona/src/stories/Persona/PersonaDescription.md
Outdated
Show resolved
Hide resolved
khmakoto
approved these changes
Sep 29, 2022
GeoffCoxMSFT
pushed a commit
to GeoffCoxMSFT/fluentui
that referenced
this pull request
Oct 3, 2022
* moving Persona to unstable * change file * adding persona to dependencies * publishing react-persona * change file * updating react-components api * adding requested changes
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* moving Persona to unstable * change file * adding persona to dependencies * publishing react-persona * change file * updating react-components api * adding requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves Persona to unstable and adds disclaimers of it being unstable.
Related Issue(s)
Fixes #25004