Bump react-component peer deps to support React 18#24972
Merged
micahgodbolt merged 6 commits intomicrosoft:masterfrom Oct 13, 2022
Merged
Bump react-component peer deps to support React 18#24972micahgodbolt merged 6 commits intomicrosoft:masterfrom
micahgodbolt merged 6 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d28763:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1275 | 1262 | 5000 | |
| Button | mount | 927 | 924 | 5000 | |
| FluentProvider | mount | 1487 | 1482 | 5000 | |
| FluentProviderWithTheme | mount | 573 | 578 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 539 | 550 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 578 | 588 | 10 | |
| MakeStyles | mount | 1958 | 1960 | 50000 | |
| SpinButton | mount | 2344 | 2322 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a8e81b5296f1551e74010c1d2ad9d37c6fd48306 (build) |
khmakoto
reviewed
Oct 7, 2022
Member
khmakoto
left a comment
There was a problem hiding this comment.
Should we have any documentation about special things you need to do so the components work correctly in React 18?
sopranopillow
approved these changes
Oct 7, 2022
spmonahan
approved these changes
Oct 11, 2022
khmakoto
approved these changes
Oct 11, 2022
Hotell
approved these changes
Oct 12, 2022
TristanWatanabe
approved these changes
Oct 12, 2022
layershifter
approved these changes
Oct 13, 2022
This was referenced Oct 13, 2022
2 tasks
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* chore: bump react-component peer deps to support React 18 * change files * change files * use correct change type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24971
To establish confidence that react-components will function properly, we have: