feat: Dropdown a11y overview section#24933
Merged
smhigley merged 4 commits intomicrosoft:masterfrom Nov 16, 2022
Merged
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 942df8c6e915e7edcebe62f5431488dce09303d8 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 77b4e19:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1153 | 1211 | 5000 | |
| Button | mount | 942 | 829 | 5000 | |
| FluentProvider | mount | 1544 | 1453 | 5000 | |
| FluentProviderWithTheme | mount | 560 | 556 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 518 | 537 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 628 | 629 | 10 | |
| MakeStyles | mount | 1664 | 1729 | 50000 | |
| SpinButton | mount | 2237 | 2454 | 5000 |
5939d54 to
cad9cc0
Compare
spmonahan
reviewed
Oct 28, 2022
packages/react-components/react-combobox/src/stories/Dropdown/DropdownAccessibility.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-combobox/src/stories/Dropdown/DropdownAccessibility.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-combobox/src/stories/Dropdown/DropdownAccessibility.md
Outdated
Show resolved
Hide resolved
| ### Do | ||
|
|
||
| - **Provide a label for the Dropdown.** | ||
| - **Set the Option's `value` prop if the content contains JSX.** The Option value is used for keyboard accessibility to enable users to type a letter or string and jump to the matching option. The value is calculated from the children by default, but if the Option contains JSX, the `value` prop should be used to directly provide a string value. |
Member
There was a problem hiding this comment.
Value (or label) is going to be required, so this will need to be reworded.
Contributor
Author
There was a problem hiding this comment.
I think I'll make the update in the other PR, so there's no mismatch between the doc and the behavior in the meantime
micahgodbolt
approved these changes
Oct 28, 2022
Member
micahgodbolt
left a comment
There was a problem hiding this comment.
approved with some feedback
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #24917
This adds a set of accessibility Do's/Don'ts to the Dropdown docs page, immediately after Best Practices, and links to the full spec page. The link URLs themselves depend on the related spec PR being merged first.