Skip to content

fix: Update package template beachball config to allow only 'prerelease' changes by default#24763

Merged
behowell merged 1 commit intomicrosoft:masterfrom
behowell:template/beachball-change-type
Sep 13, 2022
Merged

fix: Update package template beachball config to allow only 'prerelease' changes by default#24763
behowell merged 1 commit intomicrosoft:masterfrom
behowell:template/beachball-change-type

Conversation

@behowell
Copy link
Contributor

@behowell behowell commented Sep 12, 2022

Current Behavior

Newly created packages are version 9.0.0-alpha.0 by default, but disallow prerelease change types. This makes it so the initial release will likely be patch or minor by default, which will end up publishing a non-alpha/beta release.

New Behavior

Update package template beachball config to allow only prerelease changes by default

Related Issue(s)

This came up when publishing the react-field package: #24235 (comment)

@behowell behowell self-assigned this Sep 12, 2022
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Sep 12, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2fd0a09:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 12, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cd8f5a11fd89c77582950fe714fece2bdf9c08c0 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 12, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1536 1546 5000
Button mount 1115 1109 5000
FluentProvider mount 1902 1840 5000
FluentProviderWithTheme mount 737 754 10
FluentProviderWithTheme virtual-rerender 728 691 10
FluentProviderWithTheme virtual-rerender-with-unmount 740 726 10
MakeStyles mount 2286 2235 50000
SpinButton mount 2945 3042 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 12, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 78.914 kB
24.06 kB
react-alert
Alert		 83.228 kB
20.889 kB
react-avatar
Avatar		 48.381 kB
13.696 kB
react-avatar
AvatarGroup		 14.95 kB
5.989 kB
react-avatar
AvatarGroupItem		 68.349 kB
19.039 kB
react-badge
Badge		 22.6 kB
7.205 kB
react-badge
CounterBadge		 23.503 kB
7.497 kB
react-badge
PresenceBadge		 24.05 kB
7.067 kB
react-button
Button		 35.836 kB
9.59 kB
react-button
CompoundButton		 42.862 kB
10.808 kB
react-button
MenuButton		 38.454 kB
10.461 kB
react-button
SplitButton		 45.87 kB
11.811 kB
react-button
ToggleButton		 51.017 kB
11.007 kB
react-card
Card - All		 67.002 kB
19.261 kB
react-card
Card		 62.684 kB
18.177 kB
react-card
CardFooter		 8.561 kB
3.601 kB
react-card
CardHeader		 9.604 kB
3.94 kB
react-card
CardPreview		 8.662 kB
3.656 kB
react-combobox
Combobox (including child components)		 73.863 kB
24.018 kB
react-combobox
Dropdown (including child components)		 73.45 kB
23.927 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 187.656 kB
51.96 kB
react-components
react-components: FluentProvider & webLightTheme		 33.359 kB
11.004 kB
react-dialog
Dialog (including children components)		 80.608 kB
24.053 kB
react-divider
Divider		 16.459 kB
5.902 kB
react-image
Image		 10.78 kB
4.264 kB
react-input
Input		 23.598 kB
7.661 kB
react-label
Label		 9.338 kB
3.86 kB
react-link
Link		 11.784 kB
4.867 kB
react-menu
Menu (including children components)		 115.735 kB
35.419 kB
react-menu
Menu (including selectable components)		 118.934 kB
35.916 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-popover
Popover		 102.938 kB
31.542 kB
react-portal
Portal		 10.576 kB
3.875 kB
react-portal-compat
PortalCompatProvider		 5.851 kB
1.964 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-provider
FluentProvider		 15.755 kB
5.883 kB
react-radio
Radio		 35.56 kB
11.929 kB
react-radio
RadioGroup		 14.248 kB
5.7 kB
react-select
Select		 20.846 kB
7.346 kB
react-slider
Slider		 31.526 kB
10.046 kB
react-spinbutton
SpinButton		 43.943 kB
12.382 kB
react-spinner
Spinner		 19.977 kB
6.438 kB
react-switch
Switch		 32.097 kB
10.27 kB
react-text
Text - Default		 11.782 kB
4.605 kB
react-text
Text - Wrappers		 15.092 kB
5.044 kB
react-textarea
Textarea		 23.988 kB
8.011 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.548 kB
6.434 kB
react-theme
Teams: Light theme		 17.452 kB
5.054 kB
react-tooltip
Tooltip		 41.502 kB
14.623 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against cd8f5a11fd89c77582950fe714fece2bdf9c08c0

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 12, 2022

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 130 129 1.01:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatDuplicateMessagesPerf.default 252 235 1.07:1
TreeWith60ListItems.default 132 124 1.06:1
ButtonSlotsPerf.default 439 419 1.05:1
ListCommonPerf.default 533 506 1.05:1
ProviderMinimalPerf.default 327 315 1.04:1
RefMinimalPerf.default 191 183 1.04:1
HeaderMinimalPerf.default 326 316 1.03:1
ListNestedPerf.default 475 460 1.03:1
ReactionMinimalPerf.default 346 336 1.03:1
AttachmentMinimalPerf.default 128 126 1.02:1
ButtonMinimalPerf.default 139 136 1.02:1
DividerMinimalPerf.default 325 318 1.02:1
HeaderSlotsPerf.default 700 684 1.02:1
ItemLayoutMinimalPerf.default 995 978 1.02:1
LayoutMinimalPerf.default 323 317 1.02:1
RadioGroupMinimalPerf.default 395 389 1.02:1
TreeMinimalPerf.default 706 693 1.02:1
VideoMinimalPerf.default 626 615 1.02:1
ButtonOverridesMissPerf.default 1025 1017 1.01:1
DialogMinimalPerf.default 692 684 1.01:1
DropdownManyItemsPerf.default 551 543 1.01:1
EmbedMinimalPerf.default 2674 2660 1.01:1
FlexMinimalPerf.default 256 253 1.01:1
ImageMinimalPerf.default 348 345 1.01:1
LabelMinimalPerf.default 342 338 1.01:1
LoaderMinimalPerf.default 521 518 1.01:1
MenuMinimalPerf.default 740 730 1.01:1
MenuButtonMinimalPerf.default 1388 1370 1.01:1
PortalMinimalPerf.default 146 145 1.01:1
SliderMinimalPerf.default 1259 1252 1.01:1
StatusMinimalPerf.default 611 605 1.01:1
TextMinimalPerf.default 308 305 1.01:1
CustomToolbarPrototype.default 2219 2197 1.01:1
TooltipMinimalPerf.default 1890 1864 1.01:1
AnimationMinimalPerf.default 460 462 1:1
BoxMinimalPerf.default 297 296 1:1
ChatMinimalPerf.default 650 648 1:1
DropdownMinimalPerf.default 2199 2197 1:1
FormMinimalPerf.default 322 321 1:1
ListWith60ListItems.default 509 510 1:1
PopupMinimalPerf.default 562 564 1:1
ProviderMergeThemesPerf.default 1001 997 1:1
SplitButtonMinimalPerf.default 3292 3289 1:1
TableManyItemsPerf.default 1587 1580 1:1
TextAreaMinimalPerf.default 419 420 1:1
ToolbarMinimalPerf.default 798 800 1:1
AttachmentSlotsPerf.default 869 882 0.99:1
CarouselMinimalPerf.default 347 350 0.99:1
CheckboxMinimalPerf.default 1527 1538 0.99:1
DatepickerMinimalPerf.default 4954 4985 0.99:1
InputMinimalPerf.default 867 874 0.99:1
ListMinimalPerf.default 453 459 0.99:1
SegmentMinimalPerf.default 312 315 0.99:1
SkeletonMinimalPerf.default 301 305 0.99:1
ChatWithPopoverPerf.default 291 296 0.98:1
RosterPerf.default 1694 1723 0.98:1
IconMinimalPerf.default 564 574 0.98:1
CardMinimalPerf.default 468 482 0.97:1
TableMinimalPerf.default 343 355 0.97:1
AlertMinimalPerf.default 220 228 0.96:1
GridMinimalPerf.default 291 302 0.96:1
AvatarMinimalPerf.default 154 171 0.9:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 12, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 783 771 5000
Breadcrumb mount 2471 2482 1000
Checkbox mount 2241 2245 5000
CheckboxBase mount 1964 1950 5000
ChoiceGroup mount 3992 3959 5000
ComboBox mount 822 830 1000
CommandBar mount 9684 9238 1000
ContextualMenu mount 11102 11190 1000
DefaultButton mount 956 966 5000
DetailsRow mount 3284 3333 5000
DetailsRowFast mount 3267 3316 5000
DetailsRowNoStyles mount 3103 3105 5000
Dialog mount 2669 2702 1000
DocumentCardTitle mount 155 156 1000
Dropdown mount 2813 2851 5000
FocusTrapZone mount 1604 1588 5000
FocusZone mount 1557 1531 5000
IconButton mount 1487 1487 5000
Label mount 308 280 5000
Layer mount 3862 3890 5000
Link mount 399 383 5000
MenuButton mount 1268 1261 5000
MessageBar mount 1845 1921 5000
Nav mount 2837 2856 1000
OverflowSet mount 963 947 5000
Panel mount 2133 2128 1000
Persona mount 881 861 1000
Pivot mount 1235 1221 1000
PrimaryButton mount 1099 1103 5000
Rating mount 6590 6650 5000
SearchBox mount 1109 1074 5000
Shimmer mount 2415 2411 5000
Slider mount 1673 1721 5000
SpinButton mount 4306 4253 5000
Spinner mount 363 378 5000
SplitButton mount 2685 2854 5000
Stack mount 427 430 5000
StackWithIntrinsicChildren mount 1974 1964 5000
StackWithTextChildren mount 4458 4443 5000
SwatchColorPicker mount 10069 10157 5000
TagPicker mount 2289 2277 5000
TeachingBubble mount 96123 96938 5000
Text mount 365 365 5000
TextField mount 1195 1180 5000
ThemeProvider mount 1119 1094 5000
ThemeProvider virtual-rerender 662 654 5000
ThemeProvider virtual-rerender-with-unmount 1737 1740 5000
Toggle mount 704 673 5000
buttonNative mount 113 110 5000

@behowell behowell marked this pull request as ready for review September 12, 2022 20:06
@behowell behowell requested a review from a team as a code owner September 12, 2022 20:06
@behowell behowell merged commit e0a0ab1 into microsoft:master Sep 13, 2022
@behowell behowell deleted the template/beachball-change-type branch September 13, 2022 20:00
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 14, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
b8b4b55 
* master: (28 commits)
  Fix value font-weight inside heatmap chart (microsoft#24726)
  Fix legend overflow-indication-text role (microsoft#24756)
  Support custom locale in date axis  (microsoft#24753)
  Cleanup env variables (microsoft#24739)
  ci(github): add GH Action to add issue labels based on new GH issue template (microsoft#24788)
  Update disallowedChangeTypes for newly created packages, to allow only 'prerelease' change types by default (microsoft#24763)
  feat(react-components): Adding missing AvatarGroup exports (microsoft#24770)
  remove unnecessary nohoist (microsoft#24760)
  feat(react-dialog): supports 1st rule of ARIA (microsoft#24525)
  BREAKING: TableCell layouts are handled by layout components (microsoft#24762)
  feat: Implement table cell layout components (microsoft#24773)
  applying package updates
  fix: remove readonly from DetailsList (microsoft#24615)
  chore: Cleaning up tokens in Button components so they better adhere to the design spec (microsoft#24732)
  fix: react-combobox listbox popup width matches trigger width (microsoft#24733)
  fix: react-combobox Option focus outline only shows with keyboard nav (microsoft#24700)
  feat: Publish react-field package, and export from react-components/unstable (microsoft#24235)
  fix: Replacing bottom border styles with text decoration underline in Link (microsoft#24734)
  docs(react-theme): Update readme (microsoft#24755)
  Add tests for hover states (microsoft#24390)
  ...
@behowell behowell mentioned this pull request Oct 6, 2022
Merged
@Hotell Hotell mentioned this pull request Oct 14, 2022
Closed
2 tasks
@sopranopillow sopranopillow mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khmakoto khmakoto khmakoto approved these changes

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@behowell behowell

Labels

Area: Build System

Projects

None yet

Milestone

July Project Cycle Q3 2022

Development

Successfully merging this pull request may close these issues.

5 participants

@behowell @fabricteam @khmakoto @ling1726 @msft-fluent-ui-bot