chore: Add VR tests for Table primitives by ling1726 · Pull Request #24386 · microsoft/fluentui

ling1726 · 2022-08-16T17:03:20Z

Fixes #24224

fabricteam · 2022-08-16T17:12:04Z

📊 Bundle size report

_{🤖 This report was generated against 02a6a76a3350adfb4fd95cdfc178864801c8e2bf}

azure-pipelines.yml

codesandbox-ci · 2022-08-16T17:20:54Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 00d3f72:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-08-16T17:24:49Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 02a6a76a3350adfb4fd95cdfc178864801c8e2bf (build)

fabricteam · 2022-08-16T17:28:51Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1266	1172	5000
Button	mount	923	851	5000
FluentProvider	mount	1531	1450	5000
FluentProviderWithTheme	mount	572	563	10
FluentProviderWithTheme	virtual-rerender	585	530	10
FluentProviderWithTheme	virtual-rerender-with-unmount	539	624	10
MakeStyles	mount	1894	1717	50000
SpinButton	mount	2387	2283	5000

fabricteam · 2022-08-16T17:32:19Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ChatWithPopoverPerf.default	314	289	1.09:1
VideoMinimalPerf.default	569	524	1.09:1
RefMinimalPerf.default	191	181	1.06:1
TreeWith60ListItems.default	132	124	1.06:1
IconMinimalPerf.default	537	513	1.05:1
AttachmentMinimalPerf.default	130	125	1.04:1
AvatarMinimalPerf.default	168	161	1.04:1
ButtonSlotsPerf.default	440	422	1.04:1
ImageMinimalPerf.default	333	319	1.04:1
DividerMinimalPerf.default	317	308	1.03:1
RadioGroupMinimalPerf.default	403	391	1.03:1
AnimationMinimalPerf.default	470	462	1.02:1
AttachmentSlotsPerf.default	872	858	1.02:1
ButtonOverridesMissPerf.default	1189	1170	1.02:1
ChatDuplicateMessagesPerf.default	226	221	1.02:1
FormMinimalPerf.default	357	351	1.02:1
ItemLayoutMinimalPerf.default	993	978	1.02:1
ListCommonPerf.default	528	516	1.02:1
ListMinimalPerf.default	469	459	1.02:1
LoaderMinimalPerf.default	533	524	1.02:1
MenuMinimalPerf.default	742	731	1.02:1
PortalMinimalPerf.default	142	139	1.02:1
SegmentMinimalPerf.default	305	299	1.02:1
TextAreaMinimalPerf.default	417	410	1.02:1
BoxMinimalPerf.default	303	299	1.01:1
CardMinimalPerf.default	480	475	1.01:1
DropdownManyItemsPerf.default	552	544	1.01:1
FlexMinimalPerf.default	251	249	1.01:1
GridMinimalPerf.default	299	296	1.01:1
HeaderSlotsPerf.default	694	686	1.01:1
SkeletonMinimalPerf.default	301	298	1.01:1
SliderMinimalPerf.default	1330	1313	1.01:1
StatusMinimalPerf.default	615	610	1.01:1
TableManyItemsPerf.default	1565	1556	1.01:1
ChatMinimalPerf.default	652	652	1:1
CheckboxMinimalPerf.default	1937	1932	1:1
DatepickerMinimalPerf.default	4645	4661	1:1
DialogMinimalPerf.default	690	689	1:1
DropdownMinimalPerf.default	2564	2569	1:1
EmbedMinimalPerf.default	2993	2980	1:1
LabelMinimalPerf.default	340	339	1:1
LayoutMinimalPerf.default	314	315	1:1
MenuButtonMinimalPerf.default	1333	1332	1:1
PopupMinimalPerf.default	554	552	1:1
ProviderMergeThemesPerf.default	993	993	1:1
ProviderMinimalPerf.default	320	321	1:1
SplitButtonMinimalPerf.default	3282	3273	1:1
CustomToolbarPrototype.default	2181	2173	1:1
ToolbarMinimalPerf.default	807	811	1:1
CarouselMinimalPerf.default	361	363	0.99:1
HeaderMinimalPerf.default	318	321	0.99:1
InputMinimalPerf.default	981	988	0.99:1
TableMinimalPerf.default	348	351	0.99:1
TreeMinimalPerf.default	715	719	0.99:1
ButtonMinimalPerf.default	134	137	0.98:1
ListNestedPerf.default	464	473	0.98:1
ReactionMinimalPerf.default	325	330	0.98:1
TextMinimalPerf.default	300	306	0.98:1
TooltipMinimalPerf.default	947	963	0.98:1
ListWith60ListItems.default	488	503	0.97:1
RosterPerf.default	847	869	0.97:1
AlertMinimalPerf.default	218	230	0.95:1
AccordionMinimalPerf.default	126	134	0.94:1

fabricteam · 2022-08-16T17:38:07Z

Perf Analysis (`@fluentui/react`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
buttonNative	mount	89	100	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
BaseButton	mount	796	806	5000
Breadcrumb	mount	2360	2297	1000
Checkbox	mount	2301	2246	5000
CheckboxBase	mount	2002	1983	5000
ChoiceGroup	mount	3967	3943	5000
ComboBox	mount	761	779	1000
CommandBar	mount	9107	9045	1000
ContextualMenu	mount	9752	10731	1000
DefaultButton	mount	957	966	5000
DetailsRow	mount	3024	3078	5000
DetailsRowFast	mount	3100	3046	5000
DetailsRowNoStyles	mount	2900	2891	5000
Dialog	mount	2290	2283	1000
DocumentCardTitle	mount	137	140	1000
Dropdown	mount	2782	2774	5000
FocusTrapZone	mount	1543	1565	5000
FocusZone	mount	1528	1548	5000
IconButton	mount	1426	1393	5000
Label	mount	330	321	5000
Layer	mount	2709	2704	5000
Link	mount	426	435	5000
MenuButton	mount	1231	1229	5000
MessageBar	mount	1918	1802	5000
Nav	mount	2614	2645	1000
OverflowSet	mount	968	987	5000
Panel	mount	1786	1879	1000
Persona	mount	830	859	1000
Pivot	mount	1124	1115	1000
PrimaryButton	mount	1116	1079	5000
Rating	mount	6723	6666	5000
SearchBox	mount	1122	1130	5000
Shimmer	mount	2216	2209	5000
Slider	mount	1684	1681	5000
SpinButton	mount	3962	3931	5000
Spinner	mount	407	399	5000
SplitButton	mount	2491	2504	5000
Stack	mount	494	485	5000
StackWithIntrinsicChildren	mount	1874	1867	5000
StackWithTextChildren	mount	4650	4642	5000
SwatchColorPicker	mount	9072	9072	5000
TagPicker	mount	2024	2011	5000
TeachingBubble	mount	75761	75365	5000
Text	mount	397	399	5000
TextField	mount	1159	1149	5000
ThemeProvider	mount	948	959	5000
ThemeProvider	virtual-rerender	629	639	5000
ThemeProvider	virtual-rerender-with-unmount	1397	1394	5000
Toggle	mount	722	733	5000
buttonNative	mount	89	100	5000	Possible regression

azure-pipelines.yml

layershifter · 2022-08-16T20:21:46Z

azure-pipelines.yml

@@ -123,7 +123,7 @@ jobs:
        displayName: yarn


Can we move out these changes into a separate PR?

sure, it will just block this PR 😞

Done in #24395

Reverted yml changes in 00d3f72

layershifter · 2022-08-17T13:02:45Z

@ling1726 looks that it still broken:

Error: Call to proxy failed: 504
    at scheduleScreenerBuild (/mnt/vss/_work/1/s/scripts/screener/screener.runner.ts:52:11)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Object.screenerRunner (/mnt/vss/_work/1/s/scripts/screener/screener.runner.ts:80:20)
    at async screener (/mnt/vss/_work/1/s/scripts/tasks/screener.ts:40:7)

ling1726 · 2022-08-17T13:08:07Z

yeah I noticed that, I've sent the details to @ralucapelin to take a look

ling1726 · 2022-08-17T13:24:01Z

/azp run

azure-pipelines · 2022-08-17T13:24:21Z

Azure Pipelines successfully started running 3 pipeline(s).

layershifter

🚀

chore: Add VR tests for Table primitives

981fe27

msft-fluent-ui-bot assigned layershifter Aug 16, 2022

msft-fluent-ui-bot added the Component: Table label Aug 16, 2022

github-actions bot added this to the July Project Cycle Q3 2022 milestone Aug 16, 2022

fix pipeline

a6c68e2

ling1726 marked this pull request as ready for review August 16, 2022 17:12

ling1726 requested review from a team as code owners August 16, 2022 17:12

ling1726 commented Aug 16, 2022

View reviewed changes

azure-pipelines.yml Outdated Show resolved Hide resolved

layershifter reviewed Aug 16, 2022

View reviewed changes

azure-pipelines.yml Outdated Show resolved Hide resolved

layershifter reviewed Aug 16, 2022

View reviewed changes

revert yml

00d3f72

ling1726 removed the request for review from a team August 17, 2022 06:55

ling1726 closed this Aug 17, 2022

ling1726 reopened this Aug 17, 2022

layershifter approved these changes Aug 17, 2022

View reviewed changes

ling1726 merged commit 8a8d6a8 into microsoft:master Aug 17, 2022

ling1726 mentioned this pull request Aug 18, 2022

Implement DataGrid component #24420

Closed

Conversation

ling1726 commented Aug 16, 2022

Uh oh!

fabricteam commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

Uh oh!

codesandbox-ci bot commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Aug 16, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Aug 16, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Aug 16, 2022

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

layershifter Aug 16, 2022

Choose a reason for hiding this comment

Uh oh!

ling1726 Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

ling1726 Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

ling1726 Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

layershifter commented Aug 17, 2022

Uh oh!

ling1726 commented Aug 17, 2022

Uh oh!

ling1726 commented Aug 17, 2022

Uh oh!

azure-pipelines bot commented Aug 17, 2022

Uh oh!

layershifter left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fabricteam commented Aug 16, 2022 •

edited

Loading

codesandbox-ci bot commented Aug 16, 2022 •

edited

Loading

size-auditor bot commented Aug 16, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)