chore: Scope screener builds by vr-test project by ling1726 · Pull Request #24395 · microsoft/fluentui

ling1726 · 2022-08-17T06:53:49Z

Currently the builds are scoped by the published package, which can lead to some edge cases:

vr-test package is not affected -> builds anyway
published package is not affected but the vr-test package is

codesandbox-ci · 2022-08-17T07:02:28Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ea6a715:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-08-17T07:08:37Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 888aaf3d58186fa9ce8675f7ee68eab6d84c4cf0 (build)

fabricteam · 2022-08-17T07:10:36Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1436	1447	5000
Button	mount	1105	1135	5000
FluentProvider	mount	1823	1812	5000
FluentProviderWithTheme	mount	706	717	10
FluentProviderWithTheme	virtual-rerender	692	682	10
FluentProviderWithTheme	virtual-rerender-with-unmount	738	725	10
MakeStyles	mount	2180	2224	50000
SpinButton	mount	2831	2827	5000

fabricteam · 2022-08-17T07:13:09Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`79.574 kB` `24.123 kB`
`react-alert` Alert	`82.874 kB` `20.608 kB`
`react-avatar` Avatar	`48.283 kB` `13.644 kB`
`react-avatar` AvatarGroup	`15.072 kB` `6.016 kB`
`react-avatar` AvatarGroupItem	`68.464 kB` `19.067 kB`
`react-badge` Badge	`22.503 kB` `7.153 kB`
`react-badge` CounterBadge	`23.406 kB` `7.449 kB`
`react-badge` PresenceBadge	`23.947 kB` `7.022 kB`
`react-button` Button	`36.396 kB` `9.575 kB`
`react-button` CompoundButton	`43.469 kB` `10.812 kB`
`react-button` MenuButton	`39.014 kB` `10.456 kB`
`react-button` SplitButton	`46.544 kB` `11.84 kB`
`react-button` ToggleButton	`51.91 kB` `11.003 kB`
`react-card` Card - All	`67.47 kB` `19.273 kB`
`react-card` Card	`63.152 kB` `18.185 kB`
`react-card` CardFooter	`8.461 kB` `3.555 kB`
`react-card` CardHeader	`9.504 kB` `3.896 kB`
`react-card` CardPreview	`8.562 kB` `3.61 kB`
`react-combobox` Combobox (including child components)	`72.723 kB` `23.746 kB`
`react-combobox` Dropdown (including child components)	`70.792 kB` `23.233 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`189.042 kB` `51.964 kB`
`react-components` react-components: FluentProvider & webLightTheme	`32.876 kB` `10.773 kB`
`react-dialog` Dialog (including children components)	`84.793 kB` `25.27 kB`
`react-divider` Divider	`16.359 kB` `5.853 kB`
`react-image` Image	`10.68 kB` `4.215 kB`
`react-input` Input	`23.554 kB` `7.644 kB`
`react-label` Label	`9.238 kB` `3.815 kB`
`react-link` Link	`12.231 kB` `4.925 kB`
`react-menu` Menu (including children components)	`115.941 kB` `35.393 kB`
`react-menu` Menu (including selectable components)	`119.14 kB` `35.886 kB`
`react-overflow` hooks only	`10.898 kB` `4.174 kB`
`react-popover` Popover	`103.061 kB` `31.573 kB`
`react-portal` Portal	`10.576 kB` `3.875 kB`
`react-positioning` usePositioning	`19.7 kB` `7.404 kB`
`react-provider` FluentProvider	`15.655 kB` `5.835 kB`
`react-radio` Radio	`36.238 kB` `12 kB`
`react-radio` RadioGroup	`14.361 kB` `5.728 kB`
`react-select` Select	`20.746 kB` `7.299 kB`
`react-slider` Slider	`32.07 kB` `10.033 kB`
`react-spinbutton` SpinButton	`43.899 kB` `12.362 kB`
`react-spinner` Spinner	`19.848 kB` `6.384 kB`
`react-switch` Switch	`32.562 kB` `10.253 kB`
`react-text` Text - Default	`11.572 kB` `4.537 kB`
`react-text` Text - Wrappers	`14.882 kB` `4.977 kB`
`react-textarea` Textarea	`23.674 kB` `7.83 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.205 kB` `6.249 kB`
`react-theme` Teams: Light theme	`17.069 kB` `4.885 kB`
`react-tooltip` Tooltip	`41.504 kB` `14.622 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 888aaf3d58186fa9ce8675f7ee68eab6d84c4cf0}

fabricteam · 2022-08-17T07:18:20Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AccordionMinimalPerf.default	106	101	1.05:1	analysis
AlertMinimalPerf.default	214	219	0.98:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
RefMinimalPerf.default	185	158	1.17:1
PopupMinimalPerf.default	524	450	1.16:1
SkeletonMinimalPerf.default	281	244	1.15:1
TreeWith60ListItems.default	132	115	1.15:1
BoxMinimalPerf.default	275	242	1.14:1
InputMinimalPerf.default	1073	942	1.14:1
StatusMinimalPerf.default	613	549	1.12:1
ListWith60ListItems.default	509	460	1.11:1
DialogMinimalPerf.default	652	594	1.1:1
TableManyItemsPerf.default	1572	1425	1.1:1
EmbedMinimalPerf.default	3454	3187	1.08:1
SliderMinimalPerf.default	1396	1292	1.08:1
TreeMinimalPerf.default	676	629	1.07:1
AnimationMinimalPerf.default	445	423	1.05:1
AttachmentMinimalPerf.default	117	113	1.04:1
ItemLayoutMinimalPerf.default	974	934	1.04:1
SegmentMinimalPerf.default	256	245	1.04:1
IconMinimalPerf.default	509	489	1.04:1
AttachmentSlotsPerf.default	903	875	1.03:1
GridMinimalPerf.default	283	275	1.03:1
ImageMinimalPerf.default	271	263	1.03:1
MenuMinimalPerf.default	633	617	1.03:1
VideoMinimalPerf.default	494	481	1.03:1
DropdownManyItemsPerf.default	566	555	1.02:1
ListMinimalPerf.default	425	417	1.02:1
ProviderMergeThemesPerf.default	1037	1021	1.02:1
ButtonSlotsPerf.default	443	438	1.01:1
CheckboxMinimalPerf.default	2193	2164	1.01:1
FlexMinimalPerf.default	205	202	1.01:1
FormMinimalPerf.default	293	290	1.01:1
LabelMinimalPerf.default	342	339	1.01:1
ListCommonPerf.default	518	514	1.01:1
LoaderMinimalPerf.default	570	562	1.01:1
MenuButtonMinimalPerf.default	1329	1321	1.01:1
TableMinimalPerf.default	295	292	1.01:1
TextAreaMinimalPerf.default	410	407	1.01:1
CarouselMinimalPerf.default	400	399	1:1
ChatWithPopoverPerf.default	310	309	1:1
RosterPerf.default	861	861	1:1
ReactionMinimalPerf.default	305	304	1:1
CardMinimalPerf.default	438	443	0.99:1
ChatMinimalPerf.default	598	604	0.99:1
DatepickerMinimalPerf.default	4649	4719	0.99:1
DividerMinimalPerf.default	292	294	0.99:1
LayoutMinimalPerf.default	286	288	0.99:1
ToolbarMinimalPerf.default	769	775	0.99:1
ButtonMinimalPerf.default	129	132	0.98:1
ButtonOverridesMissPerf.default	1222	1242	0.98:1
DropdownMinimalPerf.default	2555	2609	0.98:1
HeaderSlotsPerf.default	637	647	0.98:1
ProviderMinimalPerf.default	320	326	0.98:1
SplitButtonMinimalPerf.default	3520	3595	0.98:1
TooltipMinimalPerf.default	880	906	0.97:1
TextMinimalPerf.default	262	276	0.95:1
CustomToolbarPrototype.default	2094	2195	0.95:1
AvatarMinimalPerf.default	136	150	0.91:1
ListNestedPerf.default	413	455	0.91:1
PortalMinimalPerf.default	124	138	0.9:1
ChatDuplicateMessagesPerf.default	213	240	0.89:1
HeaderMinimalPerf.default	260	291	0.89:1
RadioGroupMinimalPerf.default	320	359	0.89:1

fabricteam · 2022-08-17T07:30:11Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1099	1116	5000
Breadcrumb	mount	3058	2983	1000
Checkbox	mount	2981	2994	5000
CheckboxBase	mount	2594	2646	5000
ChoiceGroup	mount	5498	5500	5000
ComboBox	mount	1119	1122	1000
CommandBar	mount	11572	11618	1000
ContextualMenu	mount	13238	13231	1000
DefaultButton	mount	1370	1387	5000
DetailsRow	mount	4348	4394	5000
DetailsRowFast	mount	4294	4292	5000
DetailsRowNoStyles	mount	4223	4312	5000
Dialog	mount	3238	3173	1000
DocumentCardTitle	mount	205	237	1000
Dropdown	mount	3915	3835	5000
FocusTrapZone	mount	2079	2165	5000
FocusZone	mount	1960	1986	5000
IconButton	mount	2018	2078	5000
Label	mount	384	404	5000
Layer	mount	3592	3662	5000
Link	mount	557	569	5000
MenuButton	mount	1790	1741	5000
MessageBar	mount	2392	2425	5000
Nav	mount	3884	3829	1000
OverflowSet	mount	1300	1235	5000
Panel	mount	2396	2492	1000
Persona	mount	1152	1181	1000
Pivot	mount	1639	1721	1000
PrimaryButton	mount	1563	1552	5000
Rating	mount	9377	9262	5000
SearchBox	mount	1623	1559	5000
Shimmer	mount	2951	2883	5000
Slider	mount	2216	2221	5000
SpinButton	mount	5705	5738	5000
Spinner	mount	477	480	5000
SplitButton	mount	3719	3651	5000
Stack	mount	617	630	5000
StackWithIntrinsicChildren	mount	2860	2821	5000
StackWithTextChildren	mount	6404	6329	5000
SwatchColorPicker	mount	13277	13227	5000
TagPicker	mount	3220	3181	5000
TeachingBubble	mount	105836	107643	5000
Text	mount	528	529	5000
TextField	mount	1633	1661	5000
ThemeProvider	mount	1342	1358	5000
ThemeProvider	virtual-rerender	739	742	5000
ThemeProvider	virtual-rerender-with-unmount	1966	2023	5000
Toggle	mount	932	946	5000
buttonNative	mount	142	150	5000

chore: Scope screener builds by vr-test project

ea6a715

ling1726 marked this pull request as ready for review August 17, 2022 06:53

ling1726 requested a review from a team as a code owner August 17, 2022 06:53

msft-fluent-ui-bot assigned layershifter Aug 17, 2022

github-actions bot added this to the July Project Cycle Q3 2022 milestone Aug 17, 2022

ling1726 mentioned this pull request Aug 17, 2022

chore: Add VR tests for Table primitives #24386

Merged

tudorpopams approved these changes Aug 17, 2022

View reviewed changes

ling1726 enabled auto-merge (squash) August 17, 2022 07:31

ling1726 merged commit 066c685 into microsoft:master Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Scope screener builds by vr-test project#24395

chore: Scope screener builds by vr-test project#24395
ling1726 merged 1 commit intomicrosoft:masterfrom
ling1726:chore/fix-screener-scoping

ling1726 commented Aug 17, 2022

Uh oh!

codesandbox-ci bot commented Aug 17, 2022

Uh oh!

size-auditor bot commented Aug 17, 2022

Uh oh!

fabricteam commented Aug 17, 2022

Uh oh!

fabricteam commented Aug 17, 2022

Uh oh!

fabricteam commented Aug 17, 2022

Uh oh!

fabricteam commented Aug 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ling1726 commented Aug 17, 2022

Uh oh!

codesandbox-ci bot commented Aug 17, 2022

Uh oh!

size-auditor bot commented Aug 17, 2022

Asset size changes

Uh oh!

fabricteam commented Aug 17, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Aug 17, 2022

📊 Bundle size report

Uh oh!

fabricteam commented Aug 17, 2022

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

Uh oh!

fabricteam commented Aug 17, 2022

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)