Merged
Conversation
Co-authored-by: ling1726 <lingfangao@hotmail.com>
…ft/fluentui into screenerChecksTransition
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c1b6e28:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1302 | 1262 | 5000 | |
| Button | mount | 974 | 968 | 5000 | |
| FluentProvider | mount | 1599 | 1599 | 5000 | |
| FluentProviderWithTheme | mount | 630 | 636 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 592 | 598 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 635 | 665 | 10 | |
| MakeStyles | mount | 2033 | 1941 | 50000 | |
| SpinButton | mount | 2538 | 2482 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5d2617e9b90046a13a6e493c1e54c4b45101f509 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| ButtonMinimalPerf.default | 136 | 114 | 1.19:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ListMinimalPerf.default | 440 | 377 | 1.17:1 |
| ReactionMinimalPerf.default | 314 | 268 | 1.17:1 |
| VideoMinimalPerf.default | 539 | 475 | 1.13:1 |
| FormMinimalPerf.default | 327 | 294 | 1.11:1 |
| TableManyItemsPerf.default | 1568 | 1425 | 1.1:1 |
| AnimationMinimalPerf.default | 441 | 407 | 1.08:1 |
| SegmentMinimalPerf.default | 283 | 264 | 1.07:1 |
| TreeWith60ListItems.default | 132 | 124 | 1.06:1 |
| ChatWithPopoverPerf.default | 326 | 310 | 1.05:1 |
| DropdownManyItemsPerf.default | 559 | 533 | 1.05:1 |
| HeaderMinimalPerf.default | 304 | 290 | 1.05:1 |
| ItemLayoutMinimalPerf.default | 961 | 913 | 1.05:1 |
| LoaderMinimalPerf.default | 576 | 547 | 1.05:1 |
| RefMinimalPerf.default | 167 | 159 | 1.05:1 |
| CustomToolbarPrototype.default | 2316 | 2215 | 1.05:1 |
| DatepickerMinimalPerf.default | 4987 | 4801 | 1.04:1 |
| HeaderSlotsPerf.default | 628 | 603 | 1.04:1 |
| SliderMinimalPerf.default | 1434 | 1383 | 1.04:1 |
| ToolbarMinimalPerf.default | 732 | 703 | 1.04:1 |
| AccordionMinimalPerf.default | 128 | 124 | 1.03:1 |
| AvatarMinimalPerf.default | 151 | 147 | 1.03:1 |
| DropdownMinimalPerf.default | 2599 | 2528 | 1.03:1 |
| InputMinimalPerf.default | 1105 | 1068 | 1.03:1 |
| ProviderMergeThemesPerf.default | 1072 | 1040 | 1.03:1 |
| ProviderMinimalPerf.default | 345 | 336 | 1.03:1 |
| SplitButtonMinimalPerf.default | 3576 | 3464 | 1.03:1 |
| ButtonSlotsPerf.default | 452 | 443 | 1.02:1 |
| ChatMinimalPerf.default | 613 | 599 | 1.02:1 |
| DividerMinimalPerf.default | 299 | 292 | 1.02:1 |
| LabelMinimalPerf.default | 322 | 315 | 1.02:1 |
| ListCommonPerf.default | 523 | 515 | 1.02:1 |
| ListNestedPerf.default | 470 | 462 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1408 | 1383 | 1.02:1 |
| RadioGroupMinimalPerf.default | 382 | 375 | 1.02:1 |
| SkeletonMinimalPerf.default | 284 | 278 | 1.02:1 |
| AttachmentSlotsPerf.default | 807 | 798 | 1.01:1 |
| DialogMinimalPerf.default | 643 | 639 | 1.01:1 |
| CardMinimalPerf.default | 441 | 443 | 1:1 |
| ChatDuplicateMessagesPerf.default | 246 | 245 | 1:1 |
| FlexMinimalPerf.default | 241 | 242 | 1:1 |
| LayoutMinimalPerf.default | 291 | 291 | 1:1 |
| TableMinimalPerf.default | 331 | 330 | 1:1 |
| ImageMinimalPerf.default | 300 | 303 | 0.99:1 |
| MenuMinimalPerf.default | 713 | 718 | 0.99:1 |
| TextAreaMinimalPerf.default | 392 | 397 | 0.99:1 |
| TreeMinimalPerf.default | 636 | 644 | 0.99:1 |
| AttachmentMinimalPerf.default | 125 | 128 | 0.98:1 |
| CarouselMinimalPerf.default | 382 | 388 | 0.98:1 |
| EmbedMinimalPerf.default | 3338 | 3404 | 0.98:1 |
| RosterPerf.default | 903 | 917 | 0.98:1 |
| PopupMinimalPerf.default | 519 | 527 | 0.98:1 |
| IconMinimalPerf.default | 503 | 517 | 0.97:1 |
| ListWith60ListItems.default | 474 | 496 | 0.96:1 |
| TooltipMinimalPerf.default | 843 | 881 | 0.96:1 |
| BoxMinimalPerf.default | 267 | 280 | 0.95:1 |
| CheckboxMinimalPerf.default | 2068 | 2185 | 0.95:1 |
| StatusMinimalPerf.default | 512 | 549 | 0.93:1 |
| ButtonOverridesMissPerf.default | 1116 | 1232 | 0.91:1 |
| GridMinimalPerf.default | 242 | 271 | 0.89:1 |
| AlertMinimalPerf.default | 198 | 225 | 0.88:1 |
| TextMinimalPerf.default | 250 | 284 | 0.88:1 |
| PortalMinimalPerf.default | 123 | 143 | 0.86:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| TeachingBubble | mount | 48480 | 82648 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 809 | 704 | 5000 | |
| Breadcrumb | mount | 2200 | 2189 | 1000 | |
| Checkbox | mount | 2017 | 2135 | 5000 | |
| CheckboxBase | mount | 1973 | 1960 | 5000 | |
| ChoiceGroup | mount | 3830 | 3731 | 5000 | |
| ComboBox | mount | 812 | 802 | 1000 | |
| CommandBar | mount | 8972 | 9031 | 1000 | |
| ContextualMenu | mount | 9689 | 10253 | 1000 | |
| DefaultButton | mount | 923 | 934 | 5000 | |
| DetailsRow | mount | 3000 | 3090 | 5000 | |
| DetailsRowFast | mount | 3183 | 2990 | 5000 | |
| DetailsRowNoStyles | mount | 2936 | 2944 | 5000 | |
| Dialog | mount | 2229 | 2371 | 1000 | |
| DocumentCardTitle | mount | 153 | 135 | 1000 | |
| Dropdown | mount | 2658 | 2786 | 5000 | |
| FocusTrapZone | mount | 1569 | 1542 | 5000 | |
| FocusZone | mount | 1518 | 1587 | 5000 | |
| IconButton | mount | 1402 | 1462 | 5000 | |
| Label | mount | 313 | 263 | 5000 | |
| Layer | mount | 2620 | 2483 | 5000 | |
| Link | mount | 398 | 371 | 5000 | |
| MenuButton | mount | 1157 | 1223 | 5000 | |
| MessageBar | mount | 1763 | 1787 | 5000 | |
| Nav | mount | 2818 | 2588 | 1000 | |
| OverflowSet | mount | 916 | 920 | 5000 | |
| Panel | mount | 1861 | 1832 | 1000 | |
| Persona | mount | 823 | 844 | 1000 | |
| Pivot | mount | 1201 | 1262 | 1000 | |
| PrimaryButton | mount | 1051 | 1157 | 5000 | |
| Rating | mount | 6424 | 6570 | 5000 | |
| SearchBox | mount | 1073 | 1099 | 5000 | |
| Shimmer | mount | 2134 | 2089 | 5000 | |
| Slider | mount | 1663 | 1540 | 5000 | |
| SpinButton | mount | 4120 | 4227 | 5000 | |
| Spinner | mount | 377 | 342 | 5000 | |
| SplitButton | mount | 2654 | 2777 | 5000 | |
| Stack | mount | 404 | 449 | 5000 | |
| StackWithIntrinsicChildren | mount | 1949 | 1985 | 5000 | |
| StackWithTextChildren | mount | 4415 | 4468 | 5000 | |
| SwatchColorPicker | mount | 9690 | 9640 | 5000 | |
| TagPicker | mount | 2210 | 2466 | 5000 | |
| TeachingBubble | mount | 48480 | 82648 | 5000 | Possible regression |
| Text | mount | 361 | 378 | 5000 | |
| TextField | mount | 1200 | 1186 | 5000 | |
| ThemeProvider | mount | 934 | 1058 | 5000 | |
| ThemeProvider | virtual-rerender | 583 | 563 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1512 | 1508 | 5000 | |
| Toggle | mount | 690 | 693 | 5000 | |
| buttonNative | mount | 104 | 115 | 5000 |
4 tasks
added 5 commits
August 2, 2022 14:24
author Raluca Pelin <t-rpelin@microsoft.com> 1659439645 +0300 committer Raluca Pelin <t-rpelin@microsoft.com> 1659439711 +0300 parent e25a471 author Raluca Pelin <t-rpelin@microsoft.com> 1659439645 +0300 committer Raluca Pelin <t-rpelin@microsoft.com> 1659439665 +0300 Solve rebase conflict Remove screener jobs from pipeline Additional documentation Add checkout action option Add change suggested by review Restore pipeline from master branch Make changes proposed in review Update step name Co-authored-by: ling1726 <lingfangao@hotmail.com> Fix typo for environment variable value Change workflow trigger event and remove ADO screener jobs Comment out screener code check Remove screener code check
…oft/fluentui into enable-screener-workflows
ling1726
reviewed
Aug 4, 2022
1 task
Hotell
reviewed
Aug 4, 2022
| displayName: Cypress E2E tests | ||
|
|
||
| - template: .devops/templates/cleanup.yml | ||
|
|
This was referenced Aug 5, 2022
This was referenced Aug 8, 2022
Closed
Closed
layershifter
pushed a commit
to layershifter/office-ui-fabric-react
that referenced
this pull request
Aug 8, 2022
This reverts commit 596ed97. Co-authored-by: ling1726 <lingfangao@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Screener runs are triggered via Azure DevOps pipelines.
New Behavior
Screener runs are triggered via GitHub Actions workflows added in PR #24106.
Related Issue(s)
Addresses #23903