Progress scaffold & implementation#24023
Merged
tomi-msft merged 50 commits intomicrosoft:masterfrom Sep 30, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 884dd4a:
|
Collaborator
📊 Bundle size report
🤖 This report was generated against 6a60b17a2e1ef2709a76c5b209d3b579e437feba |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6a60b17a2e1ef2709a76c5b209d3b579e437feba (build) |
packages/react-components/react-progress/src/components/Progress/DefaultDiv.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/renderProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressState.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/stories/Progress/ProgressDescription.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
behowell
reviewed
Sep 27, 2022
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/stories/Progress/ProgressAppearance.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-progress/src/stories/Progress/index.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
behowell
reviewed
Sep 29, 2022
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/stories/Progress/ProgressBestPractices.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/stories/Progress/ProgressBestPractices.md
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/stories/Progress/ProgressDefault.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/stories/Progress/ProgressTypes.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/stories/Progress/ProgressDefault.stories.tsx
Outdated
Show resolved
Hide resolved
behowell
reviewed
Sep 30, 2022
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
Member
layershifter
left a comment
There was a problem hiding this comment.
Love the latest changes, great job in simplifying styles 👏
packages/react-components/react-progress/bundle-size/Progress.fixture.js
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Show resolved
Hide resolved
layershifter
approved these changes
Sep 30, 2022
behowell
reviewed
Sep 30, 2022
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
behowell
approved these changes
Sep 30, 2022
Contributor
behowell
left a comment
There was a problem hiding this comment.
Looks good, just a few more comments to resolve before merging, thanks!
packages/react-components/react-progress/src/components/Progress/Progress.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgress.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-progress/src/components/Progress/useProgressStyles.ts
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
pushed a commit
to GeoffCoxMSFT/fluentui
that referenced
this pull request
Oct 3, 2022
* Progress scaffold & implementation * Update state styling and stories * update dependencies * remove dup script from package.json * Add appearance props and update styling * api update * add test to disabled conformance test array * Add testOptions * Add size styling and stories * api update * Apply suggestions from code review Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com> * react-label version update * Update styling and package.json * api update * fix dependency mismatch * Apply suggestions from code review Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Remove progressState file * remove random spinbutton change * fix dependency mismatch * Add slots and update styling * Update styling and add new slots * add specificity to determinate style * fix positioning * remove unused file * api update * Apply suggestions from code review Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com> * Apply changes from code review * Clean up stories * Update snapshot * api update * Apply suggestions from code review Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Remove animation from examples and cleanup * cleanup * revert README.md * update snapshot * revert README.md * Fix stories * api update Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com> Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* Progress scaffold & implementation * Update state styling and stories * update dependencies * remove dup script from package.json * Add appearance props and update styling * api update * add test to disabled conformance test array * Add testOptions * Add size styling and stories * api update * Apply suggestions from code review Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com> * react-label version update * Update styling and package.json * api update * fix dependency mismatch * Apply suggestions from code review Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Remove progressState file * remove random spinbutton change * fix dependency mismatch * Add slots and update styling * Update styling and add new slots * add specificity to determinate style * fix positioning * remove unused file * api update * Apply suggestions from code review Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com> * Apply changes from code review * Clean up stories * Update snapshot * api update * Apply suggestions from code review Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Remove animation from examples and cleanup * cleanup * revert README.md * update snapshot * revert README.md * Fix stories * api update Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com> Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation for
Progressand all the storybook stories. The followup PR will have all the testing