Skip to content

change v9docs start to use docs mode to replicate public view#23736

Merged
micahgodbolt merged 1 commit intomicrosoft:masterfrom
micahgodbolt:v9docs-storybookdefault-docs
Jun 27, 2022
Merged

change v9docs start to use docs mode to replicate public view#23736
micahgodbolt merged 1 commit intomicrosoft:masterfrom
micahgodbolt:v9docs-storybookdefault-docs

Conversation

@micahgodbolt
Copy link
Copy Markdown
Member

Running start from the root runs the v9 docs in the non-docs mode, which is not what we publish to chromatic. This change will make it so you don't have to run storybook:dev from the v9 docs folder to get the correct options.

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21d18ae:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

"just": "just-scripts",
"lint": "just-scripts lint",
"start": "just-scripts dev:storybook",
"start": "yarn storybook:docs",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I want to run the previous version of the start script how do I do that now?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running yarn storybook from the package root would do it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there just isn't much reason to do so. the chromatic command will publish the --docs version

@fabricteam
Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 60ac3d4ddab13dcc66b64cc837ffb39646fabfbd

@size-auditor
Copy link
Copy Markdown

size-auditor bot commented Jun 27, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 60ac3d4ddab13dcc66b64cc837ffb39646fabfbd (build)

@micahgodbolt micahgodbolt enabled auto-merge (squash) June 27, 2022 18:32
@micahgodbolt micahgodbolt merged commit 118f7dd into microsoft:master Jun 27, 2022
@micahgodbolt micahgodbolt deleted the v9docs-storybookdefault-docs branch June 27, 2022 21:04
rohitpagariya pushed a commit to rohitpagariya/fluentui that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants