theme designer: fix tab states#23729
Merged
emmayjiang merged 6 commits intomicrosoft:masterfrom Jun 27, 2022
emmayjiang:theme-designer-fix-tab-states
Merged
theme designer: fix tab states#23729emmayjiang merged 6 commits intomicrosoft:masterfrom emmayjiang:theme-designer-fix-tab-states
emmayjiang merged 6 commits intomicrosoft:masterfrom
emmayjiang:theme-designer-fix-tab-states
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against 5e326ed2e7068e8eb75df4a54495c27206ec831b |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 057a704:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f9504b54b73caba83893c92fe0352153d4012312 (build) |
Member
|
this allows form state to persist across tab switching. i agree that this is a better bit of UI rather than losing your custom theme just by switching tabs. Checked the deploy site and i'm not seeing any of the focus loss issues we had in the past. |
micahgodbolt
approved these changes
Jun 27, 2022
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
* add custom theme to export * add typing, update format * remove reducer * preserve custom state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a local state to sidebar that allows for the custom theme to be stored, and also so that switching tabs/switching themes updates correctly.