chore: Add generator to make all rc deps carets#23719
Merged
ling1726 merged 9 commits intomicrosoft:masterfrom Jun 27, 2022
Merged
chore: Add generator to make all rc deps carets#23719ling1726 merged 9 commits intomicrosoft:masterfrom
ling1726 merged 9 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
ling1726
commented
Jun 24, 2022
| "@fluentui/styles": "^0.63.1", | ||
| "@hot-loader/react-dom": "16.14.0", | ||
| "@mdx-js/react": "^1.5.5", | ||
| "@types/semver": "^5.5.0", |
Contributor
Author
There was a problem hiding this comment.
this should never have been a dependency
tools/utils.ts
Outdated
Comment on lines
+186
to
+188
| export function isPackageVersionConverged(version: string) { | ||
| return version.startsWith('9.'); | ||
| } |
Member
There was a problem hiding this comment.
Once this will start with a caret it will be no longer safe, do you want to change this?
Contributor
Author
There was a problem hiding this comment.
I've never actually changed it, I've just moved it out to another function. but I get your point, I'll do a semver.parse on it
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3f20d48:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1366 | 1386 | 5000 | |
| Button | mount | 1017 | 1021 | 5000 | |
| FluentProvider | mount | 1878 | 1677 | 5000 | |
| FluentProviderWithTheme | mount | 753 | 700 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 708 | 626 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 742 | 714 | 10 | |
| MakeStyles | mount | 2078 | 1994 | 50000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ImageMinimalPerf.default | 378 | 349 | 1.08:1 |
| HeaderSlotsPerf.default | 783 | 732 | 1.07:1 |
| TreeWith60ListItems.default | 169 | 158 | 1.07:1 |
| ButtonMinimalPerf.default | 174 | 164 | 1.06:1 |
| FormMinimalPerf.default | 414 | 391 | 1.06:1 |
| SkeletonMinimalPerf.default | 349 | 329 | 1.06:1 |
| GridMinimalPerf.default | 344 | 328 | 1.05:1 |
| PortalMinimalPerf.default | 180 | 171 | 1.05:1 |
| TextMinimalPerf.default | 343 | 326 | 1.05:1 |
| VideoMinimalPerf.default | 653 | 623 | 1.05:1 |
| CardMinimalPerf.default | 564 | 543 | 1.04:1 |
| ListCommonPerf.default | 634 | 611 | 1.04:1 |
| RefMinimalPerf.default | 258 | 247 | 1.04:1 |
| DropdownManyItemsPerf.default | 692 | 675 | 1.03:1 |
| FlexMinimalPerf.default | 291 | 282 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 1206 | 1170 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1753 | 1710 | 1.03:1 |
| RadioGroupMinimalPerf.default | 440 | 429 | 1.03:1 |
| SegmentMinimalPerf.default | 349 | 339 | 1.03:1 |
| IconMinimalPerf.default | 610 | 590 | 1.03:1 |
| AnimationMinimalPerf.default | 559 | 550 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1514 | 1489 | 1.02:1 |
| ButtonSlotsPerf.default | 540 | 530 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 293 | 287 | 1.02:1 |
| ListWith60ListItems.default | 633 | 621 | 1.02:1 |
| LoaderMinimalPerf.default | 693 | 684 | 1.01:1 |
| MenuMinimalPerf.default | 850 | 840 | 1.01:1 |
| ProviderMinimalPerf.default | 407 | 402 | 1.01:1 |
| ReactionMinimalPerf.default | 376 | 373 | 1.01:1 |
| SplitButtonMinimalPerf.default | 4436 | 4406 | 1.01:1 |
| TextAreaMinimalPerf.default | 484 | 478 | 1.01:1 |
| CustomToolbarPrototype.default | 2788 | 2763 | 1.01:1 |
| ChatWithPopoverPerf.default | 371 | 371 | 1:1 |
| CheckboxMinimalPerf.default | 2734 | 2732 | 1:1 |
| EmbedMinimalPerf.default | 4158 | 4145 | 1:1 |
| InputMinimalPerf.default | 1296 | 1297 | 1:1 |
| ListMinimalPerf.default | 510 | 508 | 1:1 |
| PopupMinimalPerf.default | 630 | 629 | 1:1 |
| ProviderMergeThemesPerf.default | 1265 | 1269 | 1:1 |
| TableManyItemsPerf.default | 1936 | 1937 | 1:1 |
| TableMinimalPerf.default | 391 | 392 | 1:1 |
| ToolbarMinimalPerf.default | 953 | 954 | 1:1 |
| TreeMinimalPerf.default | 815 | 817 | 1:1 |
| AccordionMinimalPerf.default | 145 | 147 | 0.99:1 |
| AlertMinimalPerf.default | 261 | 264 | 0.99:1 |
| AttachmentMinimalPerf.default | 148 | 150 | 0.99:1 |
| CarouselMinimalPerf.default | 467 | 474 | 0.99:1 |
| ChatMinimalPerf.default | 724 | 729 | 0.99:1 |
| DatepickerMinimalPerf.default | 5868 | 5931 | 0.99:1 |
| DialogMinimalPerf.default | 775 | 781 | 0.99:1 |
| DropdownMinimalPerf.default | 3146 | 3164 | 0.99:1 |
| LabelMinimalPerf.default | 371 | 374 | 0.99:1 |
| SliderMinimalPerf.default | 1680 | 1702 | 0.99:1 |
| StatusMinimalPerf.default | 671 | 680 | 0.99:1 |
| DividerMinimalPerf.default | 340 | 348 | 0.98:1 |
| LayoutMinimalPerf.default | 344 | 350 | 0.98:1 |
| ListNestedPerf.default | 547 | 557 | 0.98:1 |
| TooltipMinimalPerf.default | 1124 | 1144 | 0.98:1 |
| AttachmentSlotsPerf.default | 1090 | 1124 | 0.97:1 |
| BoxMinimalPerf.default | 335 | 347 | 0.97:1 |
| RosterPerf.default | 1103 | 1133 | 0.97:1 |
| HeaderMinimalPerf.default | 354 | 368 | 0.96:1 |
| AvatarMinimalPerf.default | 185 | 194 | 0.95:1 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 02ee30f8ef173f3a1d2c0c73bcdaef8abae5c055 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 784 | 784 | 5000 | |
| Breadcrumb | mount | 2290 | 2252 | 1000 | |
| Checkbox | mount | 1257 | 1250 | 5000 | |
| CheckboxBase | mount | 1076 | 1080 | 5000 | |
| ChoiceGroup | mount | 3957 | 3900 | 5000 | |
| ComboBox | mount | 783 | 760 | 1000 | |
| CommandBar | mount | 8787 | 8822 | 1000 | |
| ContextualMenu | mount | 9323 | 9315 | 1000 | |
| DefaultButton | mount | 948 | 973 | 5000 | |
| DetailsRow | mount | 3118 | 3054 | 5000 | |
| DetailsRowFast | mount | 3126 | 3085 | 5000 | |
| DetailsRowNoStyles | mount | 2926 | 2908 | 5000 | |
| Dialog | mount | 2340 | 2299 | 1000 | |
| DocumentCardTitle | mount | 151 | 159 | 1000 | |
| Dropdown | mount | 2821 | 2830 | 5000 | |
| FocusTrapZone | mount | 1579 | 1582 | 5000 | |
| FocusZone | mount | 1523 | 1516 | 5000 | |
| IconButton | mount | 1393 | 1388 | 5000 | |
| Label | mount | 328 | 332 | 5000 | |
| Layer | mount | 2558 | 2552 | 5000 | |
| Link | mount | 422 | 434 | 5000 | |
| MenuButton | mount | 1200 | 1230 | 5000 | |
| MessageBar | mount | 1883 | 1823 | 5000 | |
| Nav | mount | 2586 | 2644 | 1000 | |
| OverflowSet | mount | 988 | 991 | 5000 | |
| Panel | mount | 1788 | 1822 | 1000 | |
| Persona | mount | 851 | 855 | 1000 | |
| Pivot | mount | 1132 | 1124 | 1000 | |
| PrimaryButton | mount | 1095 | 1091 | 5000 | |
| Rating | mount | 6683 | 6622 | 5000 | |
| SearchBox | mount | 1128 | 1126 | 5000 | |
| Shimmer | mount | 2191 | 2210 | 5000 | |
| Slider | mount | 1679 | 1673 | 5000 | |
| SpinButton | mount | 3933 | 3945 | 5000 | |
| Spinner | mount | 408 | 408 | 5000 | |
| SplitButton | mount | 2509 | 2458 | 5000 | |
| Stack | mount | 479 | 485 | 5000 | |
| StackWithIntrinsicChildren | mount | 1892 | 1858 | 5000 | |
| StackWithTextChildren | mount | 4674 | 4630 | 5000 | |
| SwatchColorPicker | mount | 9046 | 9103 | 5000 | |
| TagPicker | mount | 2015 | 2016 | 5000 | |
| TeachingBubble | mount | 70999 | 70304 | 5000 | |
| Text | mount | 389 | 395 | 5000 | |
| TextField | mount | 1196 | 1165 | 5000 | |
| ThemeProvider | mount | 952 | 946 | 5000 | |
| ThemeProvider | virtual-rerender | 600 | 615 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1434 | 1456 | 5000 | |
| Toggle | mount | 729 | 702 | 5000 | |
| buttonNative | mount | 101 | 103 | 5000 |
TristanWatanabe
approved these changes
Jun 24, 2022
Co-authored-by: Tristan Watanabe <tristan.watanabe@gmail.com>
…726/fluentui into chore/generator-caret-deps
layershifter
approved these changes
Jun 27, 2022
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
* chore: Add generator to make all rc deps carets * add missing * rename to rc-caret * remove @types/semver as dep * use semver to parse version string * remove non-existing options * Update tools/generators/rc-caret/index.ts Co-authored-by: Tristan Watanabe <tristan.watanabe@gmail.com> * rename host to tree Co-authored-by: Tristan Watanabe <tristan.watanabe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for final release, creates a generator that will transform all RC pinned dependencies to caret dependencies
README.md has more documentation on what this generator does