Skip to content

react-select: export change data type#23701

Merged
smhigley merged 2 commits intomicrosoft:masterfrom
smhigley:select-onchangedata
Jun 27, 2022
Merged

react-select: export change data type#23701
smhigley merged 2 commits intomicrosoft:masterfrom
smhigley:select-onchangedata

Conversation

@smhigley
Copy link
Copy Markdown
Contributor

@smhigley smhigley commented Jun 23, 2022

Export SelectOnChangeData from react-select

@smhigley smhigley self-assigned this Jun 23, 2022
@smhigley smhigley requested a review from a team as a code owner June 23, 2022 17:25
@github-actions github-actions bot added this to the June Project Cycle Q2 2022 milestone Jun 23, 2022
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 23, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d05759:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Jun 23, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.067 kB
52.144 kB
react-components
react-components: FluentProvider & webLightTheme
31.883 kB
10.516 kB
react-select
Select
20.002 kB
7.171 kB
🤖 This report was generated against 5e326ed2e7068e8eb75df4a54495c27206ec831b

@size-auditor
Copy link
Copy Markdown

size-auditor bot commented Jun 23, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5e326ed2e7068e8eb75df4a54495c27206ec831b (build)

@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Jun 23, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1403 1401 5000
Button mount 1061 1047 5000
FluentProvider mount 1901 1939 5000
FluentProviderWithTheme mount 729 718 10
FluentProviderWithTheme virtual-rerender 682 680 10
FluentProviderWithTheme virtual-rerender-with-unmount 766 741 10
MakeStyles mount 2044 2046 50000

Copy link
Copy Markdown
Member

@khmakoto khmakoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description to the PR (even if it's exactly the same as the title).

@smhigley smhigley merged commit 81a5050 into microsoft:master Jun 27, 2022
rohitpagariya pushed a commit to rohitpagariya/fluentui that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants