feat(react-utilities): extend Slot to support VoidFunctionComponents#23408
Merged
theerebuss merged 1 commit intomicrosoft:masterfrom Jun 6, 2022
theerebuss:allow-void-function-component-slots
Merged
feat(react-utilities): extend Slot to support VoidFunctionComponents#23408theerebuss merged 1 commit intomicrosoft:masterfrom theerebuss:allow-void-function-component-slots
Slot to support VoidFunctionComponents#23408theerebuss merged 1 commit intomicrosoft:masterfrom
theerebuss:allow-void-function-component-slots
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9885b32:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1745 | 917 | 5000 | Possible regression |
| FluentProviderWithTheme | mount | 249 | 677 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1745 | 917 | 5000 | Possible regression |
| Button | mount | 572 | 558 | 5000 | |
| FluentProvider | mount | 1735 | 1755 | 5000 | |
| FluentProviderWithTheme | mount | 249 | 677 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 220 | 222 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 257 | 302 | 10 | |
| MakeStyles | mount | 1554 | 1560 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: eec5395ef1eabcfea6cf4c2ae48f928a35980694 (build) |
bsunderhus
approved these changes
Jun 6, 2022
Contributor
bsunderhus
left a comment
There was a problem hiding this comment.
LGTM, VoidFunctionComponent type is equivalent to FunctionComponent without forcing children on props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Our
Slottype does not currently support components that take nochildrenprop.New Behavior
Slotnow extendsVoidFunctionComponentto allow for such behavior.