react-avatar: Adding AvatarGroupItem implementation and AvatarGroup context#23310
Merged
sopranopillow merged 9 commits intomicrosoft:masterfrom Jun 2, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 525bd0e:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1050 | 1115 | 5000 | |
| Button | mount | 676 | 679 | 5000 | |
| FluentProvider | mount | 2267 | 2282 | 5000 | |
| FluentProviderWithTheme | mount | 352 | 333 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 296 | 300 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 388 | 350 | 10 | |
| MakeStyles | mount | 1925 | 1888 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 143f4ac9fb4eef165e4975bcf3b113bc00680e03 (build) |
behowell
reviewed
Jun 1, 2022
packages/react-components/react-avatar/src/components/AvatarGroupItem/AvatarGroupItem.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/components/AvatarGroupItem/useAvatarGroupItem.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/components/AvatarGroup/AvatarGroup.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/contexts/useAvatarGroupContextValues.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/components/AvatarGroup/useAvatarGroup.ts
Show resolved
Hide resolved
packages/react-components/react-avatar/src/components/AvatarGroup/useAvatarGroup.ts
Show resolved
Hide resolved
packages/react-components/react-avatar/src/components/AvatarGroupItem/AvatarGroupItem.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/components/AvatarGroupItem/useAvatarGroupItem.ts
Outdated
Show resolved
Hide resolved
...ges/react-components/react-avatar/src/components/AvatarGroupItem/useAvatarGroupItemStyles.ts
Outdated
Show resolved
Hide resolved
behowell
approved these changes
Jun 1, 2022
Contributor
behowell
left a comment
There was a problem hiding this comment.
Looks good, thanks for making the changes! Just a few more comments :)
packages/react-components/react-avatar/src/stories/AvatarGroupItemDefault.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/contexts/AvatarGroupContext.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/components/AvatarGroupItem/AvatarGroupItem.tsx
Show resolved
Hide resolved
packages/react-components/react-avatar/src/components/AvatarGroupItem/renderAvatarGroupItem.tsx
Outdated
Show resolved
Hide resolved
...ges/react-components/react-avatar/src/components/AvatarGroupItem/useAvatarGroupItemStyles.ts
Show resolved
Hide resolved
…vatargroupitem-implementation
34 tasks
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…ontext (microsoft#23310) * Adding AvatarGroupItem implementation and AvatarGroup context. * change files * fixing lint errors * adding requested changes * updating types for root slot * updating name of overflowlabel styles * Adding requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
This PR does the following:
AvatarGroupItem.AvatarGroupcontext to be consumed byAvatarGroupItem.NOTE: There are some changes, such as removing string from
AvatarGroup, that will be made in a separate PR #22736. This PR modifiesAvatarGrouponly to add the context sinceAvatarGroupItemrequires it for its functionality, and to pass build/tests.Related Issue(s)
#22240, #22736