fix: Bump react-conformance in react-conformance griffel#23146
Merged
spmonahan merged 2 commits intomicrosoft:masterfrom May 23, 2022
Merged
fix: Bump react-conformance in react-conformance griffel#23146spmonahan merged 2 commits intomicrosoft:masterfrom
spmonahan merged 2 commits intomicrosoft:masterfrom
Conversation
Fixes an issue where the peer dependency creates 'phantom bumps' by beachball during publishing. This is most likely the result of a bug in beachball but we don't have a solid repro yet. Fixing this quickly to unblock RC releases. @spmonahan please link an issue to this PR
miroslavstastny
approved these changes
May 23, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1e61f6f:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: aa1f446e037786d74a3c14f0bee09dbcf403a929 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1208 | 1189 | 5000 | |
| Button | mount | 713 | 713 | 5000 | |
| FluentProvider | mount | 2187 | 2177 | 5000 | |
| FluentProviderWithTheme | mount | 373 | 375 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 353 | 330 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 392 | 388 | 10 | |
| MakeStyles | mount | 1846 | 1879 | 50000 |
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…3146) * fix: Bump react-conformance in react-conformance griffel Fixes an issue where the peer dependency creates 'phantom bumps' by beachball during publishing. This is most likely the result of a bug in beachball but we don't have a solid repro yet. Fixing this quickly to unblock RC releases. @spmonahan please link an issue to this PR * changefile
ling1726
added a commit
to ling1726/fluentui
that referenced
this pull request
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the peer dependency creates 'phantom bumps' by
beachball during publishing. This is most likely the result of a bug in
beachball but we don't have a solid repro yet.
Fixing this quickly to unblock RC releases.
Bug report: #23147