Input: update appearance stories#22966
Merged
spmonahan merged 3 commits intomicrosoft:masterfrom May 13, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3578001:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1030 | 1075 | 5000 | |
| Button | mount | 659 | 653 | 5000 | |
| FluentProvider | mount | 2217 | 2242 | 5000 | |
| FluentProviderWithTheme | mount | 322 | 325 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 271 | 249 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 363 | 384 | 10 | |
| MakeStyles | mount | 1827 | 1831 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: fdb6dc95fdd003e61b2e6f1eaa361c9d8e588b72 (build) |
Updates the background contrast for the filledDarker and filledLighter appearances in Storybook. This ensures the story demonstrates an acceptable background color from an accessible contrast perspective. I've also added the design guidance about contrast to the story to ensure the topic clearly visible to users.
194f94d to
4b2da97
Compare
khmakoto
approved these changes
May 12, 2022
packages/react-components/react-input/src/stories/InputAppearance.stories.tsx
Outdated
Show resolved
Hide resolved
- Adds a "Do's" and "Don'ts" section to Input Storybook. - Removes some commented out styles from appearance story.
6 tasks
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* react-input: update appearance stories background contrast Updates the background contrast for the filledDarker and filledLighter appearances in Storybook. This ensures the story demonstrates an acceptable background color from an accessible contrast perspective. I've also added the design guidance about contrast to the story to ensure the topic clearly visible to users. * react-input: add do's and don'ts - Adds a "Do's" and "Don'ts" section to Input Storybook. - Removes some commented out styles from appearance story. * react-input: add react-text to devdependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
filledDarkerandfilledLighter"Appearance" stories have insufficient contrast with their backgrounds.New Behavior
filledDarkerandfilledLighter"Appreance" stories have sufficient contrast with their backgrounds.Related Issue(s)
Fixes #21449