Radio: Add required prop to RadioGroup#22809
Merged
spmonahan merged 1 commit intomicrosoft:masterfrom May 3, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0a5b55b:
|
Collaborator
📊 Bundle size report
🤖 This report was generated against f542a2a06d0b71bb5c9bd19fed0a8c08ee6b2b0f |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9132814df4b6d40d1f5d93d8324d756c1284b294 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1094 | 1054 | 5000 | |
| Button | mount | 673 | 666 | 5000 | |
| FluentProvider | mount | 2241 | 2274 | 5000 | |
| FluentProviderWithTheme | mount | 358 | 333 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 287 | 274 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 367 | 366 | 10 | |
| MakeStyles | mount | 1895 | 1877 | 50000 |
Adds a `required` prop to `RadioGroup` that is passed down to all child `Radio`s via context. Previously a user had to set `required` on each child `Radio` which was a lot of extra typing plus it opened the component up to easy misuse -- it doesn't make sense for a single radio in a group to be required and not others.
c4d3d29 to
0a5b55b
Compare
khmakoto
approved these changes
May 3, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
Adds a `required` prop to `RadioGroup` that is passed down to all child `Radio`s via context. Previously a user had to set `required` on each child `Radio` which was a lot of extra typing plus it opened the component up to easy misuse -- it doesn't make sense for a single radio in a group to be required and not others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
RadioGrouplacks arequiredprop so each individual childRadiomust set itsrequiredprop to make a group required.New Behavior
RadioGrouphas arequiredprop that is passed down to all childRadios via context.Related Issue(s)
Fixes #22766